From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Maksym Kokhan <maksym.kokhan@globallogic.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Daniel Walker <dwalker@fifo99.com>,
Daniel Walker <danielwa@cisco.com>,
Andrii Bordunov <aborduno@cisco.com>,
Ruslan Bilovol <rbilovol@cisco.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
linux-mips <linux-mips@linux-mips.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 0/8] add generic builtin command line
Date: Thu, 27 Sep 2018 19:05:44 +0200 [thread overview]
Message-ID: <CAKv+Gu-AxtOO04iwPSri12tkb9NRugXV9E2LGrfJT-LJjf4_ow@mail.gmail.com> (raw)
In-Reply-To: <1538067309-5711-1-git-send-email-maksym.kokhan@globallogic.com>
On 27 September 2018 at 18:55, Maksym Kokhan
<maksym.kokhan@globallogic.com> wrote:
> There were series of patches [1] for 4.3.0-rc3, that allowed
> architectures to use a generic builtin command line. I have rebased
> these patches on kernel 4.19.0-rc4.
>
Could you please elaborate on the purpose of this series? Is it simply
to align between architectures? Does it solve an actual problem?
> Things, modified in comparison with original patches:
> * There was some bug for mips, in the case when CONFIG_CMDLINE_PREPEND
> and CONFIG_CMDLINE_APPEND are empty and CMDLINE_OVERRIDE is not set,
> command line from bootloader was ignored, so I fixed it, modifying
> patch "add generic builtin command line".
>
> * Implemented new patch to resolve conflict with new kernel, which
> modify EFI stub code. Unfortunately, I don't have capability to test
> this modification on real arm board with EFI.
>
> * Removed new realisation of mips builtin command line, which was
> created after 4.3.0-rc3.
>
> * Kernel 4.3.0-rc3 with original patches could not be compiled for
> powerpc due to prom_init.c checking by prom_init_check.sh. So I added
> strlcat (which is used by cmdline_add_builtin macro) to
> prom_init_check.sh whitelist.
>
> Patches have been tested in QEMU for x86, arm (little-endian), arm64
> (little-endian), mips (little-endian, 32-bit) and powerpc
> (big-endian, 64-bit), everything works perfectly. Also it was tested
> on linux-next (next-20180924 tag) for all listed above architectures.
>
> [1] : https://lore.kernel.org/patchwork/patch/604992/
>
> Daniel Walker (7):
> add generic builtin command line
> drivers: of: ifdef out cmdline section
> x86: convert to generic builtin command line
> arm: convert to generic builtin command line
> arm64: convert to generic builtin command line
> mips: convert to generic builtin command line
> powerpc: convert to generic builtin command line
>
> Maksym Kokhan (1):
> efi: modify EFI stub code for arm/arm64
>
> arch/arm/Kconfig | 38 +-----------------
> arch/arm/kernel/atags_parse.c | 14 ++-----
> arch/arm/kernel/devtree.c | 2 +
> arch/arm64/Kconfig | 17 +-------
> arch/arm64/kernel/setup.c | 3 ++
> arch/mips/Kconfig | 24 +----------
> arch/mips/Kconfig.debug | 47 ----------------------
> arch/mips/kernel/setup.c | 41 ++-----------------
> arch/powerpc/Kconfig | 23 +----------
> arch/powerpc/kernel/prom.c | 4 ++
> arch/powerpc/kernel/prom_init.c | 8 ++--
> arch/powerpc/kernel/prom_init_check.sh | 2 +-
> arch/x86/Kconfig | 44 +--------------------
> arch/x86/kernel/setup.c | 19 ++-------
> drivers/firmware/efi/libstub/arm-stub.c | 10 ++---
> drivers/of/fdt.c | 2 +-
> include/linux/cmdline.h | 70 +++++++++++++++++++++++++++++++++
> init/Kconfig | 68 ++++++++++++++++++++++++++++++++
> 18 files changed, 173 insertions(+), 263 deletions(-)
> create mode 100644 include/linux/cmdline.h
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-09-27 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 16:55 [PATCH 0/8] add generic builtin command line Maksym Kokhan
2018-09-27 16:55 ` [PATCH 1/8] " Maksym Kokhan
2018-09-27 17:05 ` Ard Biesheuvel [this message]
2018-09-27 18:08 ` [PATCH 0/8] " Daniel Walker
2018-09-29 18:17 ` dwalker
2018-10-08 18:01 ` Maksym Kokhan
2018-10-23 14:43 ` Maksym Kokhan
2018-10-23 14:48 ` Russell King - ARM Linux
2018-10-24 8:57 ` Maksym Kokhan
2018-10-24 9:07 ` Russell King - ARM Linux
2018-10-29 10:29 ` Will Deacon
2018-10-29 10:44 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-AxtOO04iwPSri12tkb9NRugXV9E2LGrfJT-LJjf4_ow@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=aborduno@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=danielwa@cisco.com \
--cc=devicetree@vger.kernel.org \
--cc=dwalker@fifo99.com \
--cc=frowand.list@gmail.com \
--cc=hpa@zytor.com \
--cc=jhogan@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maksym.kokhan@globallogic.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rbilovol@cisco.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).