* [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
@ 2019-10-13 18:57 Narendra.K
2019-10-13 19:15 ` Narendra.K
2019-10-14 6:41 ` Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Narendra.K @ 2019-10-13 18:57 UTC (permalink / raw)
To: linux-efi
Cc: ard.biesheuvel, Mario.Limonciello, geert, mingo, tglx,
james.morse, linux-kernel, Narendra.K
From: Narendra K <Narendra.K@dell.com>
For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
for input on platforms where the option may not be applicable. This patch
modifies the kconfig option to ask the user for input only when CONFIG_X86
or CONFIG_COMPILE_TEST is set to y.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Narendra K <Narendra.K@dell.com>
---
drivers/firmware/efi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 178ee8106828..b248870a9806 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
config EFI_RCI2_TABLE
bool "EFI Runtime Configuration Interface Table Version 2 Support"
+ depends on X86 || COMPILE_TEST
help
Displays the content of the Runtime Configuration Interface
Table version 2 on Dell EMC PowerEdge systems as a binary
--
2.18.1
--
With regards,
Narendra K
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
2019-10-13 18:57 [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Narendra.K
@ 2019-10-13 19:15 ` Narendra.K
2019-10-14 6:41 ` Geert Uytterhoeven
1 sibling, 0 replies; 5+ messages in thread
From: Narendra.K @ 2019-10-13 19:15 UTC (permalink / raw)
To: Narendra.K
Cc: linux-efi, ard.biesheuvel, Mario.Limonciello, geert, mingo, tglx,
james.morse, linux-kernel
Hi Ard,
On Sun, Oct 13, 2019 at 06:57:05PM +0000, K, Narendra wrote:
> From: Narendra K <Narendra.K@dell.com>
>
> For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> for input on platforms where the option may not be applicable. This patch
> modifies the kconfig option to ask the user for input only when CONFIG_X86
> or CONFIG_COMPILE_TEST is set to y.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Narendra K <Narendra.K@dell.com>
> ---
I missed mentioning the following details -
This patch is created on kernel version 5.4-rc2
Changes in v1:
- dropped following changes
'depends on EFI' as it is implied
'default n' as 'n' is the default if not mentioned
splitting 'bool' to 'bool + prompt'
- added dependency on X86 || COMPILE_TEST
- added the 'Reported-by:' and 'Fix-suggested-by:' to give credit to
Geert Uytterhoeven who reported the issue and suggested the fix
> drivers/firmware/efi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 178ee8106828..b248870a9806 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
>
> config EFI_RCI2_TABLE
> bool "EFI Runtime Configuration Interface Table Version 2 Support"
> + depends on X86 || COMPILE_TEST
> help
> Displays the content of the Runtime Configuration Interface
> Table version 2 on Dell EMC PowerEdge systems as a binary
> --
> 2.18.1
>
> --
> With regards,
> Narendra K
--
With regards,
Narendra K
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
2019-10-13 18:57 [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Narendra.K
2019-10-13 19:15 ` Narendra.K
@ 2019-10-14 6:41 ` Geert Uytterhoeven
2019-10-14 6:49 ` Ard Biesheuvel
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-10-14 6:41 UTC (permalink / raw)
To: Narendra K
Cc: linux-efi, Ard Biesheuvel, Mario Limonciello, Ingo Molnar,
Thomas Gleixner, James Morse, Linux Kernel Mailing List
Hi Narendra,
On Sun, Oct 13, 2019 at 8:57 PM <Narendra.K@dell.com> wrote:
> From: Narendra K <Narendra.K@dell.com>
>
> For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> for input on platforms where the option may not be applicable. This patch
> modifies the kconfig option to ask the user for input only when CONFIG_X86
> or CONFIG_COMPILE_TEST is set to y.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Suggested-by: ...?
> Signed-off-by: Narendra K <Narendra.K@dell.com>
Thanks for your patch!
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
2019-10-14 6:41 ` Geert Uytterhoeven
@ 2019-10-14 6:49 ` Ard Biesheuvel
2019-10-14 9:51 ` Narendra.K
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2019-10-14 6:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Narendra K, linux-efi, Mario Limonciello, Ingo Molnar,
Thomas Gleixner, James Morse, Linux Kernel Mailing List
On Mon, 14 Oct 2019 at 08:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Narendra,
>
> On Sun, Oct 13, 2019 at 8:57 PM <Narendra.K@dell.com> wrote:
> > From: Narendra K <Narendra.K@dell.com>
> >
> > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> > for input on platforms where the option may not be applicable. This patch
> > modifies the kconfig option to ask the user for input only when CONFIG_X86
> > or CONFIG_COMPILE_TEST is set to y.
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Suggested-by: ...?
>
Indeed
> > Signed-off-by: Narendra K <Narendra.K@dell.com>
>
> Thanks for your patch!
>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
Thanks all. I'll get this queued as a fix.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
2019-10-14 6:49 ` Ard Biesheuvel
@ 2019-10-14 9:51 ` Narendra.K
0 siblings, 0 replies; 5+ messages in thread
From: Narendra.K @ 2019-10-14 9:51 UTC (permalink / raw)
To: ard.biesheuvel
Cc: geert, linux-efi, Mario.Limonciello, mingo, tglx, james.morse,
linux-kernel
On Mon, Oct 14, 2019 at 08:49:51AM +0200, Ard Biesheuvel wrote:
>
> [EXTERNAL EMAIL]
>
> On Mon, 14 Oct 2019 at 08:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Narendra,
> >
> > On Sun, Oct 13, 2019 at 8:57 PM <Narendra.K@dell.com> wrote:
> > > From: Narendra K <Narendra.K@dell.com>
> > >
> > > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> > > for input on platforms where the option may not be applicable. This patch
> > > modifies the kconfig option to ask the user for input only when CONFIG_X86
> > > or CONFIG_COMPILE_TEST is set to y.
> > >
> > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Suggested-by: ...?
> >
>
> Indeed
Hi Ard/Geert,
Thank you for correcting this. Should the patch be resubmitted with
the above change made ?
>
> > > Signed-off-by: Narendra K <Narendra.K@dell.com>
> >
> > Thanks for your patch!
> >
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
>
> Thanks all. I'll get this queued as a fix.
Thank you for review comments.
--
With regards,
Narendra K
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-14 9:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 18:57 [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Narendra.K
2019-10-13 19:15 ` Narendra.K
2019-10-14 6:41 ` Geert Uytterhoeven
2019-10-14 6:49 ` Ard Biesheuvel
2019-10-14 9:51 ` Narendra.K
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).