linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: arm64/poly1305: ignore build files
@ 2020-02-03 23:39 Matteo Croce
  2020-02-13  9:23 ` Herbert Xu
  0 siblings, 1 reply; 5+ messages in thread
From: Matteo Croce @ 2020-02-03 23:39 UTC (permalink / raw)
  To: linux-crypto, linux-arm-kernel
  Cc: Ard Biesheuvel, linux-kernel, Herbert Xu, Catalin Marinas

Add arch/arm64/crypto/poly1305-core.S to .gitignore
as it's built from poly1305-core.S_shipped

Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 arch/arm64/crypto/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
index 879df8781ed5..e403b1343328 100644
--- a/arch/arm64/crypto/.gitignore
+++ b/arch/arm64/crypto/.gitignore
@@ -1,2 +1,3 @@
 sha256-core.S
 sha512-core.S
+poly1305-core.S
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] crypto: arm64/poly1305: ignore build files
  2020-02-03 23:39 [PATCH] crypto: arm64/poly1305: ignore build files Matteo Croce
@ 2020-02-13  9:23 ` Herbert Xu
  2020-02-13 10:34   ` Jason A. Donenfeld
  0 siblings, 1 reply; 5+ messages in thread
From: Herbert Xu @ 2020-02-13  9:23 UTC (permalink / raw)
  To: Matteo Croce
  Cc: linux-crypto, linux-arm-kernel, Ard Biesheuvel, linux-kernel,
	Catalin Marinas

On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> Add arch/arm64/crypto/poly1305-core.S to .gitignore
> as it's built from poly1305-core.S_shipped
> 
> Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
>  arch/arm64/crypto/.gitignore | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] crypto: arm64/poly1305: ignore build files
  2020-02-13  9:23 ` Herbert Xu
@ 2020-02-13 10:34   ` Jason A. Donenfeld
  2020-02-13 10:38     ` Herbert Xu
  0 siblings, 1 reply; 5+ messages in thread
From: Jason A. Donenfeld @ 2020-02-13 10:34 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Matteo Croce, linux-crypto, linux-arm-kernel, Ard Biesheuvel,
	linux-kernel, Catalin Marinas

On Thu, Feb 13, 2020 at 05:23:55PM +0800, Herbert Xu wrote:
> On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> > Add arch/arm64/crypto/poly1305-core.S to .gitignore
> > as it's built from poly1305-core.S_shipped
> > 
> > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > ---
> >  arch/arm64/crypto/.gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Patch applied.  Thanks.

Probably makes sense for 5.6, no?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] crypto: arm64/poly1305: ignore build files
  2020-02-13 10:34   ` Jason A. Donenfeld
@ 2020-02-13 10:38     ` Herbert Xu
  2020-02-13 10:44       ` Ard Biesheuvel
  0 siblings, 1 reply; 5+ messages in thread
From: Herbert Xu @ 2020-02-13 10:38 UTC (permalink / raw)
  To: Jason A. Donenfeld
  Cc: Matteo Croce, linux-crypto, linux-arm-kernel, Ard Biesheuvel,
	linux-kernel, Catalin Marinas

On Thu, Feb 13, 2020 at 11:34:44AM +0100, Jason A. Donenfeld wrote:
> On Thu, Feb 13, 2020 at 05:23:55PM +0800, Herbert Xu wrote:
> > On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> > > Add arch/arm64/crypto/poly1305-core.S to .gitignore
> > > as it's built from poly1305-core.S_shipped
> > > 
> > > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > > ---
> > >  arch/arm64/crypto/.gitignore | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Patch applied.  Thanks.
> 
> Probably makes sense for 5.6, no?

No this is too minor.  Only critical bug fixes (e.g., user
triggerable crashes) or build issues are routinely accepted.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] crypto: arm64/poly1305: ignore build files
  2020-02-13 10:38     ` Herbert Xu
@ 2020-02-13 10:44       ` Ard Biesheuvel
  0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2020-02-13 10:44 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Jason A. Donenfeld, Matteo Croce,
	open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
	linux-arm-kernel, Linux Kernel Mailing List, Catalin Marinas

On Thu, 13 Feb 2020 at 11:39, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Feb 13, 2020 at 11:34:44AM +0100, Jason A. Donenfeld wrote:
> > On Thu, Feb 13, 2020 at 05:23:55PM +0800, Herbert Xu wrote:
> > > On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> > > > Add arch/arm64/crypto/poly1305-core.S to .gitignore
> > > > as it's built from poly1305-core.S_shipped
> > > >
> > > > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > > > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > > > ---
> > > >  arch/arm64/crypto/.gitignore | 1 +
> > > >  1 file changed, 1 insertion(+)
> > >
> > > Patch applied.  Thanks.
> >
> > Probably makes sense for 5.6, no?
>
> No this is too minor.  Only critical bug fixes (e.g., user
> triggerable crashes) or build issues are routinely accepted.
>

Sasha Levin's 'AI' bot finds everything with a 'fixes' tag and
proposes to backport it if it applies cleanly and doesn't break the
build, so this patch is going to end up in v5.6 anyway.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-02-13 10:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 23:39 [PATCH] crypto: arm64/poly1305: ignore build files Matteo Croce
2020-02-13  9:23 ` Herbert Xu
2020-02-13 10:34   ` Jason A. Donenfeld
2020-02-13 10:38     ` Herbert Xu
2020-02-13 10:44       ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).