* [PATCH 0/3] constify firmware attribute_group structures.
@ 2017-08-03 13:37 Arvind Yadav
2017-08-03 13:37 ` [PATCH 1/3] firmware: dcdbas: constify " Arvind Yadav
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-08-03 13:37 UTC (permalink / raw)
To: Douglas_Warzecha, matt, ard.biesheuvel, mingo; +Cc: linux-kernel, linux-efi
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Arvind Yadav (3):
[PATCH 1/3] firmware: dcdbas: constify attribute_group structures.
[PATCH 2/3] firmware: efi: constify attribute_group structures.
[PATCH 3/3] firmware: efi: esrt: constify attribute_group structures.
drivers/firmware/dcdbas.c | 2 +-
drivers/firmware/efi/efi.c | 2 +-
drivers/firmware/efi/esrt.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] firmware: dcdbas: constify attribute_group structures.
2017-08-03 13:37 [PATCH 0/3] constify firmware attribute_group structures Arvind Yadav
@ 2017-08-03 13:37 ` Arvind Yadav
2017-08-18 14:36 ` Ard Biesheuvel
2017-08-03 13:37 ` [PATCH 2/3] firmware: efi: " Arvind Yadav
2017-08-03 13:37 ` [PATCH 3/3] firmware: efi: esrt: " Arvind Yadav
2 siblings, 1 reply; 5+ messages in thread
From: Arvind Yadav @ 2017-08-03 13:37 UTC (permalink / raw)
To: Douglas_Warzecha, matt, ard.biesheuvel, mingo; +Cc: linux-kernel, linux-efi
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/firmware/dcdbas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index 2fe1a13..c16600f 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -534,7 +534,7 @@ static int dcdbas_reboot_notify(struct notifier_block *nb, unsigned long code,
NULL
};
-static struct attribute_group dcdbas_attr_group = {
+static const struct attribute_group dcdbas_attr_group = {
.attrs = dcdbas_dev_attrs,
.bin_attrs = dcdbas_bin_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] firmware: efi: constify attribute_group structures.
2017-08-03 13:37 [PATCH 0/3] constify firmware attribute_group structures Arvind Yadav
2017-08-03 13:37 ` [PATCH 1/3] firmware: dcdbas: constify " Arvind Yadav
@ 2017-08-03 13:37 ` Arvind Yadav
2017-08-03 13:37 ` [PATCH 3/3] firmware: efi: esrt: " Arvind Yadav
2 siblings, 0 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-08-03 13:37 UTC (permalink / raw)
To: Douglas_Warzecha, matt, ard.biesheuvel, mingo; +Cc: linux-kernel, linux-efi
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/firmware/efi/efi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 045d6d3..6519be44 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -179,7 +179,7 @@ static umode_t efi_attr_is_visible(struct kobject *kobj,
return attr->mode;
}
-static struct attribute_group efi_subsys_attr_group = {
+static const struct attribute_group efi_subsys_attr_group = {
.attrs = efi_subsys_attrs,
.is_visible = efi_attr_is_visible,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] firmware: efi: esrt: constify attribute_group structures.
2017-08-03 13:37 [PATCH 0/3] constify firmware attribute_group structures Arvind Yadav
2017-08-03 13:37 ` [PATCH 1/3] firmware: dcdbas: constify " Arvind Yadav
2017-08-03 13:37 ` [PATCH 2/3] firmware: efi: " Arvind Yadav
@ 2017-08-03 13:37 ` Arvind Yadav
2 siblings, 0 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-08-03 13:37 UTC (permalink / raw)
To: Douglas_Warzecha, matt, ard.biesheuvel, mingo; +Cc: linux-kernel, linux-efi
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/firmware/efi/esrt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index 8554d7a..bd7ed3c 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -230,7 +230,7 @@ static umode_t esrt_attr_is_visible(struct kobject *kobj,
return attr->mode;
}
-static struct attribute_group esrt_attr_group = {
+static const struct attribute_group esrt_attr_group = {
.attrs = esrt_attrs,
.is_visible = esrt_attr_is_visible,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] firmware: dcdbas: constify attribute_group structures.
2017-08-03 13:37 ` [PATCH 1/3] firmware: dcdbas: constify " Arvind Yadav
@ 2017-08-18 14:36 ` Ard Biesheuvel
0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2017-08-18 14:36 UTC (permalink / raw)
To: Arvind Yadav
Cc: Douglas_Warzecha, Matt Fleming, Ingo Molnar, linux-kernel, linux-efi
On 3 August 2017 at 14:37, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/firmware/dcdbas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
> index 2fe1a13..c16600f 100644
> --- a/drivers/firmware/dcdbas.c
> +++ b/drivers/firmware/dcdbas.c
> @@ -534,7 +534,7 @@ static int dcdbas_reboot_notify(struct notifier_block *nb, unsigned long code,
> NULL
> };
>
> -static struct attribute_group dcdbas_attr_group = {
> +static const struct attribute_group dcdbas_attr_group = {
> .attrs = dcdbas_dev_attrs,
> .bin_attrs = dcdbas_bin_attrs,
> };
If Douglas doesn't mind, I will take this trough the EFI tree
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-18 14:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-03 13:37 [PATCH 0/3] constify firmware attribute_group structures Arvind Yadav
2017-08-03 13:37 ` [PATCH 1/3] firmware: dcdbas: constify " Arvind Yadav
2017-08-18 14:36 ` Ard Biesheuvel
2017-08-03 13:37 ` [PATCH 2/3] firmware: efi: " Arvind Yadav
2017-08-03 13:37 ` [PATCH 3/3] firmware: efi: esrt: " Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).