* [PATCH] efi: Remove the declaration of efi_late_init() as the function is unused
@ 2018-06-25 1:47 Sai Praneeth Prakhya
2018-06-25 6:02 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Sai Praneeth Prakhya @ 2018-06-25 1:47 UTC (permalink / raw)
To: linux-efi, linux-kernel
Cc: Sai Praneeth, Lee Chun-Yi, Borislav Petkov, Dave Young,
Bhupesh Sharma, Ricardo Neri, Ravi Shankar, Matt Fleming,
Ard Biesheuvel
From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
Commit 7b0a911478c74 (efi/x86: Move the EFI BGRT init code to early
init code), removed the implementation and all the references to
efi_late_init() but the function is still declared at
include/linux/efi.h. Hence, remove the unnecessary declaration.
Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Cc: Lee Chun-Yi <jlee@suse.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Young <dyoung@redhat.com>
Cc: Bhupesh Sharma <bhsharma@redhat.com>
Cc: Ricardo Neri <ricardo.neri@intel.com>
Cc: Ravi Shankar <ravi.v.shankar@intel.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
include/linux/efi.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 56add823f190..ae47be636b98 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -988,14 +988,12 @@ extern void efi_memmap_walk (efi_freemem_callback_t callback, void *arg);
extern void efi_gettimeofday (struct timespec64 *ts);
extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
#ifdef CONFIG_X86
-extern void efi_late_init(void);
extern void efi_free_boot_services(void);
extern efi_status_t efi_query_variable_store(u32 attributes,
unsigned long size,
bool nonblocking);
extern void efi_find_mirror(void);
#else
-static inline void efi_late_init(void) {}
static inline void efi_free_boot_services(void) {}
static inline efi_status_t efi_query_variable_store(u32 attributes,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] efi: Remove the declaration of efi_late_init() as the function is unused
2018-06-25 1:47 [PATCH] efi: Remove the declaration of efi_late_init() as the function is unused Sai Praneeth Prakhya
@ 2018-06-25 6:02 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2018-06-25 6:02 UTC (permalink / raw)
To: Sai Praneeth Prakhya
Cc: linux-efi, Linux Kernel Mailing List, Lee Chun-Yi,
Borislav Petkov, Dave Young, Bhupesh Sharma, Ricardo Neri,
Ravi Shankar, Matt Fleming
On 25 June 2018 at 03:47, Sai Praneeth Prakhya
<sai.praneeth.prakhya@intel.com> wrote:
> From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
>
> Commit 7b0a911478c74 (efi/x86: Move the EFI BGRT init code to early
> init code), removed the implementation and all the references to
> efi_late_init() but the function is still declared at
> include/linux/efi.h. Hence, remove the unnecessary declaration.
>
> Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
> Cc: Lee Chun-Yi <jlee@suse.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: Bhupesh Sharma <bhsharma@redhat.com>
> Cc: Ricardo Neri <ricardo.neri@intel.com>
> Cc: Ravi Shankar <ravi.v.shankar@intel.com>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks Sai
Queued in efi/next
> ---
> include/linux/efi.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 56add823f190..ae47be636b98 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -988,14 +988,12 @@ extern void efi_memmap_walk (efi_freemem_callback_t callback, void *arg);
> extern void efi_gettimeofday (struct timespec64 *ts);
> extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
> #ifdef CONFIG_X86
> -extern void efi_late_init(void);
> extern void efi_free_boot_services(void);
> extern efi_status_t efi_query_variable_store(u32 attributes,
> unsigned long size,
> bool nonblocking);
> extern void efi_find_mirror(void);
> #else
> -static inline void efi_late_init(void) {}
> static inline void efi_free_boot_services(void) {}
>
> static inline efi_status_t efi_query_variable_store(u32 attributes,
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-25 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-25 1:47 [PATCH] efi: Remove the declaration of efi_late_init() as the function is unused Sai Praneeth Prakhya
2018-06-25 6:02 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).