* [PATCH] kernel/hung_task.c: printk address for hung_task
@ 2016-01-13 2:42 Li
2016-01-14 2:45 ` Pan Xinhui
0 siblings, 1 reply; 4+ messages in thread
From: Li @ 2016-01-13 2:42 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, Kassey Li
From: Kassey Li <kassey1216@gmail.com>
this is used to check task_struct info when got a dump.
Signed-off-by: Kassey Li <kassey1216@gmail.com>
---
kernel/hung_task.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index d234022..b5dd7dd 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -108,8 +108,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
* Ok, the task did not get scheduled for more than 2 minutes,
* complain:
*/
- pr_err("INFO: task %s:%d blocked for more than %ld seconds.\n",
- t->comm, t->pid, timeout);
+ pr_err("INFO: task %s:%d 0x%p blocked for more than %ld seconds.\n",
+ t->comm, t->pid, t, timeout);
pr_err(" %s %s %.*s\n",
print_tainted(), init_utsname()->release,
(int)strcspn(init_utsname()->version, " "),
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel/hung_task.c: printk address for hung_task
2016-01-13 2:42 [PATCH] kernel/hung_task.c: printk address for hung_task Li
@ 2016-01-14 2:45 ` Pan Xinhui
2016-01-14 9:33 ` Kassey
0 siblings, 1 reply; 4+ messages in thread
From: Pan Xinhui @ 2016-01-14 2:45 UTC (permalink / raw)
To: Li, mingo; +Cc: linux-kernel
hi, Li
I have a little confusion. for what you want to know this ptr's value. Can that help you debug or root the cause?
I'm just wondering :)
thanks
xinhui
On 2016年01月13日 10:42, Li wrote:
> From: Kassey Li <kassey1216@gmail.com>
>
> this is used to check task_struct info when got a dump.
>
> Signed-off-by: Kassey Li <kassey1216@gmail.com>
> ---
> kernel/hung_task.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
> index d234022..b5dd7dd 100644
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -108,8 +108,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
> * Ok, the task did not get scheduled for more than 2 minutes,
> * complain:
> */
> - pr_err("INFO: task %s:%d blocked for more than %ld seconds.\n",
> - t->comm, t->pid, timeout);
> + pr_err("INFO: task %s:%d 0x%p blocked for more than %ld seconds.\n",
> + t->comm, t->pid, t, timeout);
> pr_err(" %s %s %.*s\n",
> print_tainted(), init_utsname()->release,
> (int)strcspn(init_utsname()->version, " "),
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel/hung_task.c: printk address for hung_task
2016-01-14 2:45 ` Pan Xinhui
@ 2016-01-14 9:33 ` Kassey
2016-02-17 7:17 ` Kassey
0 siblings, 1 reply; 4+ messages in thread
From: Kassey @ 2016-01-14 9:33 UTC (permalink / raw)
To: Pan Xinhui; +Cc: mingo, linux-kernel
Xinhui:
when I got a DDR dump, with the task_struct address for this
task, I can see what file this task is accessing, as well as
task_struct member.
this is very useful and popular on arch where we can generate a
DDR dump when system crash.
BR
Kassey
On Thu, Jan 14, 2016 at 10:45 AM, Pan Xinhui <xinhui@linux.vnet.ibm.com> wrote:
> hi, Li
> I have a little confusion. for what you want to know this ptr's value. Can that help you debug or root the cause?
> I'm just wondering :)
>
> thanks
> xinhui
>
> On 2016年01月13日 10:42, Li wrote:
>> From: Kassey Li <kassey1216@gmail.com>
>>
>> this is used to check task_struct info when got a dump.
>>
>> Signed-off-by: Kassey Li <kassey1216@gmail.com>
>> ---
>> kernel/hung_task.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
>> index d234022..b5dd7dd 100644
>> --- a/kernel/hung_task.c
>> +++ b/kernel/hung_task.c
>> @@ -108,8 +108,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
>> * Ok, the task did not get scheduled for more than 2 minutes,
>> * complain:
>> */
>> - pr_err("INFO: task %s:%d blocked for more than %ld seconds.\n",
>> - t->comm, t->pid, timeout);
>> + pr_err("INFO: task %s:%d 0x%p blocked for more than %ld seconds.\n",
>> + t->comm, t->pid, t, timeout);
>> pr_err(" %s %s %.*s\n",
>> print_tainted(), init_utsname()->release,
>> (int)strcspn(init_utsname()->version, " "),
>>
>
--
Best regards
Kassey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel/hung_task.c: printk address for hung_task
2016-01-14 9:33 ` Kassey
@ 2016-02-17 7:17 ` Kassey
0 siblings, 0 replies; 4+ messages in thread
From: Kassey @ 2016-02-17 7:17 UTC (permalink / raw)
To: Pan Xinhui, oleg, msb, mingo; +Cc: mingo, linux-kernel
Ingo, Mandeep:
can you review this patch ?
BR
Kassey
On Thu, Jan 14, 2016 at 5:33 PM, Kassey <kassey1216@gmail.com> wrote:
> Xinhui:
> when I got a DDR dump, with the task_struct address for this
> task, I can see what file this task is accessing, as well as
> task_struct member.
> this is very useful and popular on arch where we can generate a
> DDR dump when system crash.
>
> BR
> Kassey
>
> On Thu, Jan 14, 2016 at 10:45 AM, Pan Xinhui <xinhui@linux.vnet.ibm.com> wrote:
>> hi, Li
>> I have a little confusion. for what you want to know this ptr's value. Can that help you debug or root the cause?
>> I'm just wondering :)
>>
>> thanks
>> xinhui
>>
>> On 2016年01月13日 10:42, Li wrote:
>>> From: Kassey Li <kassey1216@gmail.com>
>>>
>>> this is used to check task_struct info when got a dump.
>>>
>>> Signed-off-by: Kassey Li <kassey1216@gmail.com>
>>> ---
>>> kernel/hung_task.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
>>> index d234022..b5dd7dd 100644
>>> --- a/kernel/hung_task.c
>>> +++ b/kernel/hung_task.c
>>> @@ -108,8 +108,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
>>> * Ok, the task did not get scheduled for more than 2 minutes,
>>> * complain:
>>> */
>>> - pr_err("INFO: task %s:%d blocked for more than %ld seconds.\n",
>>> - t->comm, t->pid, timeout);
>>> + pr_err("INFO: task %s:%d 0x%p blocked for more than %ld seconds.\n",
>>> + t->comm, t->pid, t, timeout);
>>> pr_err(" %s %s %.*s\n",
>>> print_tainted(), init_utsname()->release,
>>> (int)strcspn(init_utsname()->version, " "),
>>>
>>
>
>
>
> --
> Best regards
> Kassey
--
Best regards
Kassey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-17 7:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-13 2:42 [PATCH] kernel/hung_task.c: printk address for hung_task Li
2016-01-14 2:45 ` Pan Xinhui
2016-01-14 9:33 ` Kassey
2016-02-17 7:17 ` Kassey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).