* [PATCH] Input: atmel_mxt_ts - fix -Wunused-const-variable
@ 2019-06-12 23:58 Nathan Huckleberry
2019-06-13 17:47 ` Nick Desaulniers
0 siblings, 1 reply; 5+ messages in thread
From: Nathan Huckleberry @ 2019-06-12 23:58 UTC (permalink / raw)
To: nick, dmitry.torokhov
Cc: linux-input, linux-kernel, Nathan Huckleberry, clang-built-linux
Clang produces the following warning
drivers/input/touchscreen/atmel_mxt_ts.c:259:42: warning: unused
variable 'mxt_video_fops' [-Wunused-const-variable]
static const struct v4l2_file_operations mxt_video_fops = {
Since mxt_video_fops is only used inside an ifdef. It should
be moved inside the ifdef.
Cc: clang-built-linux@googlegroups.com
Link: https://github.com/ClangBuiltLinux/linux/issues/527
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/input/touchscreen/atmel_mxt_ts.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 19378f200c63..48411c83320b 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -256,6 +256,7 @@ enum v4l_dbg_inputs {
MXT_V4L_INPUT_MAX,
};
+#ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37
static const struct v4l2_file_operations mxt_video_fops = {
.owner = THIS_MODULE,
.open = v4l2_fh_open,
@@ -265,6 +266,7 @@ static const struct v4l2_file_operations mxt_video_fops = {
.mmap = vb2_fop_mmap,
.poll = vb2_fop_poll,
};
+#endif
enum mxt_suspend_mode {
MXT_SUSPEND_DEEP_SLEEP = 0,
--
2.22.0.rc2.383.gf4fbbf30c2-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Input: atmel_mxt_ts - fix -Wunused-const-variable
2019-06-12 23:58 [PATCH] Input: atmel_mxt_ts - fix -Wunused-const-variable Nathan Huckleberry
@ 2019-06-13 17:47 ` Nick Desaulniers
2019-06-13 18:23 ` [PATCH v2] " Nathan Huckleberry
0 siblings, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2019-06-13 17:47 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: nick, dmitry.torokhov, linux-input, LKML, clang-built-linux
On Wed, Jun 12, 2019 at 4:58 PM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
> Since mxt_video_fops is only used inside an ifdef. It should
> be moved inside the ifdef.
Thanks for the patch! I agree. I think it would be better and clearer
to sink the definition of `mxt_video_fops` down closer to its use,
immediately before the definition of `mxt_video_device`. Then it
would be closer to its use and it would also be within the existing
ifdef.
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -256,6 +256,7 @@ enum v4l_dbg_inputs {
> MXT_V4L_INPUT_MAX,
> };
>
> +#ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37
> static const struct v4l2_file_operations mxt_video_fops = {
> .owner = THIS_MODULE,
> .open = v4l2_fh_open,
> @@ -265,6 +266,7 @@ static const struct v4l2_file_operations mxt_video_fops = {
> .mmap = vb2_fop_mmap,
> .poll = vb2_fop_poll,
> };
> +#endif
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] Input: atmel_mxt_ts - fix -Wunused-const-variable
2019-06-13 17:47 ` Nick Desaulniers
@ 2019-06-13 18:23 ` Nathan Huckleberry
2019-06-13 18:26 ` Nick Desaulniers
0 siblings, 1 reply; 5+ messages in thread
From: Nathan Huckleberry @ 2019-06-13 18:23 UTC (permalink / raw)
To: nick, dmitry.torokhov
Cc: linux-input, linux-kernel, Nathan Huckleberry, clang-built-linux
Clang produces the following warning
drivers/input/touchscreen/atmel_mxt_ts.c:259:42: warning: unused
variable 'mxt_video_fops' [-Wunused-const-variable]
static const struct v4l2_file_operations mxt_video_fops = {
Since mxt_video_fops is only used inside an ifdef. It should
be moved inside the ifdef.
Cc: clang-built-linux@googlegroups.com
Link: https://github.com/ClangBuiltLinux/linux/issues/527
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
Changes from v1 -> v2
* Moved definition of mxt_video_fops into existing ifdef
drivers/input/touchscreen/atmel_mxt_ts.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 19378f200c63..0dae381c6637 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -256,16 +256,6 @@ enum v4l_dbg_inputs {
MXT_V4L_INPUT_MAX,
};
-static const struct v4l2_file_operations mxt_video_fops = {
- .owner = THIS_MODULE,
- .open = v4l2_fh_open,
- .release = vb2_fop_release,
- .unlocked_ioctl = video_ioctl2,
- .read = vb2_fop_read,
- .mmap = vb2_fop_mmap,
- .poll = vb2_fop_poll,
-};
-
enum mxt_suspend_mode {
MXT_SUSPEND_DEEP_SLEEP = 0,
MXT_SUSPEND_T9_CTRL = 1,
@@ -2218,6 +2208,16 @@ static int mxt_init_t7_power_cfg(struct mxt_data *data)
}
#ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37
+static const struct v4l2_file_operations mxt_video_fops = {
+ .owner = THIS_MODULE,
+ .open = v4l2_fh_open,
+ .release = vb2_fop_release,
+ .unlocked_ioctl = video_ioctl2,
+ .read = vb2_fop_read,
+ .mmap = vb2_fop_mmap,
+ .poll = vb2_fop_poll,
+};
+
static u16 mxt_get_debug_value(struct mxt_data *data, unsigned int x,
unsigned int y)
{
--
2.22.0.rc2.383.gf4fbbf30c2-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Input: atmel_mxt_ts - fix -Wunused-const-variable
2019-06-13 18:23 ` [PATCH v2] " Nathan Huckleberry
@ 2019-06-13 18:26 ` Nick Desaulniers
2019-07-01 8:19 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2019-06-13 18:26 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: nick, dmitry.torokhov, linux-input, LKML, clang-built-linux
On Thu, Jun 13, 2019 at 11:24 AM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
> Changes from v1 -> v2
> * Moved definition of mxt_video_fops into existing ifdef
Thanks for the v2.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -256,16 +256,6 @@ enum v4l_dbg_inputs {
> MXT_V4L_INPUT_MAX,
> };
>
> -static const struct v4l2_file_operations mxt_video_fops = {
> - .owner = THIS_MODULE,
> - .open = v4l2_fh_open,
> - .release = vb2_fop_release,
> - .unlocked_ioctl = video_ioctl2,
> - .read = vb2_fop_read,
> - .mmap = vb2_fop_mmap,
> - .poll = vb2_fop_poll,
> -};
> -
> enum mxt_suspend_mode {
> MXT_SUSPEND_DEEP_SLEEP = 0,
> MXT_SUSPEND_T9_CTRL = 1,
> @@ -2218,6 +2208,16 @@ static int mxt_init_t7_power_cfg(struct mxt_data *data)
> }
>
> #ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37
> +static const struct v4l2_file_operations mxt_video_fops = {
> + .owner = THIS_MODULE,
> + .open = v4l2_fh_open,
> + .release = vb2_fop_release,
> + .unlocked_ioctl = video_ioctl2,
> + .read = vb2_fop_read,
> + .mmap = vb2_fop_mmap,
> + .poll = vb2_fop_poll,
> +};
> +
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Input: atmel_mxt_ts - fix -Wunused-const-variable
2019-06-13 18:26 ` Nick Desaulniers
@ 2019-07-01 8:19 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2019-07-01 8:19 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Nathan Huckleberry, nick, linux-input, LKML, clang-built-linux
On Thu, Jun 13, 2019 at 11:26:41AM -0700, Nick Desaulniers wrote:
> On Thu, Jun 13, 2019 at 11:24 AM 'Nathan Huckleberry' via Clang Built
> Linux <clang-built-linux@googlegroups.com> wrote:
> > Changes from v1 -> v2
> > * Moved definition of mxt_video_fops into existing ifdef
>
> Thanks for the v2.
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Applied, thank you.
>
> > --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> > @@ -256,16 +256,6 @@ enum v4l_dbg_inputs {
> > MXT_V4L_INPUT_MAX,
> > };
> >
> > -static const struct v4l2_file_operations mxt_video_fops = {
> > - .owner = THIS_MODULE,
> > - .open = v4l2_fh_open,
> > - .release = vb2_fop_release,
> > - .unlocked_ioctl = video_ioctl2,
> > - .read = vb2_fop_read,
> > - .mmap = vb2_fop_mmap,
> > - .poll = vb2_fop_poll,
> > -};
> > -
> > enum mxt_suspend_mode {
> > MXT_SUSPEND_DEEP_SLEEP = 0,
> > MXT_SUSPEND_T9_CTRL = 1,
> > @@ -2218,6 +2208,16 @@ static int mxt_init_t7_power_cfg(struct mxt_data *data)
> > }
> >
> > #ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37
> > +static const struct v4l2_file_operations mxt_video_fops = {
> > + .owner = THIS_MODULE,
> > + .open = v4l2_fh_open,
> > + .release = vb2_fop_release,
> > + .unlocked_ioctl = video_ioctl2,
> > + .read = vb2_fop_read,
> > + .mmap = vb2_fop_mmap,
> > + .poll = vb2_fop_poll,
> > +};
> > +
>
> --
> Thanks,
> ~Nick Desaulniers
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-01 8:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 23:58 [PATCH] Input: atmel_mxt_ts - fix -Wunused-const-variable Nathan Huckleberry
2019-06-13 17:47 ` Nick Desaulniers
2019-06-13 18:23 ` [PATCH v2] " Nathan Huckleberry
2019-06-13 18:26 ` Nick Desaulniers
2019-07-01 8:19 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).