* [PATCH] kbuild: fix 'Broken pipe' message for AR=gcc-ar
@ 2022-10-23 19:52 Masahiro Yamada
2022-10-24 19:15 ` Nick Desaulniers
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2022-10-23 19:52 UTC (permalink / raw)
To: linux-kbuild
Cc: Masahiro Yamada, Jiri Slaby, Michal Marek, Nick Desaulniers,
Nicolas Schier, linux-kernel
Since commit 321648455061 ("kbuild: use obj-y instead extra-y for
objects placed at the head"), 'make AR=gcc-ar' shows the following
message:
/usr/bin/ar terminated with signal 13 [Broken pipe]
The resulting vmlinux is correct, but it is better to silence this.
'head -n1' exits after reading the first line, so the pipe is closed.
Use 'sed -n 1p' to eat the stream till the end.
Fixes: 321648455061 ("kbuild: use obj-y instead extra-y for objects placed at the head")
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index f41ec8c8426b..0e42a7982826 100644
--- a/Makefile
+++ b/Makefile
@@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR $@
cmd_ar_vmlinux.a = \
rm -f $@; \
$(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \
- $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
+ $(AR) mPiT $$($(AR) t $@ | sed -n 1p) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
targets += vmlinux.a
vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: fix 'Broken pipe' message for AR=gcc-ar
2022-10-23 19:52 [PATCH] kbuild: fix 'Broken pipe' message for AR=gcc-ar Masahiro Yamada
@ 2022-10-24 19:15 ` Nick Desaulniers
2022-10-27 16:31 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2022-10-24 19:15 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, Jiri Slaby, Michal Marek, Nicolas Schier,
linux-kernel, Nathan Chancellor, clang-built-linux, eng.stk
On Sun, Oct 23, 2022 at 12:53 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Since commit 321648455061 ("kbuild: use obj-y instead extra-y for
> objects placed at the head"), 'make AR=gcc-ar' shows the following
> message:
>
> /usr/bin/ar terminated with signal 13 [Broken pipe]
Not just AR=gcc-ar, but also AR=llvm-ar:
error: write on a pipe with no reader
Link: https://github.com/ClangBuiltLinux/linux/issues/1651
Reported-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Note that due to
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8017ce50641c303b9b5d96f3c10229ecfd770a70
we should send a backport to stable like:
https://github.com/engstk/op8/commit/6f2688e3eb4ec06b276e541640d4f06364b68442
>
> The resulting vmlinux is correct, but it is better to silence this.
>
> 'head -n1' exits after reading the first line, so the pipe is closed.
>
> Use 'sed -n 1p' to eat the stream till the end.
>
> Fixes: 321648455061 ("kbuild: use obj-y instead extra-y for objects placed at the head")
> Reported-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f41ec8c8426b..0e42a7982826 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1218,7 +1218,7 @@ quiet_cmd_ar_vmlinux.a = AR $@
> cmd_ar_vmlinux.a = \
> rm -f $@; \
> $(AR) cDPrST $@ $(KBUILD_VMLINUX_OBJS); \
> - $(AR) mPiT $$($(AR) t $@ | head -n1) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
> + $(AR) mPiT $$($(AR) t $@ | sed -n 1p) $@ $$($(AR) t $@ | grep -F --file=$(srctree)/scripts/head-object-list.txt)
>
> targets += vmlinux.a
> vmlinux.a: $(KBUILD_VMLINUX_OBJS) scripts/head-object-list.txt autoksyms_recursive FORCE
> --
> 2.34.1
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: fix 'Broken pipe' message for AR=gcc-ar
2022-10-24 19:15 ` Nick Desaulniers
@ 2022-10-27 16:31 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2022-10-27 16:31 UTC (permalink / raw)
To: Nick Desaulniers
Cc: linux-kbuild, Jiri Slaby, Michal Marek, Nicolas Schier,
linux-kernel, Nathan Chancellor, clang-built-linux, eng.stk
On Tue, Oct 25, 2022 at 4:15 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Sun, Oct 23, 2022 at 12:53 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Since commit 321648455061 ("kbuild: use obj-y instead extra-y for
> > objects placed at the head"), 'make AR=gcc-ar' shows the following
> > message:
> >
> > /usr/bin/ar terminated with signal 13 [Broken pipe]
>
> Not just AR=gcc-ar, but also AR=llvm-ar:
>
> error: write on a pipe with no reader
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1651
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Thank you.
I updated the commit description, and sent v2.
https://lore.kernel.org/linux-kbuild/20221027162839.410720-1-masahiroy@kernel.org/T/#u
> Note that due to
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8017ce50641c303b9b5d96f3c10229ecfd770a70
> we should send a backport to stable like:
> https://github.com/engstk/op8/commit/6f2688e3eb4ec06b276e541640d4f06364b68442
Maybe, we can backport 8017ce50641c30 itself,
but I am not sure if it is cleanly applicable.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-27 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-23 19:52 [PATCH] kbuild: fix 'Broken pipe' message for AR=gcc-ar Masahiro Yamada
2022-10-24 19:15 ` Nick Desaulniers
2022-10-27 16:31 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).