* [PATCH] arm64: kvm: Delete duplicated label: in invalid_vector
@ 2020-04-13 23:10 Fangrui Song
2020-04-13 23:37 ` Nick Desaulniers
0 siblings, 1 reply; 3+ messages in thread
From: Fangrui Song @ 2020-04-13 23:10 UTC (permalink / raw)
To: linux-arm-kernel, kvmarm, linux-kernel
Cc: Catalin Marinas, Marc Zyngier, Will Deacon, Nick Desaulniers,
clang-built-linux, Fangrui Song
SYM_CODE_START defines \label , so it is redundant to define \label again.
A redefinition at the same place is accepted by GNU as
(https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=159fbb6088f17a341bcaaac960623cab881b4981)
but rejected by the clang integrated assembler.
Fixes: 617a2f392c92 ("arm64: kvm: Annotate assembly using modern annoations")
Link: https://github.com/ClangBuiltLinux/linux/issues/988
Signed-off-by: Fangrui Song <maskray@google.com>
---
arch/arm64/kvm/hyp/hyp-entry.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kvm/hyp/hyp-entry.S b/arch/arm64/kvm/hyp/hyp-entry.S
index c2a13ab3c471..9c5cfb04170e 100644
--- a/arch/arm64/kvm/hyp/hyp-entry.S
+++ b/arch/arm64/kvm/hyp/hyp-entry.S
@@ -198,7 +198,6 @@ SYM_CODE_END(__hyp_panic)
.macro invalid_vector label, target = __hyp_panic
.align 2
SYM_CODE_START(\label)
-\label:
b \target
SYM_CODE_END(\label)
.endm
--
2.26.0.110.g2183baf09c-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: kvm: Delete duplicated label: in invalid_vector
2020-04-13 23:10 [PATCH] arm64: kvm: Delete duplicated label: in invalid_vector Fangrui Song
@ 2020-04-13 23:37 ` Nick Desaulniers
2020-04-14 13:57 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2020-04-13 23:37 UTC (permalink / raw)
To: Fangrui Song
Cc: Linux ARM, kvmarm, LKML, Catalin Marinas, Marc Zyngier,
Will Deacon, clang-built-linux
On Mon, Apr 13, 2020 at 4:10 PM Fangrui Song <maskray@google.com> wrote:
>
> SYM_CODE_START defines \label , so it is redundant to define \label again.
> A redefinition at the same place is accepted by GNU as
> (https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=159fbb6088f17a341bcaaac960623cab881b4981)
> but rejected by the clang integrated assembler.
>
> Fixes: 617a2f392c92 ("arm64: kvm: Annotate assembly using modern annoations")
Thanks for the patch! I think a more accurate Fixes tag would be:
Fixes: 2b28162cf65a ("arm64: KVM: HYP mode entry points")
With this patch applied, and your other arm64 integrated assembler
patch (https://lore.kernel.org/linux-arm-kernel/20200413033811.75074-1-maskray@google.com/T/#u),
I can now assemble arch/arm64/kvm/.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/988
> Signed-off-by: Fangrui Song <maskray@google.com>
> ---
> arch/arm64/kvm/hyp/hyp-entry.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/hyp/hyp-entry.S b/arch/arm64/kvm/hyp/hyp-entry.S
> index c2a13ab3c471..9c5cfb04170e 100644
> --- a/arch/arm64/kvm/hyp/hyp-entry.S
> +++ b/arch/arm64/kvm/hyp/hyp-entry.S
> @@ -198,7 +198,6 @@ SYM_CODE_END(__hyp_panic)
> .macro invalid_vector label, target = __hyp_panic
> .align 2
> SYM_CODE_START(\label)
> -\label:
> b \target
> SYM_CODE_END(\label)
> .endm
> --
> 2.26.0.110.g2183baf09c-goog
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: kvm: Delete duplicated label: in invalid_vector
2020-04-13 23:37 ` Nick Desaulniers
@ 2020-04-14 13:57 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2020-04-14 13:57 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Fangrui Song, Linux ARM, kvmarm, LKML, Catalin Marinas,
Will Deacon, clang-built-linux
Hi Nick,
On Mon, 13 Apr 2020 16:37:10 -0700
Nick Desaulniers <ndesaulniers@google.com> wrote:
> On Mon, Apr 13, 2020 at 4:10 PM Fangrui Song <maskray@google.com> wrote:
> >
> > SYM_CODE_START defines \label , so it is redundant to define \label again.
> > A redefinition at the same place is accepted by GNU as
> > (https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=159fbb6088f17a341bcaaac960623cab881b4981)
> > but rejected by the clang integrated assembler.
> >
> > Fixes: 617a2f392c92 ("arm64: kvm: Annotate assembly using modern annoations")
>
> Thanks for the patch! I think a more accurate Fixes tag would be:
> Fixes: 2b28162cf65a ("arm64: KVM: HYP mode entry points")
I'm not sure this commit is accurate. At that time, there was no other
declaration for \label and dropping it would simply break compilation.
I believe that Fangrui is correct in his analysis that 617a2f392c92 is
the first broken commit.
> With this patch applied, and your other arm64 integrated assembler
> patch (https://lore.kernel.org/linux-arm-kernel/20200413033811.75074-1-maskray@google.com/T/#u),
> I can now assemble arch/arm64/kvm/.
Progress! ;-)
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
>
> > Link: https://github.com/ClangBuiltLinux/linux/issues/988
> > Signed-off-by: Fangrui Song <maskray@google.com>
> > ---
> > arch/arm64/kvm/hyp/hyp-entry.S | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/kvm/hyp/hyp-entry.S b/arch/arm64/kvm/hyp/hyp-entry.S
> > index c2a13ab3c471..9c5cfb04170e 100644
> > --- a/arch/arm64/kvm/hyp/hyp-entry.S
> > +++ b/arch/arm64/kvm/hyp/hyp-entry.S
> > @@ -198,7 +198,6 @@ SYM_CODE_END(__hyp_panic)
> > .macro invalid_vector label, target = __hyp_panic
> > .align 2
> > SYM_CODE_START(\label)
> > -\label:
> > b \target
> > SYM_CODE_END(\label)
> > .endm
> > --
> > 2.26.0.110.g2183baf09c-goog
> >
>
>
I'll pick this up as soon as we've sorted the queue with the rest of
the fixes.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-14 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 23:10 [PATCH] arm64: kvm: Delete duplicated label: in invalid_vector Fangrui Song
2020-04-13 23:37 ` Nick Desaulniers
2020-04-14 13:57 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).