* [PATCH] iwlwifi: mvm: initialize seq variable
@ 2022-04-01 23:06 Tom Rix
2022-04-05 17:57 ` Nick Desaulniers
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2022-04-01 23:06 UTC (permalink / raw)
To: luciano.coelho, kvalo, davem, kuba, pabeni, nathan, ndesaulniers,
johannes.berg, emmanuel.grumbach, dan.carpenter
Cc: linux-wireless, netdev, linux-kernel, llvm, Tom Rix
Clang static analysis reports this issue
d3.c:567:22: warning: The left operand of '>' is
a garbage value
if (seq.tkip.iv32 > cur_rx_iv32)
~~~~~~~~~~~~~ ^
seq is never initialized. Call ieee80211_get_key_rx_seq() to
initialize seq.
Fixes: 0419e5e672d6 ("iwlwifi: mvm: d3: separate TKIP data from key iteration")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
index a995bba0ba81..9b190b3ce6c1 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
@@ -563,6 +563,7 @@ static void iwl_mvm_wowlan_get_tkip_data(struct ieee80211_hw *hw,
}
for (i = 0; i < IWL_NUM_RSC; i++) {
+ ieee80211_get_key_rx_seq(key, i, &seq);
/* wrapping isn't allowed, AP must rekey */
if (seq.tkip.iv32 > cur_rx_iv32)
cur_rx_iv32 = seq.tkip.iv32;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: mvm: initialize seq variable
2022-04-01 23:06 [PATCH] iwlwifi: mvm: initialize seq variable Tom Rix
@ 2022-04-05 17:57 ` Nick Desaulniers
0 siblings, 0 replies; 2+ messages in thread
From: Nick Desaulniers @ 2022-04-05 17:57 UTC (permalink / raw)
To: Tom Rix
Cc: luciano.coelho, kvalo, davem, kuba, pabeni, nathan,
johannes.berg, emmanuel.grumbach, dan.carpenter, linux-wireless,
netdev, linux-kernel, llvm
On Fri, Apr 1, 2022 at 4:06 PM Tom Rix <trix@redhat.com> wrote:
>
> Clang static analysis reports this issue
> d3.c:567:22: warning: The left operand of '>' is
> a garbage value
> if (seq.tkip.iv32 > cur_rx_iv32)
> ~~~~~~~~~~~~~ ^
>
> seq is never initialized. Call ieee80211_get_key_rx_seq() to
> initialize seq.
>
> Fixes: 0419e5e672d6 ("iwlwifi: mvm: d3: separate TKIP data from key iteration")
> Signed-off-by: Tom Rix <trix@redhat.com>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
> index a995bba0ba81..9b190b3ce6c1 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
> @@ -563,6 +563,7 @@ static void iwl_mvm_wowlan_get_tkip_data(struct ieee80211_hw *hw,
> }
>
> for (i = 0; i < IWL_NUM_RSC; i++) {
> + ieee80211_get_key_rx_seq(key, i, &seq);
> /* wrapping isn't allowed, AP must rekey */
> if (seq.tkip.iv32 > cur_rx_iv32)
> cur_rx_iv32 = seq.tkip.iv32;
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-05 20:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 23:06 [PATCH] iwlwifi: mvm: initialize seq variable Tom Rix
2022-04-05 17:57 ` Nick Desaulniers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).