* [PATCH] iio: light apds9960: Add the missing dev.parent
@ 2016-05-05 8:10 Yong Li
2016-05-05 8:18 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Yong Li @ 2016-05-05 8:10 UTC (permalink / raw)
To: sdliyong, jic23, knaack.h, lars, pmeerw, mranostay, fengguang.wu,
sst, dan.carpenter, linux-iio, linux-kernel
Without this, the iio:deviceX is missing in the /sys/bus/i2c/devices/0-0039
Signed-off-by: Yong Li <sdliyong@gmail.com>
---
drivers/iio/light/apds9960.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index 35928fb..f47cc0a 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -1010,6 +1010,7 @@ static int apds9960_probe(struct i2c_client *client,
iio_device_attach_buffer(indio_dev, buffer);
+ indio_dev->dev.parent = &client->dev;
indio_dev->info = &apds9960_info;
indio_dev->name = APDS9960_DRV_NAME;
indio_dev->channels = apds9960_channels;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light apds9960: Add the missing dev.parent
2016-05-05 8:10 [PATCH] iio: light apds9960: Add the missing dev.parent Yong Li
@ 2016-05-05 8:18 ` Matt Ranostay
2016-05-14 17:50 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2016-05-05 8:18 UTC (permalink / raw)
To: Yong Li
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, fengguang.wu, Slawomir Stepien,
dan.carpenter, linux-iio, linux-kernel
Reviewed-By: Matt Ranostay <mranostay@gmail.com>
On Thu, May 5, 2016 at 1:10 AM, Yong Li <sdliyong@gmail.com> wrote:
> Without this, the iio:deviceX is missing in the /sys/bus/i2c/devices/0-0039
>
> Signed-off-by: Yong Li <sdliyong@gmail.com>
> ---
> drivers/iio/light/apds9960.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index 35928fb..f47cc0a 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -1010,6 +1010,7 @@ static int apds9960_probe(struct i2c_client *client,
>
> iio_device_attach_buffer(indio_dev, buffer);
>
> + indio_dev->dev.parent = &client->dev;
> indio_dev->info = &apds9960_info;
> indio_dev->name = APDS9960_DRV_NAME;
> indio_dev->channels = apds9960_channels;
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light apds9960: Add the missing dev.parent
2016-05-05 8:18 ` Matt Ranostay
@ 2016-05-14 17:50 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-05-14 17:50 UTC (permalink / raw)
To: Matt Ranostay, Yong Li
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
fengguang.wu, Slawomir Stepien, dan.carpenter, linux-iio,
linux-kernel
On 05/05/16 09:18, Matt Ranostay wrote:
> Reviewed-By: Matt Ranostay <mranostay@gmail.com>
>
> On Thu, May 5, 2016 at 1:10 AM, Yong Li <sdliyong@gmail.com> wrote:
>> Without this, the iio:deviceX is missing in the /sys/bus/i2c/devices/0-0039
>>
>> Signed-off-by: Yong Li <sdliyong@gmail.com>
Applied and marked for stable.
I'd added a brief note that some userspace code may expect this path to work
to justify the stable tag.
Thanks,
Jonathan
>> ---
>> drivers/iio/light/apds9960.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
>> index 35928fb..f47cc0a 100644
>> --- a/drivers/iio/light/apds9960.c
>> +++ b/drivers/iio/light/apds9960.c
>> @@ -1010,6 +1010,7 @@ static int apds9960_probe(struct i2c_client *client,
>>
>> iio_device_attach_buffer(indio_dev, buffer);
>>
>> + indio_dev->dev.parent = &client->dev;
>> indio_dev->info = &apds9960_info;
>> indio_dev->name = APDS9960_DRV_NAME;
>> indio_dev->channels = apds9960_channels;
>> --
>> 2.5.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-14 17:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-05 8:10 [PATCH] iio: light apds9960: Add the missing dev.parent Yong Li
2016-05-05 8:18 ` Matt Ranostay
2016-05-14 17:50 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).