From: Hirokazu Honda <hiroh@google.com>
To: Irui Wang <Irui.Wang@mediatek.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Alexandre Courbot <acourbot@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Maoguang Meng <Maoguang.Meng@mediatek.com>,
Longfei Wang <Longfei.Wang@mediatek.com>,
Yunfei Dong <Yunfei.Dong@mediatek.com>,
Fritz Koenig <frkoenig@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max bitrate settings
Date: Wed, 6 Oct 2021 09:57:30 +0900 [thread overview]
Message-ID: <CAL1V8yzgu6k=RbijbiPGZsbbQMSk0LQRewvgzOgmO0Bbg6wBcA@mail.gmail.com> (raw)
In-Reply-To: <20210926033935.9258-1-irui.wang@mediatek.com>
Hi Irui, thank you for the patch.
On Sun, Sep 26, 2021 at 12:39 PM Irui Wang <irui.wang@mediatek.com> wrote:
>
> Set recommend min/max bitrate range for MT8173 h264/vp8 encoder.
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
I confirmed the patch worked with my own test.
Tested-by: Hirokazu Honda <hiroh@chromium.org>
-Hiro
>
> ---
> This patch dependents on "Clean redundant encoder format definition",
> which already accepted into linux-next.git:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/patch/?id=4093eb21538ae4f2861b26f4615939e1fa50dc67
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> index 4489a9744cd7..5dce3681ce94 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> @@ -388,8 +388,8 @@ static const struct mtk_vcodec_enc_pdata mt8173_avc_pdata = {
> .num_capture_formats = ARRAY_SIZE(mtk_video_formats_capture_h264),
> .output_formats = mtk_video_formats_output,
> .num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
> - .min_bitrate = 1,
> - .max_bitrate = 4000000,
> + .min_bitrate = 64,
> + .max_bitrate = 60000000,
> .core_id = VENC_SYS,
> };
>
> @@ -400,7 +400,7 @@ static const struct mtk_vcodec_enc_pdata mt8173_vp8_pdata = {
> .output_formats = mtk_video_formats_output,
> .num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
> .min_bitrate = 64,
> - .max_bitrate = 4000000,
> + .max_bitrate = 9000000,
> .core_id = VENC_LT_SYS,
> };
>
> --
> 2.25.1
>
prev parent reply other threads:[~2021-10-06 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 3:39 [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max bitrate settings Irui Wang
2021-10-06 0:57 ` Hirokazu Honda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1V8yzgu6k=RbijbiPGZsbbQMSk0LQRewvgzOgmO0Bbg6wBcA@mail.gmail.com' \
--to=hiroh@google.com \
--cc=Irui.Wang@mediatek.com \
--cc=Longfei.Wang@mediatek.com \
--cc=Maoguang.Meng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yunfei.Dong@mediatek.com \
--cc=acourbot@chromium.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).