* [alsa-devel][PATCH] Signed-off-by: lsh <410860423@qq.com>
@ 2019-07-20 6:17 lsh
2019-07-20 6:35 ` lsh
2019-07-22 17:59 ` John Stultz
0 siblings, 2 replies; 3+ messages in thread
From: lsh @ 2019-07-20 6:17 UTC (permalink / raw)
To: tglx; +Cc: sboyd, john.stultz, linux-kernel, lsh
From: lsh <410860423@qq.com>
Modification of leap seconds from 58 59 59 00 to 58 59 00 00
---
kernel/time/ntp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 65eb796..7edae41 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -425,7 +425,6 @@ int second_overflow(time64_t secs)
ntp_next_leap_sec = TIME64_MAX;
time_state = TIME_OK;
} else if (secs == ntp_next_leap_sec) {
- leap = -1;
time_state = TIME_OOP;
printk(KERN_NOTICE
"Clock: inserting leap second 23:59:60 UTC\n");
@@ -444,6 +443,7 @@ int second_overflow(time64_t secs)
}
break;
case TIME_OOP:
+ leap = -1;
ntp_next_leap_sec = TIME64_MAX;
time_state = TIME_WAIT;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [alsa-devel][PATCH] Signed-off-by: lsh <410860423@qq.com>
2019-07-20 6:17 [alsa-devel][PATCH] Signed-off-by: lsh <410860423@qq.com> lsh
@ 2019-07-20 6:35 ` lsh
2019-07-22 17:59 ` John Stultz
1 sibling, 0 replies; 3+ messages in thread
From: lsh @ 2019-07-20 6:35 UTC (permalink / raw)
To: tglx; +Cc: sboyd, john.stultz, linux-kernel, 42304622, lsh
From: lsh <410860423@qq.com>
Modification of leap seconds from 58 59 59 00 to 58 59 00 00
---
kernel/time/ntp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 65eb796..7edae41 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -425,7 +425,6 @@ int second_overflow(time64_t secs)
ntp_next_leap_sec = TIME64_MAX;
time_state = TIME_OK;
} else if (secs == ntp_next_leap_sec) {
- leap = -1;
time_state = TIME_OOP;
printk(KERN_NOTICE
"Clock: inserting leap second 23:59:60 UTC\n");
@@ -444,6 +443,7 @@ int second_overflow(time64_t secs)
}
break;
case TIME_OOP:
+ leap = -1;
ntp_next_leap_sec = TIME64_MAX;
time_state = TIME_WAIT;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel][PATCH] Signed-off-by: lsh <410860423@qq.com>
2019-07-20 6:17 [alsa-devel][PATCH] Signed-off-by: lsh <410860423@qq.com> lsh
2019-07-20 6:35 ` lsh
@ 2019-07-22 17:59 ` John Stultz
1 sibling, 0 replies; 3+ messages in thread
From: John Stultz @ 2019-07-22 17:59 UTC (permalink / raw)
To: lsh; +Cc: Thomas Gleixner, Stephen Boyd, lkml, 42304622, lsh
On Fri, Jul 19, 2019 at 11:35 PM lsh <linsheng_111@163.com> wrote:
>
> From: lsh <410860423@qq.com>
>
> Modification of leap seconds from 58 59 59 00 to 58 59 00 00
In the future, on other patches, you should provide a rational for
*why* you are submitting this change, not what the change does.
As for this patch, it would be a bad change, as this changes the
established behavior that the repeating 59th second w/ the TIME_OOP
flag set is the 60th/leap second and would break any apps that care to
actually watch for the leap second. Your change would cause
applications that do not care about leapseconds which have timers set
to the 00:00:00 UTC to fire a second early.
thanks
-john
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-22 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-20 6:17 [alsa-devel][PATCH] Signed-off-by: lsh <410860423@qq.com> lsh
2019-07-20 6:35 ` lsh
2019-07-22 17:59 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).