linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>, San Mehat <san@google.com>,
	Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak
Date: Mon, 8 Feb 2016 10:50:57 -0800	[thread overview]
Message-ID: <CALAqxLUq36L_L+-yEvFVYxamvk_=tF3b7ROXWr=qD_oGdGykOQ@mail.gmail.com> (raw)
In-Reply-To: <20160207224919.GA29549@kroah.com>

On Sun, Feb 7, 2016 at 2:49 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Jan 29, 2016 at 10:07:32PM -0800, John Stultz wrote:
>> From: San Mehat <san@google.com>
>>
>> As it turns out, the CONFIG_PROFILING interfaces leak a
>> task struct if the notifier chain returns NOTIFY_OK.. doh.
>>
>> This patch reworks lowmemkiller to use the new generic task
>> free notifier chain.
>>
>> Cc: Android Kernel Team <kernel-team@android.com>
>> Cc: Greg KH <gregkh@linuxfoundation.org>
>> Signed-off-by: San Mehat <san@google.com>
>> [jstultz: Commit subject tweak]
>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>> ---
>>  drivers/staging/android/lowmemorykiller.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
>> index 8b5a4a8..806643d 100644
>> --- a/drivers/staging/android/lowmemorykiller.c
>> +++ b/drivers/staging/android/lowmemorykiller.c
>> @@ -40,7 +40,6 @@
>>  #include <linux/sched.h>
>>  #include <linux/swap.h>
>>  #include <linux/rcupdate.h>
>> -#include <linux/profile.h>
>>  #include <linux/notifier.h>
>>
>>  static u32 lowmem_debug_level = 1;
>> --
>> 1.9.1
>
> The changelog comment seems a bit "odd" when looking at the patch here.
> Is the patch really correct?  The changelog?

Yea. Sorry for my oversight here. Had to do some patch archaeology and
found that the content of that patch basically dropped out when
83dbbdbb38 ("android, lowmemorykiller: remove task handoff notifier")
landed upstream in 3.4. Since then its been rebased along being
basically content-less.

So please ignore it.  I'll try to get it dropped from the AOSP tree.

thanks
-john

  reply	other threads:[~2016-02-08 18:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-30  6:07 [PATCH 0/9] staging: Updates from the Android tree John Stultz
2016-01-30  6:07 ` [PATCH 1/9] staging: ashmem: Avoid deadlock with mmap/shrink John Stultz
2016-01-30  6:07 ` [PATCH 2/9] staging: ashmem: Add missing include John Stultz
2016-01-30  6:07 ` [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak John Stultz
2016-02-07 22:49   ` Greg KH
2016-02-08 18:50     ` John Stultz [this message]
2016-01-30  6:07 ` [PATCH 4/9] staging: lowmemorykiller: Make default lowmemorykiller debug message useful John Stultz
2016-01-30  6:07 ` [PATCH 5/9] staging: lowmemorykiller: Trace kill events John Stultz
2016-01-30  6:07 ` [PATCH 6/9] staging: ion: Set minimum carveout heap allocation order to PAGE_SHIFT John Stultz
2016-02-01 20:23   ` Laura Abbott
2016-01-30  6:07 ` [PATCH 7/9] staging: ion: Handle the memory mapping correctly on x86 John Stultz
2016-01-30  6:07 ` [PATCH 8/9] staging: ion: Add X86 dependency for ION_POOL_CACHE_POLICY John Stultz
2016-01-30  6:07 ` [PATCH 9/9] staging: ion: Fix page pool cache policy John Stultz
2016-02-01 21:10 ` [PATCH 0/9] staging: Updates from the Android tree Laura Abbott
2016-02-01 21:28   ` John Stultz
2016-02-07 22:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLUq36L_L+-yEvFVYxamvk_=tF3b7ROXWr=qD_oGdGykOQ@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=san@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).