linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Feng Chen <puck.chen@hisilicon.com>,
	Wei Xu <xuwei5@hisilicon.com>, Guodong Xu <guodong.xu@linaro.org>
Subject: Re: [PATCH 1/4] drivers: input: powerkey for HISI 65xx SoC
Date: Thu, 23 Jun 2016 13:31:28 -0700	[thread overview]
Message-ID: <CALAqxLVHgoXcUGj==FqJP6mU8JdoM5XNr1aUpEDJ6xDHF=2htg@mail.gmail.com> (raw)
In-Reply-To: <20160623004716.GA26808@dtor-ws>

On Wed, Jun 22, 2016 at 5:47 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Jun 21, 2016 at 05:06:23PM -0700, John Stultz wrote:
>> On Tue, Jun 14, 2016 at 3:43 PM, John Stultz <john.stultz@linaro.org> wrote:
>> > From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> >
>> > This driver provides a input driver for the power button on the
>> > HiSi 65xx SoC for boards like HiKey.
>> >
>> > This driver was originally by Zhiliang Xue <xuezhiliang@huawei.com>
>> > then basically rewritten by Jorge, but preserving the original
>> > module author credits.
>> >
>> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> > Cc: Rob Herring <robh+dt@kernel.org>
>> > Cc: Lee Jones <lee.jones@linaro.org>
>> > Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> > Cc: Feng Chen <puck.chen@hisilicon.com>
>> > Cc: Wei Xu <xuwei5@hisilicon.com>
>> > Cc: Guodong Xu <guodong.xu@linaro.org>
>> > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> > [jstultz: Reworked commit message, folded in other fixes/cleanups
>> > from Jorge, implemented some larger cleanups suggested by DmitryT]
>> > Signed-off-by: John Stultz <john.stultz@linaro.org>
>> > ---
>> > v2: Major rework integrating feedback from Dmitry.
>> > v3: Dropped of_match compatible line since no longer using DT
>> >     for this.
>> > v4: Removed MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match) line
>> >     I missed in the last revision, which casued build issues w/
>> >     modules.
>>
>> Hey Dmitry,
>>   Just wanted to ping you to see if there was anything else you were
>> wanting changed with this patch. Lee has queued the mfd patches in
>> -next, so I wanted to be sure to address any concerns you had that was
>> keeping this from heading upstream in 4.8 (hopefully :).
>
> Right, sorry, does the following look OK to you?
>

Yes! It looks great (and I tested it works too)!

Do you want to fold that in, or do you need me to re-submit with those changes?

thanks
-john

  reply	other threads:[~2016-06-23 20:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 22:43 [PATCH 0/4] Hi655x powerkey support for HiKey (v4) John Stultz
2016-06-14 22:43 ` [PATCH 1/4] drivers: input: powerkey for HISI 65xx SoC John Stultz
2016-06-22  0:06   ` John Stultz
2016-06-23  0:47     ` Dmitry Torokhov
2016-06-23 20:31       ` John Stultz [this message]
2016-06-23 20:40         ` Dmitry Torokhov
2016-06-23 20:47           ` Dmitry Torokhov
2016-06-23 20:54             ` John Stultz
2016-06-23 21:03               ` Dmitry Torokhov
2016-06-14 22:43 ` [PATCH 2/4] mfd: hi655x-pmic: Fixup issue with un-acked interrupts John Stultz
2016-06-15 12:54   ` Lee Jones
2016-06-14 22:43 ` [PATCH 3/4] mfd: hi655x-pmic: Rename some interrupt macro names John Stultz
2016-06-15 12:54   ` Lee Jones
2016-06-14 22:43 ` [PATCH 4/4] mfd: hi655x-pmic: Add powerkey device to hi655x PMIC driver John Stultz
2016-06-15 12:54   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLVHgoXcUGj==FqJP6mU8JdoM5XNr1aUpEDJ6xDHF=2htg@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=guodong.xu@linaro.org \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=puck.chen@hisilicon.com \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).