linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC/PATCH 09/11] clocksource: add TI 32.768 Hz counter driver
Date: Thu, 1 Oct 2015 15:20:18 -0700	[thread overview]
Message-ID: <CALAqxLVUDYivs4QKWtFDbwFdWqa2JJX49Aj15p69zpYCb1_SbA@mail.gmail.com> (raw)
In-Reply-To: <1443559446-26969-10-git-send-email-balbi@ti.com>

On Tue, Sep 29, 2015 at 1:44 PM, Felipe Balbi <balbi@ti.com> wrote:
> Introduce a new clocksource driver for Texas
> Instruments 32.768 Hz device which is available
> on most OMAP-like devices.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/clocksource/Kconfig        |   8 +++
>  drivers/clocksource/Makefile       |   1 +
>  drivers/clocksource/timer-ti-32k.c | 121 +++++++++++++++++++++++++++++++++++++

Also isn't this somewhat duplicate of the code in
arch/arm/plat-omap/counter_32k.c ?

Was this really a rewrite or just a code migration? Should you
preserve the copyrights from counter_32k.c?

thanks
-john

  parent reply	other threads:[~2015-10-01 22:20 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 20:43 [RFC/PATCH 00/11] arm: omap: counter32k rework Felipe Balbi
2015-09-29 20:43 ` [RFC/PATCH 01/11] arm: omap2: timer: get rid of obfuscating macros Felipe Balbi
2015-09-29 20:43 ` [RFC/PATCH 02/11] arm: omap2: timer: add a gptimer argument to sync32k_timer_init() Felipe Balbi
2015-09-29 20:43 ` [RFC/PATCH 03/11] arm: omap2: timer: remove __omap_gptimer_init() Felipe Balbi
2015-10-05 11:01   ` Tony Lindgren
2015-10-05 15:24     ` Felipe Balbi
2015-10-05 16:02       ` Tony Lindgren
2015-10-05 16:08         ` Felipe Balbi
2015-10-05 16:30           ` Tony Lindgren
2015-09-29 20:43 ` [RFC/PATCH 04/11] arm: omap2: timer: provide generic sync32k_timer_init function Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 05/11] arm: omap2: timer: move realtime_counter_init() around Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 06/11] arm: omap2: timer: always call clocksource_of_init() when DT Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 07/11] arm: omap2: timer: remove omap4_local_timer_init Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 08/11] arm: omap2: timer: rename omap_sync32k_timer_init() Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 09/11] clocksource: add TI 32.768 Hz counter driver Felipe Balbi
2015-10-01 21:58   ` John Stultz
2015-10-01 21:59   ` Daniel Lezcano
2015-10-05 10:50     ` Tony Lindgren
2015-10-05 11:03       ` Tony Lindgren
2015-10-01 22:20   ` John Stultz [this message]
2015-10-01 22:30     ` Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 10/11] arm: omap2: timer: limit hwmod usage to non-DT boots Felipe Balbi
2015-09-29 20:44 ` [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Felipe Balbi
2015-09-30  8:15   ` Arnd Bergmann
2015-09-30 14:12     ` Felipe Balbi
2015-09-30 21:58       ` Arnd Bergmann
2015-10-05 17:52         ` Felipe Balbi
2015-10-05 19:41           ` Felipe Balbi
2015-10-06  8:08             ` Arnd Bergmann
2015-10-06 14:57               ` Felipe Balbi
2015-10-06 15:18                 ` Tony Lindgren
2015-10-06 15:29                   ` Felipe Balbi
2015-10-05 10:45   ` Tony Lindgren
2015-09-30  8:22 ` [RFC/PATCH 00/11] arm: omap: counter32k rework Arnd Bergmann
2015-09-30 14:13   ` Felipe Balbi
2015-09-30 14:42     ` Arnd Bergmann
2015-09-30 14:49       ` Arnd Bergmann
2015-09-30 14:57         ` Felipe Balbi
2015-09-30 15:03         ` Thierry Reding
2015-10-01 22:12         ` Daniel Lezcano
2015-10-05 10:55           ` Tony Lindgren
2015-10-05 11:03             ` Arnd Bergmann
2015-10-05 11:13               ` Tony Lindgren
2015-10-05 12:19                 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALAqxLVUDYivs4QKWtFDbwFdWqa2JJX49Aj15p69zpYCb1_SbA@mail.gmail.com \
    --to=john.stultz@linaro.org \
    --cc=balbi@ti.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).