linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Chen Yu <chenyu56@huawei.com>, Wei Xu <xuwei5@hisilicon.com>,
	Guodong Xu <guodong.xu@linaro.org>,
	Amit Pundir <amit.pundir@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	John Youn <johnyoun@synopsys.com>,
	Douglas Anderson <dianders@chromium.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux USB List <linux-usb@vger.kernel.org>
Subject: Re: [RFC][PATCH 5/5] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220
Date: Tue, 13 Dec 2016 11:23:03 -0800	[thread overview]
Message-ID: <CALAqxLW60PCgiRpXb9woTqeLqRkv=Y9m422ON5HC7nd=e7Rqcw@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1612130822320.31292-100000@netrider.rowland.org>

On Tue, Dec 13, 2016 at 5:24 AM, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Mon, 12 Dec 2016, John Stultz wrote:
>
>> From: Chen Yu <chenyu56@huawei.com>
>>
>> The Hi6220's usb controller is limited in that it does not
>> support "Split Transactions", so it does not support communicating
>> with low-speed and full-speed devices behind a high-speed hub.
>>
>> Thus it requires a quirk so that we can manually drop the usb
>> speed when low/full-speed are attached, and bump back to high
>> speed when they are removed.
>
> Just out of curiosity (I know nothing about this hardware), what

If your interested in details, page 12 of the pdf here has some details:
https://github.com/96boards/documentation/blob/master/ConsumerEdition/HiKey/AdditionalDocs/HiKey_Hardware_User_Manual_Rev0.2.pdf

There's also schematics for the board available (if you are interested
in that sort of stuff). You can find the USB bits on Page 4 here:
https://github.com/96boards/documentation/blob/master/ConsumerEdition/HiKey/HardwareDocs/HiKey_schematics_LeMaker_version_Rev_A1.pdf


> happens if there is a high-speed hub plugged into the host controller
> and both a high-speed and a full-speed device plugged into the hub?
>
> Do you end up forcing the high-speed device to run at full speed?

Yes. It drops back to full-speed.

thanks
-john

      reply	other threads:[~2016-12-13 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13  7:09 [RFC][PATCH 0/5] Fixes and workarounds for dwc2 on HiKey board John Stultz
2016-12-13  7:09 ` [RFC][PATCH 1/5] usb: dwc2: Avoid sleeping while holding hsotg->lock John Stultz
2016-12-13  7:09 ` [RFC][PATCH 2/5] usb: dwc2: Workaround case where GOTGCTL state is wrong John Stultz
2016-12-13 12:28   ` Vardan Mikayelyan
2016-12-13 20:40     ` John Stultz
2016-12-13  7:09 ` [RFC][PATCH 3/5] usb: dwc2: Force port resume on switching to device mode John Stultz
2016-12-13  7:09 ` [RFC][PATCH 4/5] usb: dwc2: Avoid suspending if we're in gadget mode John Stultz
2016-12-13  7:09 ` [RFC][PATCH 5/5] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220 John Stultz
2016-12-13 13:24   ` Alan Stern
2016-12-13 19:23     ` John Stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLW60PCgiRpXb9woTqeLqRkv=Y9m422ON5HC7nd=e7Rqcw@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=amit.pundir@linaro.org \
    --cc=chenyu56@huawei.com \
    --cc=dianders@chromium.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guodong.xu@linaro.org \
    --cc=johnyoun@synopsys.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).