linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andy Lutomirski <luto@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>,
	Eric Biggers <ebiggers3@gmail.com>,
	linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Stephan Mueller <smueller@chronox.de>
Subject: Re: [PATCH] wusbcore: Fix one more crypto-on-the-stack bug
Date: Mon, 12 Dec 2016 15:57:52 -0800	[thread overview]
Message-ID: <CALCETrUazFL7h01Ej_TttFJrEMRTivZKDx8nLWkZRkBdfcH=ug@mail.gmail.com> (raw)
In-Reply-To: <20161212214447.GA12142@kroah.com>

On Mon, Dec 12, 2016 at 1:44 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Dec 12, 2016 at 12:52:45PM -0800, Andy Lutomirski wrote:
>> The driver put a constant buffer of all zeros on the stack and
>> pointed a scatterlist entry at it.  This doesn't work with virtual
>> stacks.  Make the buffer static to fix it.
>>
>> Cc: stable@vger.kernel.org # 4.9 only
>> Reported-by: Eric Biggers <ebiggers3@gmail.com>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>> ---
>>  drivers/usb/wusbcore/crypto.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/wusbcore/crypto.c b/drivers/usb/wusbcore/crypto.c
>> index 79451f7ef1b7..a7e007a0cd49 100644
>> --- a/drivers/usb/wusbcore/crypto.c
>> +++ b/drivers/usb/wusbcore/crypto.c
>> @@ -216,7 +216,7 @@ static int wusb_ccm_mac(struct crypto_skcipher *tfm_cbc,
>>       struct scatterlist sg[4], sg_dst;
>>       void *dst_buf;
>>       size_t dst_size;
>> -     const u8 bzero[16] = { 0 };
>> +     static const u8 bzero[16] = { 0 };
>
> Hm, can static memory handle DMA?  That's a requirement of the USB
> stack, does this data later end up being sent down to a USB host
> controller?

I think it doesn't, but I'll switch it to use empty_zero_page instead.

--Andy

  reply	other threads:[~2016-12-12 23:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 20:52 [PATCH] wusbcore: Fix one more crypto-on-the-stack bug Andy Lutomirski
2016-12-12 20:53 ` [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs Andy Lutomirski
2016-12-13 12:20   ` David Laight
2016-12-13 16:40     ` Andy Lutomirski
2016-12-14 16:58       ` Joerg Roedel
2016-12-13 16:45     ` David Howells
2016-12-13 17:02       ` Andy Lutomirski
2016-12-13 20:02       ` David Howells
2016-12-12 20:54 ` [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack Andy Lutomirski
2016-12-13 11:40   ` Sergei Shtylyov
2016-12-13 13:07   ` Jeff Layton
2016-12-14  8:19     ` Steve French
2016-12-12 20:55 ` [PATCH] crypto: Make a few drivers depend on !VMAP_STACK Andy Lutomirski
2016-12-13  3:42   ` Herbert Xu
2016-12-12 20:55 ` [PATCH] orinoco: Use shash instead of ahash for MIC calculations Andy Lutomirski
2016-12-13  7:54   ` Eric Biggers
2016-12-13 11:35   ` Kalle Valo
2016-12-13 16:41     ` Andy Lutomirski
2016-12-13 17:03       ` Kalle Valo
2016-12-30 11:34   ` Kalle Valo
2016-12-30 12:02     ` Kalle Valo
2016-12-30 12:15       ` Kalle Valo
2016-12-12 21:44 ` [PATCH] wusbcore: Fix one more crypto-on-the-stack bug Greg KH
2016-12-12 23:57   ` Andy Lutomirski [this message]
2016-12-12 22:28 ` [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs David Howells
2016-12-13  0:32   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALCETrUazFL7h01Ej_TttFJrEMRTivZKDx8nLWkZRkBdfcH=ug@mail.gmail.com' \
    --to=luto@amacapital.net \
    --cc=ebiggers3@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).