* Removing entry trampoline and associated reversions
@ 2018-08-27 16:42 Andy Lutomirski
2018-08-27 16:42 ` Andy Lutomirski
0 siblings, 1 reply; 3+ messages in thread
From: Andy Lutomirski @ 2018-08-27 16:42 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, LKML, Adrian Hunter,
Alexander Shishkin, Arnaldo Carvalho de Melo
Hi all-
We had an unfortunate conflict. Adrian did all the plumbing to get
entry_trampoline to play nicelyh with kcore and perf. Meanwhile, I
was working on getting rid of the entry trampoline. Adrian's code is
merged and mine is finally in good shape, and there's an obvious
conflict.
So I did a bunch of reverts, all but one of which were clean. The
series is here:
https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=x86/pti
and the messy revert is here:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Removing entry trampoline and associated reversions
2018-08-27 16:42 Removing entry trampoline and associated reversions Andy Lutomirski
@ 2018-08-27 16:42 ` Andy Lutomirski
2018-08-28 7:02 ` Adrian Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Andy Lutomirski @ 2018-08-27 16:42 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Ingo Molnar, Thomas Gleixner, LKML, Adrian Hunter,
Alexander Shishkin, Arnaldo Carvalho de Melo
[gah -- accidentally hit send]
On Mon, Aug 27, 2018 at 9:42 AM, Andy Lutomirski <luto@kernel.org> wrote:
> Hi all-
>
> We had an unfortunate conflict. Adrian did all the plumbing to get
> entry_trampoline to play nicelyh with kcore and perf. Meanwhile, I
> was working on getting rid of the entry trampoline. Adrian's code is
> merged and mine is finally in good shape, and there's an obvious
> conflict.
>
> So I did a bunch of reverts, all but one of which were clean. The
> series is here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=x86/pti
>
> and the messy revert is here:
https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/pti&id=50ef6380e448650b48db979d7d1f20a325b0a273
Is this the right approach?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Removing entry trampoline and associated reversions
2018-08-27 16:42 ` Andy Lutomirski
@ 2018-08-28 7:02 ` Adrian Hunter
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2018-08-28 7:02 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Ingo Molnar, Thomas Gleixner, LKML, Alexander Shishkin,
Arnaldo Carvalho de Melo
On 27/08/18 19:42, Andy Lutomirski wrote:
> [gah -- accidentally hit send]
>
> On Mon, Aug 27, 2018 at 9:42 AM, Andy Lutomirski <luto@kernel.org> wrote:
>> Hi all-
>>
>> We had an unfortunate conflict. Adrian did all the plumbing to get
>> entry_trampoline to play nicelyh with kcore and perf. Meanwhile, I
>> was working on getting rid of the entry trampoline. Adrian's code is
>> merged and mine is finally in good shape, and there's an obvious
>> conflict.
>>
>> So I did a bunch of reverts, all but one of which were clean. The
>> series is here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=x86/pti
We are kind of stuck with the 'perf tools' changes as they are. That is
because CONFIG_KASAN changes the size of the cpu entry area, which means
that the kernel patches are still potentially useful for kernels from v4.15
to v4.19 incl., which in turn means we still need 'perf tools' support for them.
If we didn't want to support that, we still need the tools workaround that
hard-codes the trampoline addresses for v4.15 to v4.19. And possibly we
would need to ensure perf.data files (and copies of kcore) with trampoline
maps recorded, are still handled correctly.
>>
>> and the messy revert is here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/pti&id=50ef6380e448650b48db979d7d1f20a325b0a273
Should be able to get rid of KCORE_REMAP and kcore_list.vaddr also.
>
> Is this the right approach?
>
You could leave the tools changes to me if you want.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-28 7:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27 16:42 Removing entry trampoline and associated reversions Andy Lutomirski
2018-08-27 16:42 ` Andy Lutomirski
2018-08-28 7:02 ` Adrian Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).