From: Andy Lutomirski <luto@amacapital.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base
Date: Mon, 21 Mar 2016 15:08:46 -0700 [thread overview]
Message-ID: <CALCETrWPT5QQ-mkMnEExMWzSOMmr9f5h4La_m-AXQmvvX+WfLw@mail.gmail.com> (raw)
In-Reply-To: <20160321220528.GE5083@two.firstfloor.org>
On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <andi@firstfloor.org> wrote:
>> Please add a patch before this one that renames gs to gsbase. This is
>> unreadable as is.
>
> I investigated this now, and it's not straight forward because on 32bit
> ->gs is actually gsindex, not gsbase. So with a straight rename you
> would end up with index in base on 32bit, which would be confusing.
>
I would take this inconsistency as a reason why this needs to be fixed
before any further changes are made.
The variables should be called "gsbase" and "gsindex", full stop.
It's not particularly risky -- we could even compare the generated
code if we cared.
--Andy
next prev parent reply other threads:[~2016-03-21 22:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 16:16 Updated version of RD/WR FS/GS BASE patchkit Andi Kleen
2016-03-21 16:16 ` [PATCH 1/9] x86: Add intrinsics/macros for new rd/wr fs/gs base instructions Andi Kleen
2016-03-21 18:14 ` Andy Lutomirski
2016-03-21 16:16 ` [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen
2016-03-21 18:13 ` Andy Lutomirski
2016-03-21 19:05 ` Andi Kleen
2016-03-21 19:22 ` Andy Lutomirski
2016-03-21 22:05 ` Andi Kleen
2016-03-21 22:08 ` Andy Lutomirski [this message]
2016-03-21 22:15 ` Andi Kleen
2016-03-22 8:36 ` Thomas Gleixner
2016-03-22 14:40 ` Brian Gerst
2016-04-15 0:06 ` Andy Lutomirski
2016-03-21 16:16 ` [PATCH 3/9] x86: Make old K8 swapgs workaround conditional Andi Kleen
2016-03-21 16:16 ` [PATCH 4/9] x86: Enumerate kernel FSGS capability in AT_HWCAP2 Andi Kleen
2016-03-21 18:49 ` Brian Gerst
2016-03-21 18:54 ` Andi Kleen
2016-03-21 19:32 ` Brian Gerst
2016-03-21 19:43 ` Andi Kleen
2016-03-21 22:10 ` Andy Lutomirski
2016-03-21 16:16 ` [PATCH 5/9] x86: Add documentation for rd/wr fs/gs base Andi Kleen
2016-03-23 19:14 ` Valdis.Kletnieks
2016-03-21 16:16 ` [PATCH 6/9] x86: Use rd/wr fs/gs base in arch_prctl Andi Kleen
2016-03-21 18:17 ` Andy Lutomirski
2016-03-21 16:16 ` [PATCH 7/9] x86: Add self test code for fsgsbase Andi Kleen
2016-03-21 16:16 ` [PATCH 8/9] x86: Support arbitrary fs/gs base in getregs Andi Kleen
2016-03-21 16:16 ` [PATCH 9/9] x86: Save FS/GS base in core dump Andi Kleen
2016-03-21 18:39 ` Updated version of RD/WR FS/GS BASE patchkit Andy Lutomirski
2016-03-21 19:03 ` Andi Kleen
2016-03-21 19:23 ` Andy Lutomirski
2016-03-21 19:40 ` Andi Kleen
2016-03-21 22:05 ` Andy Lutomirski
2016-03-21 22:11 ` Andi Kleen
2016-03-21 22:27 ` Andy Lutomirski
2016-03-21 22:41 ` Andi Kleen
2016-03-21 22:47 ` Andy Lutomirski
2016-03-21 22:52 ` Andi Kleen
2016-03-21 22:57 ` Andy Lutomirski
2016-03-21 23:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrWPT5QQ-mkMnEExMWzSOMmr9f5h4La_m-AXQmvvX+WfLw@mail.gmail.com \
--to=luto@amacapital.net \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).