From: Andy Lutomirski <luto@amacapital.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linux Containers <containers@lists.linux-foundation.org>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Serge E. Hallyn" <serge@hallyn.com>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 0/4] user namespace fixes
Date: Mon, 17 Dec 2012 11:03:10 -0800 [thread overview]
Message-ID: <CALCETrX2Fa-DuM+wkgsij7oiJXzCD8W6Phkv-MjgCDg_Ma6CTg@mail.gmail.com> (raw)
In-Reply-To: <87txroxpgq.fsf@xmission.com>
On Fri, Dec 14, 2012 at 2:01 PM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
>
> These are fixes from Andys review of my user namespace tree.
>
> The first two patches are critical must fix fixes.
>
> The third patch fixing commit_creds is a nice to have but fixing it
> would be good.
>
> Andy, Serge if you could give these patches a once over to make certain
> I am not doing something stupid.
>
> Thank you,
> Eric
>
> ---
>
> Eric W. Biederman (4):
> Fix cap_capable to only allow owners in the parent user namespace to have caps.
For whatever reason, I didn't get the actual email. Assuming this is
5e4a08476b50fa39210fca82e03325cc46b9c235:
Acked-by: Andy Lutomirski <luto@amacapital.net>
However, this comment:
/*
* The owner of the user namespace in the parent of the
* user namespace has all caps.
*/
could use work. I agree with the code, but I gave up on understanding
the comment.
> userns: Require CAP_SYS_ADMIN for most uses of setns.
> userns: Add a more complete capability subset test to commit_creds
> userns: Fix typo in description of the limitation of userns_install
>
--Andy
next prev parent reply other threads:[~2012-12-17 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 22:01 [PATCH 0/4] user namespace fixes Eric W. Biederman
2012-12-14 22:03 ` [PATCH 1/4] Fix cap_capable to only allow owners in the parent user namespace to have caps Eric W. Biederman
2012-12-14 22:03 ` [PATCH 2/4] userns: Require CAP_SYS_ADMIN for most uses of setns Eric W. Biederman
2012-12-14 23:35 ` Serge E. Hallyn
2012-12-17 19:03 ` Andy Lutomirski
2012-12-14 22:04 ` [PATCH 3/4] userns: Add a more complete capability subset test to commit_creds Eric W. Biederman
2012-12-15 0:03 ` Serge E. Hallyn
2012-12-15 0:11 ` Eric W. Biederman
2012-12-15 0:47 ` Serge E. Hallyn
2012-12-15 0:48 ` Eric W. Biederman
2012-12-15 2:06 ` Serge E. Hallyn
2012-12-17 19:08 ` Andy Lutomirski
2012-12-14 22:05 ` [PATCH 4/4] userns: Fix typo in description of the limitation of userns_install Eric W. Biederman
2012-12-14 23:36 ` Serge E. Hallyn
2012-12-17 19:08 ` Andy Lutomirski
2012-12-17 19:03 ` Andy Lutomirski [this message]
2012-12-17 21:01 ` [PATCH 0/4] user namespace fixes Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrX2Fa-DuM+wkgsij7oiJXzCD8W6Phkv-MjgCDg_Ma6CTg@mail.gmail.com \
--to=luto@amacapital.net \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).