From: Greg Gallagher <greg@embeddedgreg.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Eric Anholt <eric@anholt.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/vc04_services: Fix alignment of function arguments
Date: Mon, 6 Aug 2018 08:37:49 -0400 [thread overview]
Message-ID: <CALLqZ8QiELH0x7a4E-eQyj6ewLmBuwQ7oYmHrZQ9kUcDWhaAMQ@mail.gmail.com> (raw)
In-Reply-To: <a3c26117-1774-f23e-37d0-2312d4312b63@i2se.com>
Hi,
On Mon, Aug 6, 2018 at 4:34 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi,
>
> Am 06.08.2018 um 06:07 schrieb Greg Gallagher:
>>
>> Fix warning generated by checkpatch.pl for alignment should match open
>> parenthesis. This is a coding style change only.
>>
>> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
>> ---
>> drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> index ec468d5719b1..33ae8ae8663b 100644
>> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> @@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
>> };
>> static int snd_bcm2835_spdif_default_info(struct snd_kcontrol
>> *kcontrol,
>> - struct snd_ctl_elem_info *uinfo)
>> + struct snd_ctl_elem_info *uinfo)
>> {
>> uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
>> uinfo->count = 1;
>
>
> in case this is the only alignment issue in the whole driver, you can have
> my acked-by.
> Otherwise please fix the other ones in the second version.
>
> Btw there are more drivers under vc04_services so a "staging: bcm2835-audio:
> Fix alignment of functions arguments" would be better.
>
> Stefan
I'll fix the other alignment issues as well in the second version and
fix up the subject line to staging: bcm2835-audio.
thanks
Greg
prev parent reply other threads:[~2018-08-06 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 4:07 [PATCH] staging/vc04_services: Fix alignment of function arguments Greg Gallagher
2018-08-06 8:34 ` Stefan Wahren
2018-08-06 12:37 ` Greg Gallagher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALLqZ8QiELH0x7a4E-eQyj6ewLmBuwQ7oYmHrZQ9kUcDWhaAMQ@mail.gmail.com \
--to=greg@embeddedgreg.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).