linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
@ 2016-09-04  9:00 Amit Ghadge
  2016-09-04  9:02 ` Amit Ghadge
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Amit Ghadge @ 2016-09-04  9:00 UTC (permalink / raw)
  To: abbotti; +Cc: gregkh, linux-kernel, devel, Amit Ghadge

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:

WARNING: Block comments use * on subsequent lines

Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
---
 drivers/staging/comedi/comedidev.h            |  8 ++---
 drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +++++++++++++--------------
 2 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index dcb6376..612a844 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
 
 #define RANGE(a, b)		{(a) * 1e6, (b) * 1e6, 0}
 #define RANGE_ext(a, b)		{(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
-#define RANGE_mA(a, b)		{(a) * 1e6, (b) * 1e6, UNIT_mA}
+#define RANGE_MA(a, b)		{(a) * 1e6, (b) * 1e6, UNIT_MA}
 #define RANGE_unitless(a, b)	{(a) * 1e6, (b) * 1e6, 0}
 #define BIP_RANGE(a)		{-(a) * 1e6, (a) * 1e6, 0}
 #define UNI_RANGE(a)		{0, (a) * 1e6, 0}
@@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
 extern const struct comedi_lrange range_unipolar10;
 extern const struct comedi_lrange range_unipolar5;
 extern const struct comedi_lrange range_unipolar2_5;
-extern const struct comedi_lrange range_0_20mA;
-extern const struct comedi_lrange range_4_20mA;
-extern const struct comedi_lrange range_0_32mA;
+extern const struct comedi_lrange range_0_20ma;
+extern const struct comedi_lrange range_4_20ma;
+extern const struct comedi_lrange range_0_32ma;
 extern const struct comedi_lrange range_unknown;
 
 #define range_digital		range_unipolar5
diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index d9de83a..ff3716c 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -1,35 +1,35 @@
 /*
-    comedi/drivers/ni_daq_dio24.c
-    Driver for National Instruments PCMCIA DAQ-Card DIO-24
-    Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
+ * comedi/drivers/ni_daq_dio24.c
+ * Driver for National Instruments PCMCIA DAQ-Card DIO-24
+ * Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
 
-    PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
-    2001/08/24 12:13:13 from the pcmcia package.
-    The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
-    <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
-    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
+ * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
+ * 2001/08/24 12:13:13 from the pcmcia package.
+ * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
+ * <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
+ * are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
 
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-*/
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 /*
-Driver: ni_daq_dio24
-Description: National Instruments PCMCIA DAQ-Card DIO-24
-Author: Daniel Vecino Castel <dvecino@able.es>
-Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
-Status: ?
-Updated: Thu, 07 Nov 2002 21:53:06 -0800
+ * Driver: ni_daq_dio24
+ * Description: National Instruments PCMCIA DAQ-Card DIO-24
+ * Author: Daniel Vecino Castel <dvecino@able.es>
+ * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
+ * Status: ?
+ * Updated: Thu, 07 Nov 2002 21:53:06 -0800
 
-This is just a wrapper around the 8255.o driver to properly handle
-the PCMCIA interface.
-*/
+ * This is just a wrapper around the 8255.o driver to properly handle
+ * the PCMCIA interface.
+ */
 
 #include <linux/module.h>
 #include "../comedi_pcmcia.h"
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04  9:00 [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Amit Ghadge
@ 2016-09-04  9:02 ` Amit Ghadge
  2016-09-04 11:08 ` kbuild test robot
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 11+ messages in thread
From: Amit Ghadge @ 2016-09-04  9:02 UTC (permalink / raw)
  To: Ian Abbott; +Cc: Greg KH, linux-kernel, devel, Amit Ghadge

On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge <amitg.b14@gmail.com> wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
>  drivers/staging/comedi/comedidev.h            |  8 ++---
>  drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +++++++++++++--------------
>  2 files changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index dcb6376..612a844 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
>  #define RANGE(a, b)            {(a) * 1e6, (b) * 1e6, 0}
>  #define RANGE_ext(a, b)                {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b)         {(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_MA(a, b)         {(a) * 1e6, (b) * 1e6, UNIT_MA}
>  #define RANGE_unitless(a, b)   {(a) * 1e6, (b) * 1e6, 0}
>  #define BIP_RANGE(a)           {-(a) * 1e6, (a) * 1e6, 0}
>  #define UNI_RANGE(a)           {0, (a) * 1e6, 0}
> @@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
>  extern const struct comedi_lrange range_unipolar10;
>  extern const struct comedi_lrange range_unipolar5;
>  extern const struct comedi_lrange range_unipolar2_5;
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
>  extern const struct comedi_lrange range_unknown;
>
>  #define range_digital          range_unipolar5
> diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
> index d9de83a..ff3716c 100644
> --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
> +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
> @@ -1,35 +1,35 @@
>  /*
> -    comedi/drivers/ni_daq_dio24.c
> -    Driver for National Instruments PCMCIA DAQ-Card DIO-24
> -    Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
> + * comedi/drivers/ni_daq_dio24.c
> + * Driver for National Instruments PCMCIA DAQ-Card DIO-24
> + * Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
>
> -    PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
> -    2001/08/24 12:13:13 from the pcmcia package.
> -    The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
> -    <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
> -    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
> + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
> + * 2001/08/24 12:13:13 from the pcmcia package.
> + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
> + * <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
> + * are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
>
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
>
> -    This program is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -    GNU General Public License for more details.
> -*/
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
>  /*
> -Driver: ni_daq_dio24
> -Description: National Instruments PCMCIA DAQ-Card DIO-24
> -Author: Daniel Vecino Castel <dvecino@able.es>
> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
> -Status: ?
> -Updated: Thu, 07 Nov 2002 21:53:06 -0800
> + * Driver: ni_daq_dio24
> + * Description: National Instruments PCMCIA DAQ-Card DIO-24
> + * Author: Daniel Vecino Castel <dvecino@able.es>
> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
> + * Status: ?
> + * Updated: Thu, 07 Nov 2002 21:53:06 -0800
>
> -This is just a wrapper around the 8255.o driver to properly handle
> -the PCMCIA interface.
> -*/
> + * This is just a wrapper around the 8255.o driver to properly handle
> + * the PCMCIA interface.
> + */
>
>  #include <linux/module.h>
>  #include "../comedi_pcmcia.h"
> --
> 2.5.5
>


Please ignore this patch.


Amit

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04  9:00 [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Amit Ghadge
  2016-09-04  9:02 ` Amit Ghadge
@ 2016-09-04 11:08 ` kbuild test robot
  2016-09-04 11:29 ` kbuild test robot
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 11+ messages in thread
From: kbuild test robot @ 2016-09-04 11:08 UTC (permalink / raw)
  To: Amit Ghadge; +Cc: kbuild-all, abbotti, devel, gregkh, Amit Ghadge, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3696 bytes --]

Hi Amit,

[auto build test WARNING on v4.8-rc4]
[cannot apply to staging/staging-testing next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
config: i386-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/staging/comedi/drivers/dac02.c:66:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
      RANGE_mA(4, 20),
      ^~~~~~~~
   drivers/staging/comedi/drivers/dac02.c:66:3: error: initializer element is not constant
   drivers/staging/comedi/drivers/dac02.c:66:3: note: (near initialization for 'das02_ao_ranges.range[4].min')
   drivers/staging/comedi/drivers/dac02.c:67:3: warning: braces around scalar initializer
      RANGE_ext(0, 1)
      ^
   drivers/staging/comedi/drivers/dac02.c:67:3: note: (near initialization for 'das02_ao_ranges.range[4].max')
>> drivers/staging/comedi/drivers/dac02.c:67:15: warning: excess elements in scalar initializer
      RANGE_ext(0, 1)
                  ^
   drivers/staging/comedi/drivers/dac02.c:67:15: note: (near initialization for 'das02_ao_ranges.range[4].max')
   drivers/staging/comedi/drivers/dac02.c:67:26: warning: excess elements in scalar initializer
      RANGE_ext(0, 1)
                             ^    
   drivers/staging/comedi/drivers/dac02.c:67:26: note: (near initialization for 'das02_ao_ranges.range[4].max')
   drivers/staging/comedi/drivers/dac02.c:61:5: warning: missing braces around initializer [-Wmissing-braces]
     6, {
        ^
   drivers/staging/comedi/drivers/dac02.c:61:5: note: (near initialization for 'das02_ao_ranges.range')
   drivers/staging/comedi/drivers/dac02.c:60:53: warning: missing braces around initializer [-Wmissing-braces]
    static const struct comedi_lrange das02_ao_ranges = {
                                                        ^
   drivers/staging/comedi/drivers/dac02.c:60:53: note: (near initialization for 'das02_ao_ranges')
   cc1: some warnings being treated as errors

vim +67 drivers/staging/comedi/drivers/dac02.c

99999e27 H Hartley Sweeten 2014-03-11  60  static const struct comedi_lrange das02_ao_ranges = {
99999e27 H Hartley Sweeten 2014-03-11  61  	6, {
99999e27 H Hartley Sweeten 2014-03-11  62  		UNI_RANGE(5),
99999e27 H Hartley Sweeten 2014-03-11  63  		UNI_RANGE(10),
99999e27 H Hartley Sweeten 2014-03-11  64  		BIP_RANGE(5),
99999e27 H Hartley Sweeten 2014-03-11  65  		BIP_RANGE(10),
99999e27 H Hartley Sweeten 2014-03-11 @66  		RANGE_mA(4, 20),
99999e27 H Hartley Sweeten 2014-03-11 @67  		RANGE_ext(0, 1)
99999e27 H Hartley Sweeten 2014-03-11  68  	}
99999e27 H Hartley Sweeten 2014-03-11  69  };
99999e27 H Hartley Sweeten 2014-03-11  70  

:::::: The code at line 67 was first introduced by commit
:::::: 99999e27475c9cbed2d59ac33f1d6f21bf9e260d staging: comedi: dac02: introduce comedi driver for DAC02 boards

:::::: TO: H Hartley Sweeten <hartleys@visionengravers.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 55146 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04  9:00 [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Amit Ghadge
  2016-09-04  9:02 ` Amit Ghadge
  2016-09-04 11:08 ` kbuild test robot
@ 2016-09-04 11:29 ` kbuild test robot
  2016-09-04 11:49 ` kbuild test robot
  2016-09-04 22:31 ` kbuild test robot
  4 siblings, 0 replies; 11+ messages in thread
From: kbuild test robot @ 2016-09-04 11:29 UTC (permalink / raw)
  To: Amit Ghadge; +Cc: kbuild-all, abbotti, devel, gregkh, Amit Ghadge, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3831 bytes --]

Hi Amit,

[auto build test WARNING on v4.8-rc4]
[cannot apply to staging/staging-testing next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
config: i386-randconfig-i0-201636 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
      RANGE_mA(0, 20),
      ^
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: warning: missing braces around initializer [-Wmissing-braces]
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: warning: (near initialization for 'adv_pci1724_ao_ranges.range[1]') [-Wmissing-braces]
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: initializer element is not constant
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: (near initialization for 'adv_pci1724_ao_ranges.range[1].min')
   drivers/staging/comedi/drivers/adv_pci1724.c:77:3: error: initializer element is not constant
      RANGE_mA(4, 20),
      ^
   drivers/staging/comedi/drivers/adv_pci1724.c:77:3: error: (near initialization for 'adv_pci1724_ao_ranges.range[1].max')
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: braces around scalar initializer [enabled by default]
      RANGE_unitless(0, 1)
      ^
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags') [enabled by default]
>> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: excess elements in scalar initializer [enabled by default]
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags') [enabled by default]
>> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: excess elements in scalar initializer [enabled by default]
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags') [enabled by default]
   cc1: some warnings being treated as errors

vim +78 drivers/staging/comedi/drivers/adv_pci1724.c

c2edc021 H Hartley Sweeten 2014-11-20  70  #define PCI1724_BOARD_ID_REG		0x10
70adf763 H Hartley Sweeten 2014-11-20  71  #define PCI1724_BOARD_ID_MASK		(0xf << 0)
f165d815 Frank Mori Hess   2013-03-12  72  
474bfe5f H Hartley Sweeten 2014-11-20  73  static const struct comedi_lrange adv_pci1724_ao_ranges = {
348dc03e H Hartley Sweeten 2013-12-09  74  	4, {
f165d815 Frank Mori Hess   2013-03-12  75  		BIP_RANGE(10),
f165d815 Frank Mori Hess   2013-03-12 @76  		RANGE_mA(0, 20),
f165d815 Frank Mori Hess   2013-03-12  77  		RANGE_mA(4, 20),
f165d815 Frank Mori Hess   2013-03-12 @78  		RANGE_unitless(0, 1)
f165d815 Frank Mori Hess   2013-03-12  79  	}
f165d815 Frank Mori Hess   2013-03-12  80  };
f165d815 Frank Mori Hess   2013-03-12  81  

:::::: The code at line 78 was first introduced by commit
:::::: f165d815d50f158be43aa12c5c800fd27bbecad3 staging: comedi: adv_pci1724: new driver

:::::: TO: Frank Mori Hess <fmh6jj@gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 30544 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04  9:00 [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Amit Ghadge
                   ` (2 preceding siblings ...)
  2016-09-04 11:29 ` kbuild test robot
@ 2016-09-04 11:49 ` kbuild test robot
  2016-09-04 12:22   ` Amit Ghadge
  2016-09-04 22:31 ` kbuild test robot
  4 siblings, 1 reply; 11+ messages in thread
From: kbuild test robot @ 2016-09-04 11:49 UTC (permalink / raw)
  To: Amit Ghadge; +Cc: kbuild-all, abbotti, devel, gregkh, Amit Ghadge, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 11536 bytes --]

Hi Amit,

[auto build test ERROR on v4.8-rc4]
[cannot apply to staging/staging-testing next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

>> drivers/staging/comedi/range.c:35:49: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
    const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
                                                    ^~~~~~~~
>> drivers/staging/comedi/range.c:35:49: error: initializer element is not constant
   drivers/staging/comedi/range.c:35:49: note: (near initialization for 'range_0_20mA.range[0].min')
   drivers/staging/comedi/range.c:37:49: error: initializer element is not constant
    const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
                                                    ^~~~~~~~
   drivers/staging/comedi/range.c:37:49: note: (near initialization for 'range_4_20mA.range[0].min')
   drivers/staging/comedi/range.c:39:49: error: initializer element is not constant
    const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
                                                    ^~~~~~~~
   drivers/staging/comedi/range.c:39:49: note: (near initialization for 'range_0_32mA.range[0].min')
   cc1: some warnings being treated as errors
--
>> drivers/staging/comedi/drivers/pcl726.c:82:3: error: 'range_4_20mA' undeclared here (not in a function)
     &range_4_20mA,
      ^~~~~~~~~~~~
>> drivers/staging/comedi/drivers/pcl726.c:90:2: error: initializer element is not constant
     &range_4_20mA
     ^
   drivers/staging/comedi/drivers/pcl726.c:90:2: note: (near initialization for 'rangelist_727[3]')
   drivers/staging/comedi/drivers/pcl726.c:98:2: error: initializer element is not constant
     &range_4_20mA,
     ^
   drivers/staging/comedi/drivers/pcl726.c:98:2: note: (near initialization for 'rangelist_728[4]')
>> drivers/staging/comedi/drivers/pcl726.c:99:3: error: 'range_0_20mA' undeclared here (not in a function)
     &range_0_20mA
      ^~~~~~~~~~~~
   drivers/staging/comedi/drivers/pcl726.c:99:2: error: initializer element is not constant
     &range_0_20mA
     ^
   drivers/staging/comedi/drivers/pcl726.c:99:2: note: (near initialization for 'rangelist_728[5]')
--
>> drivers/staging/comedi/drivers/dac02.c:66:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
      RANGE_mA(4, 20),
      ^~~~~~~~
>> drivers/staging/comedi/drivers/dac02.c:66:3: error: initializer element is not constant
   drivers/staging/comedi/drivers/dac02.c:66:3: note: (near initialization for 'das02_ao_ranges.range[4].min')
>> drivers/staging/comedi/drivers/dac02.c:67:3: warning: braces around scalar initializer
      RANGE_ext(0, 1)
      ^~~~~~~~~
   drivers/staging/comedi/drivers/dac02.c:67:3: note: (near initialization for 'das02_ao_ranges.range[4].max')
   In file included from drivers/staging/comedi/drivers/dac02.c:38:0:
>> drivers/staging/comedi/drivers/../comedidev.h:584:38: warning: excess elements in scalar initializer
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                         ^
>> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:584:38: note: (near initialization for 'das02_ao_ranges.range[4].max')
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                         ^
>> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
   In file included from drivers/staging/comedi/drivers/../comedidev.h:28:0,
                    from drivers/staging/comedi/drivers/dac02.c:38:
>> drivers/staging/comedi/drivers/../comedi.h:897:22: warning: excess elements in scalar initializer
    #define RF_EXTERNAL  0x100
                         ^
>> drivers/staging/comedi/drivers/../comedidev.h:584:49: note: in expansion of macro 'RF_EXTERNAL'
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                                    ^~~~~~~~~~~
>> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
   drivers/staging/comedi/drivers/../comedi.h:897:22: note: (near initialization for 'das02_ao_ranges.range[4].max')
    #define RF_EXTERNAL  0x100
                         ^
>> drivers/staging/comedi/drivers/../comedidev.h:584:49: note: in expansion of macro 'RF_EXTERNAL'
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                                    ^~~~~~~~~~~
>> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
>> drivers/staging/comedi/drivers/dac02.c:61:5: warning: missing braces around initializer [-Wmissing-braces]
     6, {
        ^
   drivers/staging/comedi/drivers/dac02.c:61:5: note: (near initialization for 'das02_ao_ranges.range')
   drivers/staging/comedi/drivers/dac02.c:60:53: warning: missing braces around initializer [-Wmissing-braces]
    static const struct comedi_lrange das02_ao_ranges = {
                                                        ^
   drivers/staging/comedi/drivers/dac02.c:60:53: note: (near initialization for 'das02_ao_ranges')
   cc1: some warnings being treated as errors
--
   drivers/staging/comedi/drivers/dt2815.c: In function 'dt2815_attach':
>> drivers/staging/comedi/drivers/dt2815.c:177:9: error: 'range_4_20mA' undeclared (first use in this function)
         ? &range_4_20mA : &range_0_32mA;
            ^~~~~~~~~~~~
   drivers/staging/comedi/drivers/dt2815.c:177:9: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/staging/comedi/drivers/dt2815.c:177:25: error: 'range_0_32mA' undeclared (first use in this function)
         ? &range_4_20mA : &range_0_32mA;
                            ^~~~~~~~~~~~
--
>> drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
      RANGE_mA(0, 20),
      ^~~~~~~~
>> drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: initializer element is not constant
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].min')
   drivers/staging/comedi/drivers/adv_pci1724.c:77:3: error: initializer element is not constant
      RANGE_mA(4, 20),
      ^~~~~~~~
   drivers/staging/comedi/drivers/adv_pci1724.c:77:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].max')
>> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: braces around scalar initializer
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
   In file included from drivers/staging/comedi/drivers/../comedi_pci.h:24:0,
                    from drivers/staging/comedi/drivers/adv_pci1724.c:51:
   drivers/staging/comedi/drivers/../comedidev.h:586:42: warning: excess elements in scalar initializer
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                             ^
>> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:586:42: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                             ^
>> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:586:53: warning: excess elements in scalar initializer
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                                        ^
>> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:586:53: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                                        ^
>> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
>> drivers/staging/comedi/drivers/adv_pci1724.c:73:59: warning: missing braces around initializer [-Wmissing-braces]
    static const struct comedi_lrange adv_pci1724_ao_ranges = {
                                                              ^
   drivers/staging/comedi/drivers/adv_pci1724.c:73:59: note: (near initialization for 'adv_pci1724_ao_ranges')
   cc1: some warnings being treated as errors
--
   drivers/staging/comedi/drivers/ni_670x.c: In function 'ni_670x_auto_attach':
>> drivers/staging/comedi/drivers/ni_670x.c:225:32: error: 'range_0_20mA' undeclared (first use in this function)
       range_table_list[16 + i] = &range_0_20mA;
                                   ^~~~~~~~~~~~
   drivers/staging/comedi/drivers/ni_670x.c:225:32: note: each undeclared identifier is reported only once for each function it appears in

vim +/RANGE_mA +35 drivers/staging/comedi/range.c

f0f29184 Mark Rankilor     2010-05-03  29  const struct comedi_lrange range_unipolar10 = { 1, {UNI_RANGE(10)} };
5660e742 H Hartley Sweeten 2013-04-12  30  EXPORT_SYMBOL_GPL(range_unipolar10);
f0f29184 Mark Rankilor     2010-05-03  31  const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
5660e742 H Hartley Sweeten 2013-04-12  32  EXPORT_SYMBOL_GPL(range_unipolar5);
5f8eb72c H Hartley Sweeten 2013-04-03  33  const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
5660e742 H Hartley Sweeten 2013-04-12  34  EXPORT_SYMBOL_GPL(range_unipolar2_5);
2c71c4ff H Hartley Sweeten 2013-04-03 @35  const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
5660e742 H Hartley Sweeten 2013-04-12  36  EXPORT_SYMBOL_GPL(range_0_20mA);
2c71c4ff H Hartley Sweeten 2013-04-03  37  const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
5660e742 H Hartley Sweeten 2013-04-12  38  EXPORT_SYMBOL_GPL(range_4_20mA);

:::::: The code at line 35 was first introduced by commit
:::::: 2c71c4ff57a6564097bedd45bc589f73da798a3a staging: comedi: range: introduce some simple mA ranges

:::::: TO: H Hartley Sweeten <hsweeten@visionengravers.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 55851 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04 11:49 ` kbuild test robot
@ 2016-09-04 12:22   ` Amit Ghadge
  0 siblings, 0 replies; 11+ messages in thread
From: Amit Ghadge @ 2016-09-04 12:22 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, Ian Abbott, devel, Greg KH, linux-kernel

On Sep 4, 2016 5:19 PM, "kbuild test robot" <lkp@intel.com> wrote:
>
> Hi Amit,
>
> [auto build test ERROR on v4.8-rc4]
> [cannot apply to staging/staging-testing next-20160825]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
>
> url:    https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All error/warnings (new ones prefixed by >>):
>
> >> drivers/staging/comedi/range.c:35:49: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
>     const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
>                                                     ^~~~~~~~
> >> drivers/staging/comedi/range.c:35:49: error: initializer element is not constant
>    drivers/staging/comedi/range.c:35:49: note: (near initialization for 'range_0_20mA.range[0].min')
>    drivers/staging/comedi/range.c:37:49: error: initializer element is not constant
>     const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
>                                                     ^~~~~~~~
>    drivers/staging/comedi/range.c:37:49: note: (near initialization for 'range_4_20mA.range[0].min')
>    drivers/staging/comedi/range.c:39:49: error: initializer element is not constant
>     const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
>                                                     ^~~~~~~~
>    drivers/staging/comedi/range.c:39:49: note: (near initialization for 'range_0_32mA.range[0].min')
>    cc1: some warnings being treated as errors
> --
> >> drivers/staging/comedi/drivers/pcl726.c:82:3: error: 'range_4_20mA' undeclared here (not in a function)
>      &range_4_20mA,
>       ^~~~~~~~~~~~
> >> drivers/staging/comedi/drivers/pcl726.c:90:2: error: initializer element is not constant
>      &range_4_20mA
>      ^
>    drivers/staging/comedi/drivers/pcl726.c:90:2: note: (near initialization for 'rangelist_727[3]')
>    drivers/staging/comedi/drivers/pcl726.c:98:2: error: initializer element is not constant
>      &range_4_20mA,
>      ^
>    drivers/staging/comedi/drivers/pcl726.c:98:2: note: (near initialization for 'rangelist_728[4]')
> >> drivers/staging/comedi/drivers/pcl726.c:99:3: error: 'range_0_20mA' undeclared here (not in a function)
>      &range_0_20mA
>       ^~~~~~~~~~~~
>    drivers/staging/comedi/drivers/pcl726.c:99:2: error: initializer element is not constant
>      &range_0_20mA
>      ^
>    drivers/staging/comedi/drivers/pcl726.c:99:2: note: (near initialization for 'rangelist_728[5]')
> --
> >> drivers/staging/comedi/drivers/dac02.c:66:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
>       RANGE_mA(4, 20),
>       ^~~~~~~~
> >> drivers/staging/comedi/drivers/dac02.c:66:3: error: initializer element is not constant
>    drivers/staging/comedi/drivers/dac02.c:66:3: note: (near initialization for 'das02_ao_ranges.range[4].min')
> >> drivers/staging/comedi/drivers/dac02.c:67:3: warning: braces around scalar initializer
>       RANGE_ext(0, 1)
>       ^~~~~~~~~
>    drivers/staging/comedi/drivers/dac02.c:67:3: note: (near initialization for 'das02_ao_ranges.range[4].max')
>    In file included from drivers/staging/comedi/drivers/dac02.c:38:0:
> >> drivers/staging/comedi/drivers/../comedidev.h:584:38: warning: excess elements in scalar initializer
>     #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
>                                          ^
> >> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
>       RANGE_ext(0, 1)
>       ^~~~~~~~~
>    drivers/staging/comedi/drivers/../comedidev.h:584:38: note: (near initialization for 'das02_ao_ranges.range[4].max')
>     #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
>                                          ^
> >> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
>       RANGE_ext(0, 1)
>       ^~~~~~~~~
>    In file included from drivers/staging/comedi/drivers/../comedidev.h:28:0,
>                     from drivers/staging/comedi/drivers/dac02.c:38:
> >> drivers/staging/comedi/drivers/../comedi.h:897:22: warning: excess elements in scalar initializer
>     #define RF_EXTERNAL  0x100
>                          ^
> >> drivers/staging/comedi/drivers/../comedidev.h:584:49: note: in expansion of macro 'RF_EXTERNAL'
>     #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
>                                                     ^~~~~~~~~~~
> >> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
>       RANGE_ext(0, 1)
>       ^~~~~~~~~
>    drivers/staging/comedi/drivers/../comedi.h:897:22: note: (near initialization for 'das02_ao_ranges.range[4].max')
>     #define RF_EXTERNAL  0x100
>                          ^
> >> drivers/staging/comedi/drivers/../comedidev.h:584:49: note: in expansion of macro 'RF_EXTERNAL'
>     #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
>                                                     ^~~~~~~~~~~
> >> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
>       RANGE_ext(0, 1)
>       ^~~~~~~~~
> >> drivers/staging/comedi/drivers/dac02.c:61:5: warning: missing braces around initializer [-Wmissing-braces]
>      6, {
>         ^
>    drivers/staging/comedi/drivers/dac02.c:61:5: note: (near initialization for 'das02_ao_ranges.range')
>    drivers/staging/comedi/drivers/dac02.c:60:53: warning: missing braces around initializer [-Wmissing-braces]
>     static const struct comedi_lrange das02_ao_ranges = {
>                                                         ^
>    drivers/staging/comedi/drivers/dac02.c:60:53: note: (near initialization for 'das02_ao_ranges')
>    cc1: some warnings being treated as errors
> --
>    drivers/staging/comedi/drivers/dt2815.c: In function 'dt2815_attach':
> >> drivers/staging/comedi/drivers/dt2815.c:177:9: error: 'range_4_20mA' undeclared (first use in this function)
>          ? &range_4_20mA : &range_0_32mA;
>             ^~~~~~~~~~~~
>    drivers/staging/comedi/drivers/dt2815.c:177:9: note: each undeclared identifier is reported only once for each function it appears in
> >> drivers/staging/comedi/drivers/dt2815.c:177:25: error: 'range_0_32mA' undeclared (first use in this function)
>          ? &range_4_20mA : &range_0_32mA;
>                             ^~~~~~~~~~~~
> --
> >> drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
>       RANGE_mA(0, 20),
>       ^~~~~~~~
> >> drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: initializer element is not constant
>    drivers/staging/comedi/drivers/adv_pci1724.c:76:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].min')
>    drivers/staging/comedi/drivers/adv_pci1724.c:77:3: error: initializer element is not constant
>       RANGE_mA(4, 20),
>       ^~~~~~~~
>    drivers/staging/comedi/drivers/adv_pci1724.c:77:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].max')
> >> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: braces around scalar initializer
>       RANGE_unitless(0, 1)
>       ^~~~~~~~~~~~~~
>    drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
>    In file included from drivers/staging/comedi/drivers/../comedi_pci.h:24:0,
>                     from drivers/staging/comedi/drivers/adv_pci1724.c:51:
>    drivers/staging/comedi/drivers/../comedidev.h:586:42: warning: excess elements in scalar initializer
>     #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
>                                              ^
> >> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
>       RANGE_unitless(0, 1)
>       ^~~~~~~~~~~~~~
>    drivers/staging/comedi/drivers/../comedidev.h:586:42: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
>     #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
>                                              ^
> >> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
>       RANGE_unitless(0, 1)
>       ^~~~~~~~~~~~~~
>    drivers/staging/comedi/drivers/../comedidev.h:586:53: warning: excess elements in scalar initializer
>     #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
>                                                         ^
> >> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
>       RANGE_unitless(0, 1)
>       ^~~~~~~~~~~~~~
>    drivers/staging/comedi/drivers/../comedidev.h:586:53: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
>     #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
>                                                         ^
> >> drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
>       RANGE_unitless(0, 1)
>       ^~~~~~~~~~~~~~
> >> drivers/staging/comedi/drivers/adv_pci1724.c:73:59: warning: missing braces around initializer [-Wmissing-braces]
>     static const struct comedi_lrange adv_pci1724_ao_ranges = {
>                                                               ^
>    drivers/staging/comedi/drivers/adv_pci1724.c:73:59: note: (near initialization for 'adv_pci1724_ao_ranges')
>    cc1: some warnings being treated as errors
> --
>    drivers/staging/comedi/drivers/ni_670x.c: In function 'ni_670x_auto_attach':
> >> drivers/staging/comedi/drivers/ni_670x.c:225:32: error: 'range_0_20mA' undeclared (first use in this function)
>        range_table_list[16 + i] = &range_0_20mA;
>                                    ^~~~~~~~~~~~
>    drivers/staging/comedi/drivers/ni_670x.c:225:32: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +/RANGE_mA +35 drivers/staging/comedi/range.c
>
> f0f29184 Mark Rankilor     2010-05-03  29  const struct comedi_lrange range_unipolar10 = { 1, {UNI_RANGE(10)} };
> 5660e742 H Hartley Sweeten 2013-04-12  30  EXPORT_SYMBOL_GPL(range_unipolar10);
> f0f29184 Mark Rankilor     2010-05-03  31  const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
> 5660e742 H Hartley Sweeten 2013-04-12  32  EXPORT_SYMBOL_GPL(range_unipolar5);
> 5f8eb72c H Hartley Sweeten 2013-04-03  33  const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
> 5660e742 H Hartley Sweeten 2013-04-12  34  EXPORT_SYMBOL_GPL(range_unipolar2_5);
> 2c71c4ff H Hartley Sweeten 2013-04-03 @35  const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
> 5660e742 H Hartley Sweeten 2013-04-12  36  EXPORT_SYMBOL_GPL(range_0_20mA);
> 2c71c4ff H Hartley Sweeten 2013-04-03  37  const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
> 5660e742 H Hartley Sweeten 2013-04-12  38  EXPORT_SYMBOL_GPL(range_4_20mA);
>
> :::::: The code at line 35 was first introduced by commit
> :::::: 2c71c4ff57a6564097bedd45bc589f73da798a3a staging: comedi: range: introduce some simple mA ranges
>
> :::::: TO: H Hartley Sweeten <hsweeten@visionengravers.com>
> :::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


Please ignore this patch.

Amit G

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04  9:00 [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Amit Ghadge
                   ` (3 preceding siblings ...)
  2016-09-04 11:49 ` kbuild test robot
@ 2016-09-04 22:31 ` kbuild test robot
  4 siblings, 0 replies; 11+ messages in thread
From: kbuild test robot @ 2016-09-04 22:31 UTC (permalink / raw)
  To: Amit Ghadge; +Cc: kbuild-all, abbotti, devel, gregkh, Amit Ghadge, linux-kernel

Hi Amit,

[auto build test WARNING on v4.8-rc4]
[cannot apply to staging/staging-testing next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   include/linux/compiler.h:230:8: sparse: attribute 'no_sanitize_address': unknown attribute
   drivers/staging/comedi/range.c:35:49: sparse: undefined identifier 'RANGE_mA'
>> drivers/staging/comedi/range.c:35:57: sparse: not a function <noident>
   drivers/staging/comedi/range.c:37:49: sparse: undefined identifier 'RANGE_mA'
   drivers/staging/comedi/range.c:37:57: sparse: not a function <noident>
   drivers/staging/comedi/range.c:39:49: sparse: undefined identifier 'RANGE_mA'
   drivers/staging/comedi/range.c:39:57: sparse: not a function <noident>
   drivers/staging/comedi/range.c:35:49: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
    const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
                                                    ^~~~~~~~
   drivers/staging/comedi/range.c:35:49: error: initializer element is not constant
   drivers/staging/comedi/range.c:35:49: note: (near initialization for 'range_0_20mA.range[0].min')
   drivers/staging/comedi/range.c:37:49: error: initializer element is not constant
    const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
                                                    ^~~~~~~~
   drivers/staging/comedi/range.c:37:49: note: (near initialization for 'range_4_20mA.range[0].min')
   drivers/staging/comedi/range.c:39:49: error: initializer element is not constant
    const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
                                                    ^~~~~~~~
   drivers/staging/comedi/range.c:39:49: note: (near initialization for 'range_0_32mA.range[0].min')
   cc1: some warnings being treated as errors
--
   include/linux/compiler.h:230:8: sparse: attribute 'no_sanitize_address': unknown attribute
   drivers/staging/comedi/drivers/dac02.c:66:17: sparse: undefined identifier 'RANGE_mA'
>> drivers/staging/comedi/drivers/dac02.c:66:25: sparse: not a function <noident>
   drivers/staging/comedi/drivers/dac02.c:66:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
      RANGE_mA(4, 20),
      ^~~~~~~~
   drivers/staging/comedi/drivers/dac02.c:66:3: error: initializer element is not constant
   drivers/staging/comedi/drivers/dac02.c:66:3: note: (near initialization for 'das02_ao_ranges.range[4].min')
   drivers/staging/comedi/drivers/dac02.c:67:3: warning: braces around scalar initializer
      RANGE_ext(0, 1)
      ^~~~~~~~~
   drivers/staging/comedi/drivers/dac02.c:67:3: note: (near initialization for 'das02_ao_ranges.range[4].max')
   In file included from drivers/staging/comedi/drivers/dac02.c:38:0:
   drivers/staging/comedi/drivers/../comedidev.h:584:38: warning: excess elements in scalar initializer
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                         ^
   drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:584:38: note: (near initialization for 'das02_ao_ranges.range[4].max')
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                         ^
   drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
   In file included from drivers/staging/comedi/drivers/../comedidev.h:28:0,
                    from drivers/staging/comedi/drivers/dac02.c:38:
   drivers/staging/comedi/drivers/../comedi.h:897:22: warning: excess elements in scalar initializer
    #define RF_EXTERNAL  0x100
                         ^
   drivers/staging/comedi/drivers/../comedidev.h:584:49: note: in expansion of macro 'RF_EXTERNAL'
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                                    ^~~~~~~~~~~
   drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
   drivers/staging/comedi/drivers/../comedi.h:897:22: note: (near initialization for 'das02_ao_ranges.range[4].max')
    #define RF_EXTERNAL  0x100
                         ^
   drivers/staging/comedi/drivers/../comedidev.h:584:49: note: in expansion of macro 'RF_EXTERNAL'
    #define RANGE_ext(a, b)  {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
                                                    ^~~~~~~~~~~
   drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro 'RANGE_ext'
      RANGE_ext(0, 1)
      ^~~~~~~~~
   drivers/staging/comedi/drivers/dac02.c:61:5: warning: missing braces around initializer [-Wmissing-braces]
     6, {
        ^
   drivers/staging/comedi/drivers/dac02.c:61:5: note: (near initialization for 'das02_ao_ranges.range')
   drivers/staging/comedi/drivers/dac02.c:60:53: warning: missing braces around initializer [-Wmissing-braces]
    static const struct comedi_lrange das02_ao_ranges = {
                                                        ^
   drivers/staging/comedi/drivers/dac02.c:60:53: note: (near initialization for 'das02_ao_ranges')
   cc1: some warnings being treated as errors
--
   include/linux/compiler.h:230:8: sparse: attribute 'no_sanitize_address': unknown attribute
   drivers/staging/comedi/drivers/adv_pci1724.c:76:17: sparse: undefined identifier 'RANGE_mA'
>> drivers/staging/comedi/drivers/adv_pci1724.c:76:25: sparse: not a function <noident>
   drivers/staging/comedi/drivers/adv_pci1724.c:77:17: sparse: undefined identifier 'RANGE_mA'
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: implicit declaration of function 'RANGE_mA' [-Werror=implicit-function-declaration]
      RANGE_mA(0, 20),
      ^~~~~~~~
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: error: initializer element is not constant
   drivers/staging/comedi/drivers/adv_pci1724.c:76:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].min')
   drivers/staging/comedi/drivers/adv_pci1724.c:77:3: error: initializer element is not constant
      RANGE_mA(4, 20),
      ^~~~~~~~
   drivers/staging/comedi/drivers/adv_pci1724.c:77:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].max')
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: warning: braces around scalar initializer
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
   In file included from drivers/staging/comedi/drivers/../comedi_pci.h:24:0,
                    from drivers/staging/comedi/drivers/adv_pci1724.c:51:
   drivers/staging/comedi/drivers/../comedidev.h:586:42: warning: excess elements in scalar initializer
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                             ^
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:586:42: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                             ^
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:586:53: warning: excess elements in scalar initializer
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                                        ^
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/../comedidev.h:586:53: note: (near initialization for 'adv_pci1724_ao_ranges.range[1].flags')
    #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
                                                        ^
   drivers/staging/comedi/drivers/adv_pci1724.c:78:3: note: in expansion of macro 'RANGE_unitless'
      RANGE_unitless(0, 1)
      ^~~~~~~~~~~~~~
   drivers/staging/comedi/drivers/adv_pci1724.c:73:59: warning: missing braces around initializer [-Wmissing-braces]
    static const struct comedi_lrange adv_pci1724_ao_ranges = {
                                                              ^
   drivers/staging/comedi/drivers/adv_pci1724.c:73:59: note: (near initialization for 'adv_pci1724_ao_ranges')
   cc1: some warnings being treated as errors

vim +35 drivers/staging/comedi/range.c

ecfe20db Greg Kroah-Hartman 2010-04-30  19  #include <linux/uaccess.h>
3b6b25b5 Greg Kroah-Hartman 2010-05-03  20  #include "comedidev.h"
3a5fa275 Ian Abbott         2012-06-19  21  #include "comedi_internal.h"
ed9eccbe David Schleef      2008-11-04  22  
9ced1de6 Bill Pemberton     2009-03-16  23  const struct comedi_lrange range_bipolar10 = { 1, {BIP_RANGE(10)} };
5660e742 H Hartley Sweeten  2013-04-12  24  EXPORT_SYMBOL_GPL(range_bipolar10);
f0f29184 Mark Rankilor      2010-05-03  25  const struct comedi_lrange range_bipolar5 = { 1, {BIP_RANGE(5)} };
5660e742 H Hartley Sweeten  2013-04-12  26  EXPORT_SYMBOL_GPL(range_bipolar5);
f0f29184 Mark Rankilor      2010-05-03  27  const struct comedi_lrange range_bipolar2_5 = { 1, {BIP_RANGE(2.5)} };
5660e742 H Hartley Sweeten  2013-04-12  28  EXPORT_SYMBOL_GPL(range_bipolar2_5);
f0f29184 Mark Rankilor      2010-05-03  29  const struct comedi_lrange range_unipolar10 = { 1, {UNI_RANGE(10)} };
5660e742 H Hartley Sweeten  2013-04-12  30  EXPORT_SYMBOL_GPL(range_unipolar10);
f0f29184 Mark Rankilor      2010-05-03  31  const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
5660e742 H Hartley Sweeten  2013-04-12  32  EXPORT_SYMBOL_GPL(range_unipolar5);
5f8eb72c H Hartley Sweeten  2013-04-03  33  const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
5660e742 H Hartley Sweeten  2013-04-12  34  EXPORT_SYMBOL_GPL(range_unipolar2_5);
2c71c4ff H Hartley Sweeten  2013-04-03 @35  const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
5660e742 H Hartley Sweeten  2013-04-12  36  EXPORT_SYMBOL_GPL(range_0_20mA);
2c71c4ff H Hartley Sweeten  2013-04-03  37  const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
5660e742 H Hartley Sweeten  2013-04-12  38  EXPORT_SYMBOL_GPL(range_4_20mA);
2c71c4ff H Hartley Sweeten  2013-04-03  39  const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
5660e742 H Hartley Sweeten  2013-04-12  40  EXPORT_SYMBOL_GPL(range_0_32mA);
f0f29184 Mark Rankilor      2010-05-03  41  const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_none} } };
5660e742 H Hartley Sweeten  2013-04-12  42  EXPORT_SYMBOL_GPL(range_unknown);
ed9eccbe David Schleef      2008-11-04  43  

:::::: The code at line 35 was first introduced by commit
:::::: 2c71c4ff57a6564097bedd45bc589f73da798a3a staging: comedi: range: introduce some simple mA ranges

:::::: TO: H Hartley Sweeten <hsweeten@visionengravers.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04  9:42 ` Giedrius Statkevičius
@ 2016-09-04  9:58   ` Amit Ghadge
  0 siblings, 0 replies; 11+ messages in thread
From: Amit Ghadge @ 2016-09-04  9:58 UTC (permalink / raw)
  To: Giedrius Statkevičius
  Cc: Ian Abbott, devel, Greg Kroah-Hartman, linux-kernel

On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius
<giedrius.statkevicius@gmail.com> wrote:
> On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge <amitg.b14@gmail.com> wrote:
>> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
>> ---
> [...]
>
> Why are you sending so many copies of the same patch?

Accidentally I used same git branch and try to send multiple patches
but other patch has some issue, So I have exclude the other patch.


Amit

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
  2016-09-04  9:08 Amit Ghadge
@ 2016-09-04  9:42 ` Giedrius Statkevičius
  2016-09-04  9:58   ` Amit Ghadge
  0 siblings, 1 reply; 11+ messages in thread
From: Giedrius Statkevičius @ 2016-09-04  9:42 UTC (permalink / raw)
  To: Amit Ghadge; +Cc: abbotti, devel, Greg Kroah-Hartman, linux-kernel

On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge <amitg.b14@gmail.com> wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
[...]

Why are you sending so many copies of the same patch?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
@ 2016-09-04  9:08 Amit Ghadge
  2016-09-04  9:42 ` Giedrius Statkevičius
  0 siblings, 1 reply; 11+ messages in thread
From: Amit Ghadge @ 2016-09-04  9:08 UTC (permalink / raw)
  To: abbotti; +Cc: gregkh, linux-kernel, devel, Amit Ghadge

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines

Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
---
 drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +++++++++++++--------------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index d9de83a..ff3716c 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -1,35 +1,35 @@
 /*
-    comedi/drivers/ni_daq_dio24.c
-    Driver for National Instruments PCMCIA DAQ-Card DIO-24
-    Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
+ * comedi/drivers/ni_daq_dio24.c
+ * Driver for National Instruments PCMCIA DAQ-Card DIO-24
+ * Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
 
-    PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
-    2001/08/24 12:13:13 from the pcmcia package.
-    The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
-    <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
-    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
+ * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
+ * 2001/08/24 12:13:13 from the pcmcia package.
+ * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
+ * <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
+ * are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
 
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-*/
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 /*
-Driver: ni_daq_dio24
-Description: National Instruments PCMCIA DAQ-Card DIO-24
-Author: Daniel Vecino Castel <dvecino@able.es>
-Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
-Status: ?
-Updated: Thu, 07 Nov 2002 21:53:06 -0800
+ * Driver: ni_daq_dio24
+ * Description: National Instruments PCMCIA DAQ-Card DIO-24
+ * Author: Daniel Vecino Castel <dvecino@able.es>
+ * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
+ * Status: ?
+ * Updated: Thu, 07 Nov 2002 21:53:06 -0800
 
-This is just a wrapper around the 8255.o driver to properly handle
-the PCMCIA interface.
-*/
+ * This is just a wrapper around the 8255.o driver to properly handle
+ * the PCMCIA interface.
+ */
 
 #include <linux/module.h>
 #include "../comedi_pcmcia.h"
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
@ 2016-09-03 19:25 Amit Ghadge
  0 siblings, 0 replies; 11+ messages in thread
From: Amit Ghadge @ 2016-09-03 19:25 UTC (permalink / raw)
  To: abbotti; +Cc: hsweeten, gregkh, devel, linux-kernel, Amit Ghadge

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:

WARNING: Block comments use * on subsequent lines

Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
---
 drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +++++++++++++--------------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index d9de83a..ff3716c 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -1,35 +1,35 @@
 /*
-    comedi/drivers/ni_daq_dio24.c
-    Driver for National Instruments PCMCIA DAQ-Card DIO-24
-    Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
+ * comedi/drivers/ni_daq_dio24.c
+ * Driver for National Instruments PCMCIA DAQ-Card DIO-24
+ * Copyright (C) 2002 Daniel Vecino Castel <dvecino@able.es>
 
-    PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
-    2001/08/24 12:13:13 from the pcmcia package.
-    The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
-    <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
-    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
+ * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
+ * 2001/08/24 12:13:13 from the pcmcia package.
+ * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
+ * <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
+ * are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
 
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-*/
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 /*
-Driver: ni_daq_dio24
-Description: National Instruments PCMCIA DAQ-Card DIO-24
-Author: Daniel Vecino Castel <dvecino@able.es>
-Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
-Status: ?
-Updated: Thu, 07 Nov 2002 21:53:06 -0800
+ * Driver: ni_daq_dio24
+ * Description: National Instruments PCMCIA DAQ-Card DIO-24
+ * Author: Daniel Vecino Castel <dvecino@able.es>
+ * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
+ * Status: ?
+ * Updated: Thu, 07 Nov 2002 21:53:06 -0800
 
-This is just a wrapper around the 8255.o driver to properly handle
-the PCMCIA interface.
-*/
+ * This is just a wrapper around the 8255.o driver to properly handle
+ * the PCMCIA interface.
+ */
 
 #include <linux/module.h>
 #include "../comedi_pcmcia.h"
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2016-09-04 14:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-04  9:00 [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Amit Ghadge
2016-09-04  9:02 ` Amit Ghadge
2016-09-04 11:08 ` kbuild test robot
2016-09-04 11:29 ` kbuild test robot
2016-09-04 11:49 ` kbuild test robot
2016-09-04 12:22   ` Amit Ghadge
2016-09-04 22:31 ` kbuild test robot
  -- strict thread matches above, loose matches on Subject: below --
2016-09-04  9:08 Amit Ghadge
2016-09-04  9:42 ` Giedrius Statkevičius
2016-09-04  9:58   ` Amit Ghadge
2016-09-03 19:25 Amit Ghadge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).