From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Marek Vasut <marex@denx.de>, netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx
Date: Mon, 23 Mar 2020 08:20:50 -0600 [thread overview]
Message-ID: <CAL_Jsq+KHfW0LtzJQFjB7HTWFBGf_9fe79nKBSe-g5npRYfZ6A@mail.gmail.com> (raw)
In-Reply-To: <a1968447-5dd9-e309-6a3e-48ed05c2ab93@gmail.com>
On Sun, Mar 22, 2020 at 3:09 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 3/20/2020 4:05 PM, Rob Herring wrote:
> >>>> Because the primary PHY0 can be autodetected by the bus scan.
> >>>> But I have nothing against your suggestions. Please, some one should say the
> >>>> last word here, how exactly it should be implemented?
> >>
> >> It's not for me to decide, I was hoping the Device Tree maintainers
> >> could chime in, your current approach would certainly work although it
> >> feels visually awkward.
> >
> > Something like this is what I'd do:
> >
> > ethernet-phy@4 {
> > compatible = "nxp,tja1102";
> > reg = <4 5>;
> > };
>
> But the parent (MDIO bus controller) has #address-cells = 1 and
> #size-cells = 0, so how can this be made to work without creating two
> nodes or a first node encapsulating another one?
That is the size of the address, not how many addresses there are. If
the device has 2 addresses, then 2 address entries seems entirely
appropriate.
Rob
next prev parent reply other threads:[~2020-03-23 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 5:22 [PATCH v4 0/4] add TJA1102 support Oleksij Rempel
2020-03-13 5:22 ` [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx Oleksij Rempel
2020-03-13 18:02 ` Florian Fainelli
2020-03-13 18:10 ` Andrew Lunn
2020-03-13 18:16 ` Oleksij Rempel
2020-03-13 18:20 ` Florian Fainelli
2020-03-13 18:53 ` Oleksij Rempel
2020-03-17 11:56 ` Oleksij Rempel
2020-03-17 19:48 ` Florian Fainelli
2020-03-20 23:05 ` Rob Herring
2020-03-22 21:09 ` Florian Fainelli
2020-03-23 14:20 ` Rob Herring [this message]
2020-04-28 17:30 ` Rob Herring
2020-04-29 4:38 ` Oleksij Rempel
2020-04-29 4:45 ` Florian Fainelli
2020-03-13 5:22 ` [PATCH v4 2/4] net: phy: tja11xx: add initial TJA1102 support Oleksij Rempel
2020-03-13 5:22 ` [PATCH v4 3/4] net: mdio: of: export part of of_mdiobus_register_phy() Oleksij Rempel
2020-03-13 5:22 ` [PATCH v4 4/4] net: phy: tja11xx: add delayed registration of TJA1102 PHY1 Oleksij Rempel
2020-03-16 8:44 ` [PATCH v4 0/4] add TJA1102 support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+KHfW0LtzJQFjB7HTWFBGf_9fe79nKBSe-g5npRYfZ6A@mail.gmail.com \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).