From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: od@zcrc.me, Linux I2C <linux-i2c@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()
Date: Tue, 15 Sep 2020 12:58:44 -0600 [thread overview]
Message-ID: <CAL_Jsq+O7YD+WuABOMvWT-uyuDvt6L9wQmeFunR-z4RpXLFo2A@mail.gmail.com> (raw)
In-Reply-To: <EGJPGQ.QVHGTYQDQR872@crapouillou.net>
On Tue, Sep 15, 2020 at 10:07 AM Paul Cercueil <paul@crapouillou.net> wrote:
>
>
>
> Le mar. 15 sept. 2020 à 10:03, Rob Herring <robh@kernel.org> a écrit :
> > On Tue, Sep 15, 2020 at 4:07 AM Paul Cercueil <paul@crapouillou.net>
> > wrote:
> >>
> >> Hi Rob,
> >>
> >> Le lun. 14 sept. 2020 à 16:12, Rob Herring <robh@kernel.org> a
> >> écrit :
> >> > On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote:
> >> >> CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't
> >> >> need to
> >> >> handle the case where Device Tree is not supported.
> >> >
> >> > What about COMPILE_TEST? If not supported, why not?
> >>
> >> What about it? It will still compile fine with COMPILE_TEST.
> >
> > CONFIG_OF could be disabled in that case, so the above reasoning
> > doesn't hold.
> >
>
> CONFIG_OF can be disabled in that case, correct, but why should we
> care? The driver will still compile fine.
Indeed, because jz4780_i2c_of_matches isn't within a CONFIG_OF ifdef
as is sometimes done and is when you need of_match_ptr(). IMO, the
commit msg should have something like "The driver is only used with
CONFIG_OF enabled, so of_match_ptr() is not necessary.
jz4780_i2c_of_matches is always defined."
Rob
next prev parent reply other threads:[~2020-09-15 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 13:11 [PATCH 1/3] dt-bindings: i2c: ingenic: Add compatible string for the JZ4770 Paul Cercueil
2020-09-04 13:11 ` [PATCH 2/3] i2c: jz4780: Add compatible string for JZ4770 SoC Paul Cercueil
2020-09-21 9:47 ` Wolfram Sang
2020-09-04 13:11 ` [PATCH 3/3] i2c: jz4780: Remove of_match_ptr() Paul Cercueil
2020-09-14 22:12 ` Rob Herring
2020-09-15 10:07 ` Paul Cercueil
2020-09-15 16:03 ` Rob Herring
2020-09-15 16:07 ` Paul Cercueil
2020-09-15 18:58 ` Rob Herring [this message]
2020-09-21 9:42 ` Wolfram Sang
2020-09-21 9:47 ` Wolfram Sang
2020-09-14 22:13 ` [PATCH 1/3] dt-bindings: i2c: ingenic: Add compatible string for the JZ4770 Rob Herring
2020-09-21 9:47 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+O7YD+WuABOMvWT-uyuDvt6L9wQmeFunR-z4RpXLFo2A@mail.gmail.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).