From: Paul Cercueil <paul@crapouillou.net>
To: Rob Herring <robh@kernel.org>
Cc: od@zcrc.me, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()
Date: Tue, 15 Sep 2020 12:07:24 +0200 [thread overview]
Message-ID: <CS2PGQ.I4UMQBYTB15I2@crapouillou.net> (raw)
In-Reply-To: <20200914221230.GA349829@bogus>
Hi Rob,
Le lun. 14 sept. 2020 à 16:12, Rob Herring <robh@kernel.org> a écrit :
> On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote:
>> CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't
>> need to
>> handle the case where Device Tree is not supported.
>
> What about COMPILE_TEST? If not supported, why not?
What about it? It will still compile fine with COMPILE_TEST.
-Paul
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>> drivers/i2c/busses/i2c-jz4780.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-jz4780.c
>> b/drivers/i2c/busses/i2c-jz4780.c
>> index ed2ec86f6f1a..cb4a25ebb890 100644
>> --- a/drivers/i2c/busses/i2c-jz4780.c
>> +++ b/drivers/i2c/busses/i2c-jz4780.c
>> @@ -857,7 +857,7 @@ static struct platform_driver jz4780_i2c_driver
>> = {
>> .remove = jz4780_i2c_remove,
>> .driver = {
>> .name = "jz4780-i2c",
>> - .of_match_table = of_match_ptr(jz4780_i2c_of_matches),
>> + .of_match_table = jz4780_i2c_of_matches,
>> },
>> };
>>
>> --
>> 2.28.0
>>
next prev parent reply other threads:[~2020-09-15 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 13:11 [PATCH 1/3] dt-bindings: i2c: ingenic: Add compatible string for the JZ4770 Paul Cercueil
2020-09-04 13:11 ` [PATCH 2/3] i2c: jz4780: Add compatible string for JZ4770 SoC Paul Cercueil
2020-09-21 9:47 ` Wolfram Sang
2020-09-04 13:11 ` [PATCH 3/3] i2c: jz4780: Remove of_match_ptr() Paul Cercueil
2020-09-14 22:12 ` Rob Herring
2020-09-15 10:07 ` Paul Cercueil [this message]
2020-09-15 16:03 ` Rob Herring
2020-09-15 16:07 ` Paul Cercueil
2020-09-15 18:58 ` Rob Herring
2020-09-21 9:42 ` Wolfram Sang
2020-09-21 9:47 ` Wolfram Sang
2020-09-14 22:13 ` [PATCH 1/3] dt-bindings: i2c: ingenic: Add compatible string for the JZ4770 Rob Herring
2020-09-21 9:47 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS2PGQ.I4UMQBYTB15I2@crapouillou.net \
--to=paul@crapouillou.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).