From: Rob Herring <robh@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sean Hudson <darknighte@darknighte.com>,
Frank Rowand <frowand.list@gmail.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Grant Likely <grant.likely@arm.com>,
Kumar Gala <kumar.gala@linaro.org>,
ARM-SoC Maintainers <arm@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 08/34] dt-bindings: arm: Convert PMU binding to json-schema
Date: Wed, 5 Dec 2018 09:42:04 -0600 [thread overview]
Message-ID: <CAL_Jsq+YsVB8Ew=cb5W54eirMpAAOR7ApahCbHOtp2m3wpJYSg@mail.gmail.com> (raw)
In-Reply-To: <20181205100858.GA14619@arm.com>
On Wed, Dec 5, 2018 at 4:08 AM Will Deacon <will.deacon@arm.com> wrote:
>
> Hi Rob,
>
> On Mon, Dec 03, 2018 at 03:31:57PM -0600, Rob Herring wrote:
> > Convert ARM PMU binding to DT schema format using json-schema.
>
> Just a couple of things below.
>
> > diff --git a/Documentation/devicetree/bindings/arm/pmu.yaml b/Documentation/devicetree/bindings/arm/pmu.yaml
> > new file mode 100644
> > index 000000000000..3ea4abfbf276
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/pmu.yaml
> > @@ -0,0 +1,91 @@
>
> [...]
>
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - apm,potenza-pmu
> > + - arm,armv8-pmuv3
> > + - arm,cortex-a73-pmu
> > + - arm,cortex-a72-pmu
> > + - arm,cortex-a57-pmu
> > + - arm,cortex-a53-pmu
> > + - arm,cortex-a35-pmu
> > + - arm,cortex-a17-pmu
> > + - arm,cortex-a15-pmu
> > + - arm,cortex-a12-pmu
> > + - arm,cortex-a9-pmu
> > + - arm,cortex-a8-pmu
> > + - arm,cortex-a7-pmu
> > + - arm,cortex-a5-pmu
> > + - arm,arm11mpcore-pmu
> > + - arm,arm1176-pmu
> > + - arm,arm1136-pmu
> > + - brcm,vulcan-pmu
> > + - cavium,thunder-pmu
> > + - qcom,scorpion-pmu
> > + - qcom,scorpion-mp-pmu
> > + - qcom,krait-pmu
> > + - items:
> > + - const: arm,cortex-a7-pmu
> > + - const: arm,cortex-a15-pmu
>
> What do these last two mean?
The first list only allows a single compatible string. This list says
there are 2 and that the compatible property should be:
compatible = "arm,cortex-a7-pmu", "arm,cortex-a15-pmu";
Which shows up here:
arch/arm/boot/dts/sun6i-a31.dtsi: compatible =
"arm,cortex-a7-pmu", "arm,cortex-a15-pmu";
arch/arm/boot/dts/sun7i-a20.dtsi: compatible =
"arm,cortex-a7-pmu", "arm,cortex-a15-pmu";
Maybe the dts is wrong and should be fixed?
> > + interrupts:
> > + # Don't know how many CPUs, so no constraints to specify
> > + description: 1 per-cpu interrupt (PPI) or 1 interrupt per core.
> > +
> > + interrupt-affinity:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + description:
> > + When using SPIs, specifies a list of phandles to CPU
> > + nodes corresponding directly to the affinity of
> > + the SPIs listed in the interrupts property.
> > +
> > + When using a PPI, specifies a list of phandles to CPU
> > + nodes corresponding to the set of CPUs which have
> > + a PMU of this type signalling the PPI listed in the
> > + interrupts property, unless this is already specified
> > + by the PPI interrupt specifier itself (in which case
> > + the interrupt-affinity property shouldn't be present).
> > +
> > + This property should be present when there is more than
> > + a single SPI.
> > +
> > + qcom,no-pc-write:
> > + type: boolean
> > + description:
> > + Indicates that this PMU doesn't support the 0xc and 0xd events.
> > +
> > + secure-reg-access:
> > + type: boolean
> > + description:
> > + Indicates that the ARMv7 Secure Debug Enable Register
> > + (SDER) is accessible. This will cause the driver to do
> > + any setup required that is only possible in ARMv7 secure
> > + state. If not present the ARMv7 SDER will not be touched,
> > + which means the PMU may fail to operate unless external
> > + code (bootloader or security monitor) has performed the
> > + appropriate initialisation. Note that this property is
> > + not valid for non-ARMv7 CPUs or ARMv7 CPUs booting Linux
> > + in Non-secure state.
> > +
> > +required:
> > + - compatible
>
> I probably said this before, but I do think that it's a shame to lose the
> example binding, especially for something like the PMU where you can
> pretty much take an example and bang in your own IRQ numbers to get it
> up and running.
I just thought it is so trivial that it didn't add much. I think most
folks would copy-n-paste from an actual dts file which has all the
other nodes you just need to update addresses and irq nums.
Rob
next prev parent reply other threads:[~2018-12-05 15:42 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181203213223.16986-1-robh@kernel.org>
2018-12-03 21:31 ` [PATCH v2 01/34] kbuild: Add support for DT binding schema checks Rob Herring
2018-12-08 4:47 ` Masahiro Yamada
2018-12-10 15:55 ` Rob Herring
2018-12-03 21:31 ` [PATCH v2 02/34] dt-bindings: Add a writing DT schemas how-to and annotated example Rob Herring
2018-12-03 21:31 ` [PATCH v2 03/34] dt-bindings: Convert trivial-devices.txt to json-schema Rob Herring
2018-12-03 21:31 ` [PATCH v2 04/34] dt-bindings: altera: Convert clkmgr binding " Rob Herring
2018-12-05 15:13 ` Dinh Nguyen
2018-12-03 21:31 ` [PATCH v2 05/34] dt-bindings: i2c: Convert i2c-gpio " Rob Herring
2018-12-03 21:31 ` [PATCH v2 06/34] dt-bindings: timer: Convert ARM timer bindings " Rob Herring
2018-12-03 21:31 ` [PATCH v2 07/34] dt-bindings: arm: Convert cpu binding " Rob Herring
2018-12-03 21:31 ` [PATCH v2 08/34] dt-bindings: arm: Convert PMU " Rob Herring
2018-12-05 10:08 ` Will Deacon
2018-12-05 15:42 ` Rob Herring [this message]
2018-12-06 14:37 ` Will Deacon
2018-12-03 21:31 ` [PATCH v2 09/34] dt-bindings: arm: Convert primecell " Rob Herring
2018-12-03 21:31 ` [PATCH v2 10/34] dt-bindings: arm: Convert Actions Semi bindings to jsonschema Rob Herring
2019-01-14 10:26 ` Manivannan Sadhasivam
2018-12-03 21:32 ` [PATCH v2 11/34] dt-bindings: arm: Convert Alpine board/soc bindings to json-schema Rob Herring
2018-12-04 7:53 ` Antoine Tenart
2018-12-03 21:32 ` [PATCH v2 12/34] dt-bindings: arm: Convert Altera " Rob Herring
2018-12-05 15:13 ` Dinh Nguyen
2018-12-03 21:32 ` [PATCH v2 13/34] dt-bindings: arm: amlogic: Move 'amlogic,meson-gx-ao-secure' binding to its own file Rob Herring
2018-12-04 8:31 ` [PATCH v2 13/34] dt-bindings: arm: amlogic: Move 'amlogic, meson-gx-ao-secure' " Neil Armstrong
2018-12-05 1:01 ` [PATCH v2 13/34] dt-bindings: arm: amlogic: Move 'amlogic,meson-gx-ao-secure' " Kevin Hilman
2018-12-05 4:18 ` Rob Herring
2019-01-09 16:12 ` Rob Herring
2018-12-03 21:32 ` [PATCH v2 14/34] dt-bindings: arm: Convert Amlogic board/soc bindings to json-schema Rob Herring
2018-12-04 8:39 ` Neil Armstrong
2018-12-04 14:44 ` Rob Herring
2018-12-06 21:27 ` Rob Herring
2018-12-03 21:32 ` [PATCH v2 15/34] dt-bindings: arm: Convert Atmel " Rob Herring
2018-12-04 8:12 ` Nicolas.Ferre
2018-12-04 22:48 ` Rob Herring
2018-12-03 21:32 ` [PATCH v2 16/34] dt-bindings: arm: Convert Calxeda " Rob Herring
2018-12-03 21:32 ` [PATCH v2 17/34] dt-bindings: arm: Convert TI davinci " Rob Herring
2018-12-06 10:28 ` Sekhar Nori
2018-12-03 21:32 ` [PATCH v2 18/34] dt-bindings: arm: Convert FSL " Rob Herring
2018-12-06 2:31 ` Shawn Guo
2018-12-06 23:33 ` Rob Herring
2018-12-08 1:58 ` Shawn Guo
2019-01-10 6:42 ` Shawn Guo
2019-01-10 10:44 ` Vokáč Michal
2019-01-10 13:44 ` Shawn Guo
2018-12-03 21:32 ` [PATCH v2 19/34] dt-bindings: arm: Convert MediaTek " Rob Herring
2018-12-03 21:32 ` [PATCH v2 20/34] dt-bindings: arm: Convert TI nspire " Rob Herring
2018-12-03 21:32 ` [PATCH v2 21/34] dt-bindings: arm: Convert Oxford Semi " Rob Herring
2018-12-04 8:43 ` Neil Armstrong
2018-12-04 14:04 ` Rob Herring
2018-12-03 21:32 ` [PATCH v2 22/34] dt-bindings: arm: Convert QCom " Rob Herring
2018-12-05 18:31 ` Andy Gross
2018-12-03 21:32 ` [PATCH v2 23/34] dt-bindings: arm: Convert Realtek " Rob Herring
2018-12-03 21:32 ` [PATCH v2 24/34] dt-bindings: arm: Convert Rockchip " Rob Herring
2018-12-04 14:16 ` Heiko Stuebner
2018-12-04 15:04 ` Rob Herring
2018-12-09 22:14 ` [PATCH v2.1 " Heiko Stuebner
2018-12-10 9:54 ` Heiko Stuebner
2018-12-10 15:13 ` Rob Herring
2018-12-10 22:45 ` [PATCH v2.2 " Heiko Stuebner
2018-12-11 15:21 ` Rob Herring
2018-12-03 21:32 ` [PATCH v2 25/34] dt-bindings: arm: renesas: Move 'renesas,prr' binding to its own doc Rob Herring
2018-12-04 14:44 ` Simon Horman
2018-12-04 14:56 ` Geert Uytterhoeven
2018-12-03 21:32 ` [PATCH v2 26/34] dt-bindings: arm: Convert Renesas board/soc bindings to json-schema Rob Herring
2018-12-04 14:48 ` Simon Horman
2018-12-04 14:57 ` Geert Uytterhoeven
2018-12-04 15:08 ` Rob Herring
2018-12-05 19:44 ` Simon Horman
2018-12-06 19:38 ` Rob Herring
2018-12-10 11:12 ` Simon Horman
2018-12-03 21:32 ` [PATCH v2 27/34] dt-bindings: arm: Convert CSR SiRF " Rob Herring
2018-12-03 21:32 ` [PATCH v2 28/34] dt-bindings: arm: Convert SPEAr " Rob Herring
2018-12-04 4:50 ` Viresh Kumar
2018-12-03 21:32 ` [PATCH v2 29/34] dt-bindings: arm: Convert ST STi " Rob Herring
2018-12-04 8:10 ` Patrice CHOTARD
2018-12-03 21:32 ` [PATCH v2 30/34] dt-bindings: arm: Convert Tegra " Rob Herring
2018-12-04 8:50 ` Thierry Reding
2018-12-06 22:38 ` Rob Herring
2018-12-07 11:46 ` Thierry Reding
2018-12-03 21:32 ` [PATCH v2 31/34] dt-bindings: arm: Convert VIA " Rob Herring
2018-12-03 21:32 ` [PATCH v2 32/34] dt-bindings: arm: Convert Xilinx " Rob Herring
2018-12-03 21:32 ` [PATCH v2 33/34] dt-bindings: arm: Add missing Xilinx boards Rob Herring
2018-12-03 21:32 ` [PATCH v2 34/34] dt-bindings: arm: Convert ZTE board/soc bindings to json-schema Rob Herring
2018-12-06 2:33 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+YsVB8Ew=cb5W54eirMpAAOR7ApahCbHOtp2m3wpJYSg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=arm@kernel.org \
--cc=darknighte@darknighte.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@arm.com \
--cc=kumar.gala@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).