From: Rob Herring <robh+dt@kernel.org>
To: David Daney <ddaney@caviumnetworks.com>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
David Daney <david.daney@cavium.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
Date: Tue, 18 Apr 2017 11:08:53 -0500 [thread overview]
Message-ID: <CAL_Jsq+_SO-Uzkp5MoCQkF0BWVuU4TFZEFb0tU8TjXE09PC4Ew@mail.gmail.com> (raw)
In-Reply-To: <1005a5c3-22d1-b082-0383-d8f74e711315@caviumnetworks.com>
On Tue, Apr 18, 2017 at 10:16 AM, David Daney <ddaney@caviumnetworks.com> wrote:
> On 04/17/2017 05:29 PM, Tyrel Datwyler wrote:
>>
>> The call to of_find_node_by_path("/cpus") returns the cpus device_node
>> with its reference count incremented. There is no matching of_node_put()
>> call in of_numa_parse_cpu_nodes() which results in a leaked reference
>> to the "/cpus" node.
>>
>> This patch adds an of_node_put() to release the reference.
>
>
> Good catch:
> Acked-by: David Daney <david.daney@cavium.com>
Applied, thanks.
Rob
prev parent reply other threads:[~2017-04-18 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 0:29 [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes() Tyrel Datwyler
2017-04-18 15:16 ` David Daney
2017-04-18 16:08 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+_SO-Uzkp5MoCQkF0BWVuU4TFZEFb0tU8TjXE09PC4Ew@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).