* [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
@ 2017-04-18 0:29 Tyrel Datwyler
2017-04-18 15:16 ` David Daney
0 siblings, 1 reply; 3+ messages in thread
From: Tyrel Datwyler @ 2017-04-18 0:29 UTC (permalink / raw)
To: robh+dt
Cc: devicetree, frowand.list, david.daney, linux-kernel, Tyrel Datwyler
The call to of_find_node_by_path("/cpus") returns the cpus device_node
with its reference count incremented. There is no matching of_node_put()
call in of_numa_parse_cpu_nodes() which results in a leaked reference
to the "/cpus" node.
This patch adds an of_node_put() to release the reference.
fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
---
drivers/of/of_numa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index a53982a..2db1f7a 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nodes(void)
else
node_set(nid, numa_nodes_parsed);
}
+
+ of_node_put(cpus);
}
static int __init of_numa_parse_memory_nodes(void)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
2017-04-18 0:29 [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes() Tyrel Datwyler
@ 2017-04-18 15:16 ` David Daney
2017-04-18 16:08 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: David Daney @ 2017-04-18 15:16 UTC (permalink / raw)
To: Tyrel Datwyler, robh+dt
Cc: devicetree, frowand.list, david.daney, linux-kernel
On 04/17/2017 05:29 PM, Tyrel Datwyler wrote:
> The call to of_find_node_by_path("/cpus") returns the cpus device_node
> with its reference count incremented. There is no matching of_node_put()
> call in of_numa_parse_cpu_nodes() which results in a leaked reference
> to the "/cpus" node.
>
> This patch adds an of_node_put() to release the reference.
Good catch:
Acked-by: David Daney <david.daney@cavium.com>
>
> fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
> Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> ---
> drivers/of/of_numa.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
> index a53982a..2db1f7a 100644
> --- a/drivers/of/of_numa.c
> +++ b/drivers/of/of_numa.c
> @@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nodes(void)
> else
> node_set(nid, numa_nodes_parsed);
> }
> +
> + of_node_put(cpus);
> }
>
> static int __init of_numa_parse_memory_nodes(void)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
2017-04-18 15:16 ` David Daney
@ 2017-04-18 16:08 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2017-04-18 16:08 UTC (permalink / raw)
To: David Daney, Tyrel Datwyler
Cc: devicetree, Frank Rowand, David Daney, linux-kernel
On Tue, Apr 18, 2017 at 10:16 AM, David Daney <ddaney@caviumnetworks.com> wrote:
> On 04/17/2017 05:29 PM, Tyrel Datwyler wrote:
>>
>> The call to of_find_node_by_path("/cpus") returns the cpus device_node
>> with its reference count incremented. There is no matching of_node_put()
>> call in of_numa_parse_cpu_nodes() which results in a leaked reference
>> to the "/cpus" node.
>>
>> This patch adds an of_node_put() to release the reference.
>
>
> Good catch:
> Acked-by: David Daney <david.daney@cavium.com>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-18 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-18 0:29 [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes() Tyrel Datwyler
2017-04-18 15:16 ` David Daney
2017-04-18 16:08 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).