From: Rob Herring <robh@kernel.org>
To: Yao Yuan <yao.yuan@nxp.com>
Cc: Yuan Yao <yao.yuan@freescale.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string
Date: Tue, 13 Dec 2016 15:14:03 -0600 [thread overview]
Message-ID: <CAL_Jsq+jp_2m7D=Hv6TRa+1nQZhPis-0MPK5kOAWge_7RvN4Qg@mail.gmail.com> (raw)
In-Reply-To: <DB6PR0402MB2902DADEB4E6D06418AD311F899B0@DB6PR0402MB2902.eurprd04.prod.outlook.com>
On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote:
> On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote:
>> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote:
>> > From: Yuan Yao <yao.yuan@nxp.com>
>>
>> Same problem in this subject too.
>>
>> >
>> > new compatible string: "fsl,ls1012a-qspi".
>> >
>> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
>> > ---
>> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
>> > 1 file changed, 1 insertion(+)
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> Thanks for your review.
> And do you have any suggestion for this subject?
The problem is you have a space in the compatible string: "fsl,
ls1012a-qspi" rather than "fsl,ls1012a-qspi"
Also, I prefer "dt/bindings: " as the beginning of binding patch subjects.
Rob
next prev parent reply other threads:[~2016-12-13 21:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 9:22 [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 1/5] arm64: dts: ls1012a: add the DTS node for DSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string Yuan Yao
2016-12-12 17:08 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl, ls1012a-dspi " Rob Herring
2016-12-08 9:23 ` [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor" Yuan Yao
2016-12-12 17:09 ` Rob Herring
2016-12-13 2:46 ` Yao Yuan
2016-12-08 9:23 ` [PATCH 4/5] arm64: dts: ls1012a: add the DTS node for QSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl,ls1012a-qspi compatible string Yuan Yao
2016-12-12 17:09 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi " Rob Herring
2016-12-13 2:47 ` Yao Yuan
2016-12-13 21:14 ` Rob Herring [this message]
2016-12-14 7:52 ` Yao Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+jp_2m7D=Hv6TRa+1nQZhPis-0MPK5kOAWge_7RvN4Qg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shawnguo@kernel.org \
--cc=yao.yuan@freescale.com \
--cc=yao.yuan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).