From: Rob Herring <robh@kernel.org>
To: Milo Kim <woogyom.kim@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-omap <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts
Date: Tue, 13 Dec 2016 15:09:23 -0600 [thread overview]
Message-ID: <CAL_JsqJL-oh9FwXSH=R2Vr1J2TDD1LqHfFY2es88rsq4Jz7DjQ@mail.gmail.com> (raw)
In-Reply-To: <fe4985c0-d60a-2562-12a7-064404efd64c@gmail.com>
On Mon, Dec 12, 2016 at 5:24 PM, Milo Kim <woogyom.kim@gmail.com> wrote:
> On 12/13/2016 02:25 AM, Rob Herring wrote:
>>
>> On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote:
>>>
>>> Interrupt numbers are from the datasheet, so no need to keep them in
>>> the ABI. Use the number in the DT file.
>>
>> I don't see the purpose of ripping this out. The headers have always
>> been for convienence, not whether the values come from the datasheet or
>> not.
>
>
> My understanding is it's a same rule as other interrupt controllers.
Oh yes, that's true. We never use defines for interrupts. In that case:
Acked-by: Rob Herring <robh@kernel.org>
Rob
next prev parent reply other threads:[~2016-12-13 21:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 6:28 [PATCH 0/4] dt-bindings: mfd: Update TPS65217 interrupts Milo Kim
2016-12-09 6:28 ` [PATCH 1/4] ARM: dts: am335x: Fix the interrupt name of TPS65217 Milo Kim
2016-12-09 6:28 ` [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts Milo Kim
2016-12-12 17:25 ` Rob Herring
2016-12-12 23:24 ` Milo Kim
2016-12-13 21:09 ` Rob Herring [this message]
2017-01-04 10:21 ` Lee Jones
2016-12-09 6:28 ` [PATCH 3/4] dt-bindings: power/supply: Update TPS65217 properties Milo Kim
2016-12-12 17:26 ` Rob Herring
2017-01-12 3:47 ` Sebastian Reichel
2016-12-09 6:28 ` [PATCH 4/4] dt-bindings: input: Specify the interrupt number of TPS65217 power button Milo Kim
2016-12-12 17:27 ` Rob Herring
2016-12-27 17:52 ` [PATCH 0/4] dt-bindings: mfd: Update TPS65217 interrupts Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJL-oh9FwXSH=R2Vr1J2TDD1LqHfFY2es88rsq4Jz7DjQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
--cc=woogyom.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).