* [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
@ 2022-10-28 23:13 Krzysztof Kozlowski
2022-10-31 8:49 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-28 23:13 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Heiko Stuebner,
Dmitry Osipenko, Chris Zhong, Zhang Qing, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip
Cc: Krzysztof Kozlowski
Core schema does not define type of monitored-battery, so the schemas
are expected to reference proper type.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
index 06ed9ec8f4bb..b4c6f9529ce1 100644
--- a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
+++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
@@ -22,7 +22,9 @@ properties:
reg:
maxItems: 1
- monitored-battery: true
+ monitored-battery:
+ $ref: /schemas/types.yaml#/definitions/phandle
+
power-supplies: true
system-power-controller: true
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
index 935e17099213..d136a05c7758 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
@@ -126,6 +126,7 @@ properties:
type: object
properties:
monitored-battery:
+ $ref: /schemas/types.yaml#/definitions/phandle
description: |
A phandle to a monitored battery node that contains a valid
value for:
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
2022-10-28 23:13 [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery Krzysztof Kozlowski
@ 2022-10-31 8:49 ` Lee Jones
2022-10-31 19:26 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2022-10-31 8:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner,
Dmitry Osipenko, Chris Zhong, Zhang Qing, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip
On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> Core schema does not define type of monitored-battery, so the schemas
> are expected to reference proper type.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
2022-10-31 8:49 ` Lee Jones
@ 2022-10-31 19:26 ` Rob Herring
2022-11-01 10:25 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-10-31 19:26 UTC (permalink / raw)
To: Lee Jones
Cc: Krzysztof Kozlowski, Krzysztof Kozlowski, Heiko Stuebner,
Dmitry Osipenko, Chris Zhong, Zhang Qing, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip
On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
>
> > Core schema does not define type of monitored-battery, so the schemas
> > are expected to reference proper type.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> > 2 files changed, 4 insertions(+), 1 deletion(-)
>
> Applied, thanks.
NAK. Please drop or revert.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
2022-10-31 19:26 ` Rob Herring
@ 2022-11-01 10:25 ` Lee Jones
2022-11-01 17:25 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2022-11-01 10:25 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Krzysztof Kozlowski, Heiko Stuebner,
Dmitry Osipenko, Chris Zhong, Zhang Qing, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip
On Mon, 31 Oct 2022, Rob Herring wrote:
> On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> >
> > > Core schema does not define type of monitored-battery, so the schemas
> > > are expected to reference proper type.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > ---
> > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> > > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > Applied, thanks.
>
> NAK. Please drop or revert.
Dropping is not a problem.
Would you mind providing some context?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
2022-11-01 10:25 ` Lee Jones
@ 2022-11-01 17:25 ` Rob Herring
2022-11-02 11:37 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-11-01 17:25 UTC (permalink / raw)
To: Lee Jones
Cc: Krzysztof Kozlowski, Krzysztof Kozlowski, Heiko Stuebner,
Dmitry Osipenko, Chris Zhong, Zhang Qing, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip
On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote:
>
> On Mon, 31 Oct 2022, Rob Herring wrote:
>
> > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> > >
> > > > Core schema does not define type of monitored-battery, so the schemas
> > > > are expected to reference proper type.
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > ---
> > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> > > > 2 files changed, 4 insertions(+), 1 deletion(-)
> > >
> > > Applied, thanks.
> >
> > NAK. Please drop or revert.
>
> Dropping is not a problem.
>
> Would you mind providing some context?
I did elsewhere in the series, but simply we don't want to define a
type for a property multiple times. It should be defined once
somewhere common.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
2022-11-01 17:25 ` Rob Herring
@ 2022-11-02 11:37 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2022-11-02 11:37 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Krzysztof Kozlowski, Heiko Stuebner,
Dmitry Osipenko, Chris Zhong, Zhang Qing, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip
On Tue, 01 Nov 2022, Rob Herring wrote:
> On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Mon, 31 Oct 2022, Rob Herring wrote:
> >
> > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> > > >
> > > > > Core schema does not define type of monitored-battery, so the schemas
> > > > > are expected to reference proper type.
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > > ---
> > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> > > > > 2 files changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > Applied, thanks.
> > >
> > > NAK. Please drop or revert.
> >
> > Dropping is not a problem.
> >
> > Would you mind providing some context?
>
> I did elsewhere in the series, but simply we don't want to define a
> type for a property multiple times. It should be defined once
> somewhere common.
ACK, thanks.
Dropped.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-02 11:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-28 23:13 [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery Krzysztof Kozlowski
2022-10-31 8:49 ` Lee Jones
2022-10-31 19:26 ` Rob Herring
2022-11-01 10:25 ` Lee Jones
2022-11-01 17:25 ` Rob Herring
2022-11-02 11:37 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).