From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
"Doug Berger" <opendmb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
linux-kernel@vger.kernel.org, "Jakub Kicinski" <kuba@kernel.org>,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH net-next 3/7] dt-bindings: net: Document moca PHY interface
Date: Wed, 1 Dec 2021 12:28:55 -0600 [thread overview]
Message-ID: <CAL_JsqJeO9eL-ygU-dEoV0DGOKwbM_i+PWaBTk2QCP6Wc69S5g@mail.gmail.com> (raw)
In-Reply-To: <52926c88-a51d-d4e8-a6ab-7cf92e35c7ba@gmail.com>
On Wed, Dec 1, 2021 at 11:15 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> On 12/1/21 6:33 AM, Rob Herring wrote:
> > On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote:
> >> MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores
> >> and will be needed in order to convert GENET to YAML in subsequent
> >> changes.
> >>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1561996
> >
> >
> > ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml
> >
> > ethernet@17020000: phy-handle: [[36], [37]] is too long
> > arch/arm64/boot/dts/apm/apm-mustang.dt.yaml
> >
> > ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
> > arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml
> > arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml
>
> These are all pre-existing warnings, but we should be documenting speed
> 2500 in ethernet-controller.yaml, so I will add a patch towards that end.
Thanks.
> The one for apm-mustand.dts however I am not sure how to best resolve
> since it looks like there was an intention to provide two Ethernet PHYs
> and presumably have the firmware prune the one that is not in use. I
> don't even know if that platform is supported mainline anymore.
Unfortunately it is, barely. I just fixed a breakage I caused 2 years
ago and just now noticed. I would not worry about it for now.
Rob
next prev parent reply other threads:[~2021-12-01 18:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 4:12 [PATCH net-next 0/7] Broadcom DT bindings conversion to YAML Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 1/7] dt-bindings: net: brcm,unimac-mdio: reg-names is optional Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 2/7] dt-bindings: net: brcm,unimac-mdio: Update maintainers for binding Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 3/7] dt-bindings: net: Document moca PHY interface Florian Fainelli
2021-12-01 14:33 ` Rob Herring
2021-12-01 17:15 ` Florian Fainelli
2021-12-01 18:28 ` Rob Herring [this message]
2021-12-01 4:12 ` [PATCH net-next 4/7] dt-bindings: net: Convert GENET binding to YAML Florian Fainelli
2021-12-01 14:33 ` Rob Herring
2021-12-01 4:12 ` [PATCH net-next 5/7] dt-bindings: net: Convert AMAC " Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 6/7] dt-bindings: net: Convert SYSTEMPORT " Florian Fainelli
2021-12-01 14:33 ` Rob Herring
2021-12-01 4:12 ` [PATCH net-next 7/7] dt-bindings: net: Convert iProc MDIO mux " Florian Fainelli
2021-12-01 14:33 ` Rob Herring
2021-12-01 19:06 ` Rob Herring
2021-12-01 19:48 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJeO9eL-ygU-dEoV0DGOKwbM_i+PWaBTk2QCP6Wc69S5g@mail.gmail.com \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=rafal@milecki.pl \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).