linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings
@ 2021-07-19 19:50 Rob Herring
  2021-07-23 21:17 ` Rob Herring
       [not found] ` <YPXZODWTE3qHQqEv@ravnborg.org>
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2021-07-19 19:50 UTC (permalink / raw)
  To: devicetree
  Cc: linux-kernel, David Airlie, Daniel Vetter, Rob Clark, Sean Paul,
	Marek Vasut, Krishna Manikandan, dri-devel

The graph schema doesn't allow custom properties on endpoint nodes for
'#/properties/port' and '#/$defs/port-base' should be used instead. This
doesn't matter until 'unevaluatedProperties' support is implemented.

Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Marek Vasut <marex@denx.de>
Cc: Krishna Manikandan <mkrishn@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml    | 6 ++++--
 .../bindings/display/msm/dsi-controller-main.yaml           | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index d101233ae17f..07b20383cbca 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -37,7 +37,8 @@ properties:
 
     properties:
       port@0:
-        $ref: /schemas/graph.yaml#/properties/port
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: Video port for MIPI DSI Channel-A input
 
         properties:
@@ -57,7 +58,8 @@ properties:
                   - const: 4
 
       port@1:
-        $ref: /schemas/graph.yaml#/properties/port
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: Video port for MIPI DSI Channel-B input
 
         properties:
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 76348b71f736..de23cab9b5f1 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -77,7 +77,8 @@ properties:
 
     properties:
       port@0:
-        $ref: "/schemas/graph.yaml#/properties/port"
+        $ref: "/schemas/graph.yaml#/$defs/port-base"
+        unevaluatedProperties: false
         description: |
           Input endpoints of the controller.
         properties:
@@ -92,7 +93,8 @@ properties:
                   enum: [ 0, 1, 2, 3 ]
 
       port@1:
-        $ref: "/schemas/graph.yaml#/properties/port"
+        $ref: "/schemas/graph.yaml#/$defs/port-base"
+        unevaluatedProperties: false
         description: |
           Output endpoints of the controller.
         properties:
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings
  2021-07-19 19:50 [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings Rob Herring
@ 2021-07-23 21:17 ` Rob Herring
       [not found] ` <YPXZODWTE3qHQqEv@ravnborg.org>
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-07-23 21:17 UTC (permalink / raw)
  To: Rob Herring
  Cc: Daniel Vetter, Rob Clark, devicetree, David Airlie, linux-kernel,
	Sean Paul, Marek Vasut, dri-devel, Krishna Manikandan

On Mon, 19 Jul 2021 13:50:01 -0600, Rob Herring wrote:
> The graph schema doesn't allow custom properties on endpoint nodes for
> '#/properties/port' and '#/$defs/port-base' should be used instead. This
> doesn't matter until 'unevaluatedProperties' support is implemented.
> 
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Krishna Manikandan <mkrishn@codeaurora.org>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml    | 6 ++++--
>  .../bindings/display/msm/dsi-controller-main.yaml           | 6 ++++--
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings
       [not found] ` <YPXZODWTE3qHQqEv@ravnborg.org>
@ 2021-07-23 21:25   ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-07-23 21:25 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: devicetree, Marek Vasut, Krishna Manikandan, David Airlie,
	linux-kernel, dri-devel, Sean Paul

On Mon, Jul 19, 2021 at 1:57 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Rob,
> On Mon, Jul 19, 2021 at 01:50:01PM -0600, Rob Herring wrote:
> > The graph schema doesn't allow custom properties on endpoint nodes for
> > '#/properties/port' and '#/$defs/port-base' should be used instead. This
> > doesn't matter until 'unevaluatedProperties' support is implemented.
> >
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Rob Clark <robdclark@gmail.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Krishna Manikandan <mkrishn@codeaurora.org>
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Thanks. FYI, your mail only went thru on dri-devel, but not DT or LKML lists.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-23 21:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 19:50 [PATCH] dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings Rob Herring
2021-07-23 21:17 ` Rob Herring
     [not found] ` <YPXZODWTE3qHQqEv@ravnborg.org>
2021-07-23 21:25   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).