From: Rob Herring <robh@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Mathieu Malaterre <malat@debian.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH RFC] Bindings: nvmem: add bindings for JZ4780 efuse
Date: Mon, 24 Feb 2020 09:15:05 -0600 [thread overview]
Message-ID: <CAL_JsqKNAQT996sDSW+k=SZq5NwzQn4wbEB0fS9_19rKdXMGYg@mail.gmail.com> (raw)
In-Reply-To: <20200224074804.3a5999ca@kemnade.info>
On Mon, Feb 24, 2020 at 12:48 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> On Thu, 20 Feb 2020 13:53:55 -0600
> Rob Herring <robh@kernel.org> wrote:
>
> [...]
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - clock
> >
> > 'make dt_binding_check' would have pointed the error here for you:
> >
> I did run make dt_binding_check...
> It stopped because the jz4780-cgu.h included was missing. Then I have added
> that line and have started dt_binding_check again.
> At least here it is doing a full rerun in the second part.
> After some time I scrolled back and noticed DTC passed
> and missed that
>
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.example.dt.yaml:
> > efuse@134100d0: 'clock' is a required property
> >
> in the CHECKS line. Well, dt_binding_check is a bit noisy. I guess I should
> have redirected all output to a text file, before and after my changes. and
> diffed the results.
> Is there any script ready for that?
grep 'ingenic,jz4780-efuse' <build log> ?
Noisy? There's 8 warnings on Linus' master currently[1]. I try to keep
that at 0, but I wouldn't call 8 noisy.
Rob
[1] https://gitlab.com/robherring/linux-dt-bindings/-/jobs/447630363
next prev parent reply other threads:[~2020-02-24 15:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 16:55 [RFC v4 0/6] MIPS: CI20: Add efuse driver for Ingenic JZ4780 and attach to DM9000 for stable MAC addresses H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 1/6] nvmem: add driver for JZ4780 efuse H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 2/6] Bindings: nvmem: add bindings " H. Nikolaus Schaller
2020-02-18 21:26 ` Rob Herring
2020-02-19 5:48 ` H. Nikolaus Schaller
2020-02-19 10:38 ` Zhou Yanjie
2020-02-19 11:03 ` Srinivas Kandagatla
2020-02-20 6:00 ` [PATCH RFC] " Andreas Kemnade
2020-02-20 19:53 ` Rob Herring
2020-02-24 6:48 ` Andreas Kemnade
2020-02-24 15:15 ` Rob Herring [this message]
2020-02-20 13:56 ` [RFC v4 2/6] " Jiaxun Yang
2020-02-17 16:55 ` [RFC v4 3/6] Documentation: ABI: nvmem: add documentation for JZ4780 efuse ABI H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 4/6] nvmem: MAINTAINERS: add maintainer for JZ4780 efuse driver H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 5/6] MIPS: DTS: JZ4780: define node for JZ4780 efuse H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 6/6] MIPS: DTS: CI20: make DM9000 Ethernet controller use NVMEM to find the default MAC address H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKNAQT996sDSW+k=SZq5NwzQn4wbEB0fS9_19rKdXMGYg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=malat@debian.org \
--cc=paul@crapouillou.net \
--cc=prasannatsmkumar@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).