From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Mathieu Malaterre <malat@debian.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-mips@vger.kernel.org,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [RFC v4 2/6] Bindings: nvmem: add bindings for JZ4780 efuse
Date: Wed, 19 Feb 2020 06:48:56 +0100 [thread overview]
Message-ID: <CFE9AEF5-FFF9-44A9-90D8-DE6AC7E7DD4F@goldelico.com> (raw)
In-Reply-To: <20200218212609.GA30081@bogus>
> Am 18.02.2020 um 22:26 schrieb Rob Herring <robh@kernel.org>:
>
> On Mon, Feb 17, 2020 at 05:55:26PM +0100, H. Nikolaus Schaller wrote:
>> From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>>
>> This patch brings support for the JZ4780 efuse. Currently it only expose
>> a read only access to the entire 8K bits efuse memory.
>>
>> Tested-by: Mathieu Malaterre <malat@debian.org>
>> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> .../bindings/nvmem/ingenic,jz4780-efuse.txt | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt
>
> Please convert to a DT schema.
Is there someone of you who can help to do that?
DT schemas are still like a Chinese dialect for me (i.e. I can decipher with help but neither speak nor write).
BR and thanks,
Nikolaus
>
>> diff --git a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt
>> new file mode 100644
>> index 000000000000..339e74daa9a9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt
>> @@ -0,0 +1,17 @@
>> +Ingenic JZ EFUSE driver bindings
>> +
>> +Required properties:
>> +- "compatible" Must be set to "ingenic,jz4780-efuse"
>> +- "reg" Register location and length
>> +- "clocks" Handle for the ahb clock for the efuse.
>> +- "clock-names" Must be "bus_clk"
>
> 'clk' is redundant. How about 'ahb'?
>
>> +
>> +Example:
>> +
>> +efuse: efuse@134100d0 {
>> + compatible = "ingenic,jz4780-efuse";
>> + reg = <0x134100d0 0x2c>;
>> +
>> + clocks = <&cgu JZ4780_CLK_AHB2>;
>> + clock-names = "bus_clk";
>> +};
>> --
>> 2.23.0
>>
next prev parent reply other threads:[~2020-02-19 5:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 16:55 [RFC v4 0/6] MIPS: CI20: Add efuse driver for Ingenic JZ4780 and attach to DM9000 for stable MAC addresses H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 1/6] nvmem: add driver for JZ4780 efuse H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 2/6] Bindings: nvmem: add bindings " H. Nikolaus Schaller
2020-02-18 21:26 ` Rob Herring
2020-02-19 5:48 ` H. Nikolaus Schaller [this message]
2020-02-19 10:38 ` Zhou Yanjie
2020-02-19 11:03 ` Srinivas Kandagatla
2020-02-20 6:00 ` [PATCH RFC] " Andreas Kemnade
2020-02-20 19:53 ` Rob Herring
2020-02-24 6:48 ` Andreas Kemnade
2020-02-24 15:15 ` Rob Herring
2020-02-20 13:56 ` [RFC v4 2/6] " Jiaxun Yang
2020-02-17 16:55 ` [RFC v4 3/6] Documentation: ABI: nvmem: add documentation for JZ4780 efuse ABI H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 4/6] nvmem: MAINTAINERS: add maintainer for JZ4780 efuse driver H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 5/6] MIPS: DTS: JZ4780: define node for JZ4780 efuse H. Nikolaus Schaller
2020-02-17 16:55 ` [RFC v4 6/6] MIPS: DTS: CI20: make DM9000 Ethernet controller use NVMEM to find the default MAC address H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CFE9AEF5-FFF9-44A9-90D8-DE6AC7E7DD4F@goldelico.com \
--to=hns@goldelico.com \
--cc=devicetree@vger.kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=malat@debian.org \
--cc=paul@crapouillou.net \
--cc=prasannatsmkumar@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).