linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks
@ 2021-12-06 12:43 Krzysztof Kozlowski
  2021-12-06 17:31 ` Rob Herring
  2021-12-07 15:09 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-06 12:43 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Liam Girdwood,
	Mark Brown, Rob Herring, linux-kernel, linux-samsung-soc,
	devicetree
  Cc: Rob Herring, stable

While converting bindings to dtschema, the buck regulators lost
"op_mode" property.  The "op_mode" is a valid property for all
regulators (both LDOs and bucks), so add it.

Reported-by: Rob Herring <robh@kernel.org>
Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../bindings/regulator/samsung,s5m8767.yaml   | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
index 80a63d47790a..c98929a213e9 100644
--- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
+++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
@@ -51,6 +51,19 @@ patternProperties:
     description:
       Properties for single BUCK regulator.
 
+    properties:
+      op_mode:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1, 2, 3]
+        default: 1
+        description: |
+          Describes the different operating modes of the regulator with power
+          mode change in SOC. The different possible values are:
+            0 - always off mode
+            1 - on in normal mode
+            2 - low power mode
+            3 - suspend mode
+
     required:
       - regulator-name
 
@@ -63,6 +76,18 @@ patternProperties:
       Properties for single BUCK regulator.
 
     properties:
+      op_mode:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1, 2, 3]
+        default: 1
+        description: |
+          Describes the different operating modes of the regulator with power
+          mode change in SOC. The different possible values are:
+            0 - always off mode
+            1 - on in normal mode
+            2 - low power mode
+            3 - suspend mode
+
       s5m8767,pmic-ext-control-gpios:
         maxItems: 1
         description: |
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks
  2021-12-06 12:43 [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks Krzysztof Kozlowski
@ 2021-12-06 17:31 ` Rob Herring
  2021-12-07 15:09 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-06 17:31 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bartlomiej Zolnierkiewicz, Liam Girdwood, Mark Brown,
	linux-kernel, linux-samsung-soc, devicetree, stable

On Mon, Dec 6, 2021 at 6:43 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> While converting bindings to dtschema, the buck regulators lost
> "op_mode" property.  The "op_mode" is a valid property for all
> regulators (both LDOs and bucks), so add it.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../bindings/regulator/samsung,s5m8767.yaml   | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks
  2021-12-06 12:43 [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks Krzysztof Kozlowski
  2021-12-06 17:31 ` Rob Herring
@ 2021-12-07 15:09 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-12-07 15:09 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz, linux-kernel, devicetree,
	linux-samsung-soc, Rob Herring, Krzysztof Kozlowski,
	Liam Girdwood
  Cc: Rob Herring, stable

On Mon, 6 Dec 2021 13:43:06 +0100, Krzysztof Kozlowski wrote:
> While converting bindings to dtschema, the buck regulators lost
> "op_mode" property.  The "op_mode" is a valid property for all
> regulators (both LDOs and bucks), so add it.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-linus

Thanks!

[1/1] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks
      commit: 85223d609c99eaa07cc598632b426cb33753526f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-07 15:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 12:43 [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks Krzysztof Kozlowski
2021-12-06 17:31 ` Rob Herring
2021-12-07 15:09 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).