From: Rob Herring <robh+dt@kernel.org>
To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc: broonie@kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
jarkko@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
skomatineni@nvidia.com, ldewangan@nvidia.com
Subject: Re: [Patch V2 3/4] spi: dt-bindings: Add Tegra TPM wait polling flag
Date: Fri, 3 Feb 2023 13:49:32 -0600 [thread overview]
Message-ID: <CAL_JsqKph2iK3Qb1=PFKxVScSs1f8sUcDh52py8WyhO6pu27TQ@mail.gmail.com> (raw)
In-Reply-To: <20230203130133.32901-4-kyarlagadda@nvidia.com>
On Fri, Feb 3, 2023 at 7:02 AM Krishna Yarlagadda
<kyarlagadda@nvidia.com> wrote:
>
> Add "nvidia,wait-polling" flag to enable TCG TIS hardware flow control.
Tell me something that the diff doesn't.
>
> Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> ---
> .../bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml
> index 2c3cada75339..19d2b30cadbf 100644
> --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml
> @@ -29,4 +29,10 @@ properties:
> minimum: 0
> maximum: 255
>
> + nvidia,wait-polling:
> + description:
> + Enable TPM wait polling feature for QSPI as specified in TCG PC Client
> + Specific TPM Interface Specification (TIS).
> + $ref: /schemas/types.yaml#/definitions/flag
Why do you need this flag when you have a compatible that also
indicates you have a quirk.
If this a TPM feature, why is it enabled for every single SPI slave device?
If the fundamental issue is the controller only supports half-duplex,
why can't you just check that from the driver? Can't the SPI subsystem
tell you that the host controller is half-duplex? Though sometimes
that may be board level property I suppose. If so, define the h/w
quirk, not the driver mode in DT. Half-duplex is probably something
everyone could use, not just Nvidia.
Please discuss this series internally with the folks you marked as
maintainers. It has issues I'm sure they would have also pointed out.
Rob
next prev parent reply other threads:[~2023-02-03 19:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:01 [Patch V2 0/4] Tegra TPM driver with hw flow control Krishna Yarlagadda
2023-02-03 13:01 ` [Patch V2 1/4] dt-bindings: tpm: Add compatible for Tegra TPM Krishna Yarlagadda
2023-02-03 18:57 ` Rob Herring
2023-02-03 13:01 ` [Patch V2 2/4] tpm: tegra: Support SPI tpm wait state detect Krishna Yarlagadda
2023-02-03 23:43 ` kernel test robot
2023-02-04 9:48 ` kernel test robot
2023-02-06 11:02 ` Paul Menzel
2023-02-06 13:19 ` Mark Brown
2023-02-06 16:10 ` Thierry Reding
2023-02-03 13:01 ` [Patch V2 3/4] spi: dt-bindings: Add Tegra TPM wait polling flag Krishna Yarlagadda
2023-02-03 19:49 ` Rob Herring [this message]
2023-02-23 16:26 ` Krishna Yarlagadda
2023-02-03 13:01 ` [Patch V2 4/4] spi: tegra210-quad: Enable TPM wait polling Krishna Yarlagadda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKph2iK3Qb1=PFKxVScSs1f8sUcDh52py8WyhO6pu27TQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=broonie@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).