* [PATCH] of: overlay: make pr_err() string unique
@ 2017-10-19 21:38 frowand.list
2017-10-19 22:13 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: frowand.list @ 2017-10-19 21:38 UTC (permalink / raw)
To: Rob Herring, pantelis.antoniou, Pantelis Antoniou
Cc: devicetree, linux-kernel
From: Frank Rowand <frank.rowand@sony.com>
The same error string occurs in drivers/of/resolver.c. Change
the error here to more precisely describe this case, and avoid
the possible confusion of looking in the wrong source location
to understand the cause of an error.
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
And yes, I was looking in the wrong file and not understanding
how this error could have been triggered by the example
provided. :-)
drivers/of/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index f5fce0fea40b..c150abb9049d 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -598,7 +598,7 @@ static int init_overlay_changeset(struct overlay_changeset *ovcs,
fragment->target = of_find_node_by_path("/__symbols__");
if (!fragment->target) {
- pr_err("no symbols in root of device tree.\n");
+ pr_err("symbols in overlay, but not in live tree\n");
ret = -EINVAL;
goto err_free_fragments;
}
--
Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of: overlay: make pr_err() string unique
2017-10-19 21:38 [PATCH] of: overlay: make pr_err() string unique frowand.list
@ 2017-10-19 22:13 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2017-10-19 22:13 UTC (permalink / raw)
To: Frank Rowand
Cc: Pantelis Antoniou, Pantelis Antoniou, devicetree, linux-kernel
On Thu, Oct 19, 2017 at 4:38 PM, <frowand.list@gmail.com> wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> The same error string occurs in drivers/of/resolver.c. Change
> the error here to more precisely describe this case, and avoid
> the possible confusion of looking in the wrong source location
> to understand the cause of an error.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
>
> And yes, I was looking in the wrong file and not understanding
> how this error could have been triggered by the example
> provided. :-)
>
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-19 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-19 21:38 [PATCH] of: overlay: make pr_err() string unique frowand.list
2017-10-19 22:13 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).