linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string
@ 2021-07-27  9:57 Yassine Oudjana
  2021-07-28 17:18 ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Yassine Oudjana @ 2021-07-27  9:57 UTC (permalink / raw)
  To: Michael Auchter
  Cc: Yassine Oudjana, MyungJoo Ham, Chanwoo Choi, Rob Herring,
	linux-kernel, devicetree

Add a compatible string for TUSB320L.

Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
---
 .../devicetree/bindings/extcon/extcon-usbc-tusb320.yaml       | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml b/Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml
index 9875b4d5c356..71a9f2e5d0dc 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml
+++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml
@@ -11,7 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    const: ti,tusb320
+    enum:
+      - ti,tusb320
+      - ti,tusb320l
 
   reg:
     maxItems: 1
-- 
2.32.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string
  2021-07-27  9:57 [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string Yassine Oudjana
@ 2021-07-28 17:18 ` Rob Herring
  2021-07-28 17:33   ` Yassine Oudjana
  0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-07-28 17:18 UTC (permalink / raw)
  To: Yassine Oudjana
  Cc: Rob Herring, Michael Auchter, devicetree, linux-kernel,
	Chanwoo Choi, MyungJoo Ham

On Tue, 27 Jul 2021 09:57:15 +0000, Yassine Oudjana wrote:
> Add a compatible string for TUSB320L.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
>  .../devicetree/bindings/extcon/extcon-usbc-tusb320.yaml       | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string
  2021-07-28 17:18 ` Rob Herring
@ 2021-07-28 17:33   ` Yassine Oudjana
  2021-07-29 18:51     ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Yassine Oudjana @ 2021-07-28 17:33 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rob Herring, Michael Auchter, devicetree, linux-kernel,
	Chanwoo Choi, MyungJoo Ham

On Wednesday, July 28th, 2021 at 9:18 PM, Rob Herring <robh@kernel.org> wrote:

> On Tue, 27 Jul 2021 09:57:15 +0000, Yassine Oudjana wrote:
>
> > Add a compatible string for TUSB320L.
> >
> > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> > -------------------------------------------------------
> >
> > .../devicetree/bindings/extcon/extcon-usbc-tusb320.yaml | 4 +++-
> >
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>
> there's no need to repost patches only to add the tags. The upstream
>
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.

I changed indentation in this version to fix a dt_binding_check warning:
../Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml:15:6: [warning] wrong indentation: expected 6 but found 5 (indentation)

I wasn't sure if I had to state changes in each individual patch, so
I ended up only stating them in the cover letter:
https://lore.kernel.org/lkml/a1IcsWeSdRxWaMFcwV1k7z3l1HaAkyRCo2zLdOWb8w@cp4-web-014.plabs.ch/

Regards,
Yassine

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string
  2021-07-28 17:33   ` Yassine Oudjana
@ 2021-07-29 18:51     ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-07-29 18:51 UTC (permalink / raw)
  To: Yassine Oudjana
  Cc: Michael Auchter, devicetree, linux-kernel, Chanwoo Choi, MyungJoo Ham

On Wed, Jul 28, 2021 at 11:33 AM Yassine Oudjana
<y.oudjana@protonmail.com> wrote:
>
> On Wednesday, July 28th, 2021 at 9:18 PM, Rob Herring <robh@kernel.org> wrote:
>
> > On Tue, 27 Jul 2021 09:57:15 +0000, Yassine Oudjana wrote:
> >
> > > Add a compatible string for TUSB320L.
> > >
> > > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> > > -------------------------------------------------------
> > >
> > > .../devicetree/bindings/extcon/extcon-usbc-tusb320.yaml | 4 +++-
> > >
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> >
> > there's no need to repost patches only to add the tags. The upstream
> >
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> I changed indentation in this version to fix a dt_binding_check warning:
> ../Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml:15:6: [warning] wrong indentation: expected 6 but found 5 (indentation)

That's certainly small enough change to keep any tag.

> I wasn't sure if I had to state changes in each individual patch, so
> I ended up only stating them in the cover letter:
> https://lore.kernel.org/lkml/a1IcsWeSdRxWaMFcwV1k7z3l1HaAkyRCo2zLdOWb8w@cp4-web-014.plabs.ch/

It is best to put the changes for specific patches in that patch and
use the cover letter as a summary of changes.

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-29 18:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27  9:57 [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string Yassine Oudjana
2021-07-28 17:18 ` Rob Herring
2021-07-28 17:33   ` Yassine Oudjana
2021-07-29 18:51     ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).