From: Rob Herring <robh@kernel.org>
To: Dilip Kota <eswara.kota@linux.intel.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com,
qi-ming.wu@intel.com
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: Add YAML schemas for the Intel Reset controller
Date: Mon, 26 Aug 2019 06:23:13 -0500 [thread overview]
Message-ID: <CAL_JsqLSU6+5umYeVmh1NYTcpUcpJKMt7d4d+5E+Ni5rqKJvxQ@mail.gmail.com> (raw)
In-Reply-To: <746ed130-a1ae-0cc2-5060-70de95cdf2fe@linux.intel.com>
On Mon, Aug 26, 2019 at 4:52 AM Dilip Kota <eswara.kota@linux.intel.com> wrote:
>
> Hi Rob,
>
> On 8/23/2019 8:25 PM, Rob Herring wrote:
> > On Fri, Aug 23, 2019 at 12:28 AM Dilip Kota <eswara.kota@linux.intel.com> wrote:
> >> Add YAML schemas for the reset controller on Intel
> >> Lightening Mountain (LGM) SoC.
> >>
> >> Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
> >> ---
> >> Changes on v2:
> >> Address review comments
> >> Update the compatible property definition
> >> Add description for reset-cells
> >> Add 'additionalProperties: false' property
> >>
> >> .../bindings/reset/intel,syscon-reset.yaml | 53 ++++++++++++++++++++++
> >> 1 file changed, 53 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml b/Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml
> >> new file mode 100644
> >> index 000000000000..3403a967190a
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml
> >> @@ -0,0 +1,53 @@
> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/reset/intel,syscon-reset.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Intel Lightening Mountain SoC System Reset Controller
> >> +
> >> +maintainers:
> >> + - Dilip Kota <eswara.kota@linux.intel.com>
> >> +
> >> +properties:
> >> + compatible:
> >> + items:
> >> + - const: intel,rcu-lgm
> >> + - const: syscon
> >> +
> >> + reg:
> >> + description: Reset controller register base address and size
> >> +
> >> + intel,global-reset:
> >> + $ref: /schemas/types.yaml#/definitions/uint32-array
> >> + description: Global reset register offset and bit offset.
> >> +
> >> + "#reset-cells":
> >> + const: 2
> >> + description: |
> >> + The 1st cell is the register offset.
> >> + The 2nd cell is the bit offset in the register.
> >> +
> >> +required:
> >> + - compatible
> >> + - reg
> >> + - intel,global-reset
> >> + - "#reset-cells"
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> + - |
> >> + rcu0: reset-controller@00000000 {
> >> + compatible = "intel,rcu-lgm", "syscon";
> >> + reg = <0x000000 0x80000>;
> >> + intel,global-reset = <0x10 30>;
> >> + #reset-cells = <2>;
> >> + };
> >> +
> >> + pcie_phy0: pciephy@... {
> >> + ...
> > You need to run 'make dt_binding_check' and fix the warnings. The
> > example has to be buildable and it is not.
>
> Sure, i will correct this pcie_phy0 node. But i didn't get any warnings
> for make dt_binding_check
>
> CHKDT Documentation/devicetree/bindings/reset/intel,syscon-reset.yaml
> DTC Documentation/devicetree/bindings/arm/renesas.example.dt.yaml
> FATAL ERROR: Unknown output format "yaml"
>
> Will DTC report about the example node errors? But, DTC is failing with
> FATAL_ERROR.
> I tried it even after installing libyaml and headers in my local
> directory and export the path, but no luck.(ref:
> https://lkml.org/lkml/2018/12/3/951)
> Could you please let me know if i miss anything and help me to proceed
> further.
See Documentation/devicetree/writing-schema.md
Rob
next prev parent reply other threads:[~2019-08-26 11:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 5:28 [PATCH v2 1/2] dt-bindings: reset: Add YAML schemas for the Intel Reset controller Dilip Kota
2019-08-23 5:28 ` [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC Dilip Kota
2019-08-23 8:43 ` Philipp Zabel
2019-08-23 9:47 ` Dilip Kota
2019-08-23 10:09 ` Philipp Zabel
2019-08-26 7:01 ` Dilip Kota
2019-08-24 21:11 ` Martin Blumenstingl
2019-08-26 4:01 ` Chuan Hua, Lei
2019-08-26 21:49 ` Martin Blumenstingl
2019-08-27 2:23 ` Chuan Hua, Lei
2019-08-27 21:15 ` Martin Blumenstingl
2019-08-28 1:53 ` Chuan Hua, Lei
2019-08-28 20:01 ` Martin Blumenstingl
2019-08-29 2:50 ` Chuan Hua, Lei
2019-08-29 21:40 ` Martin Blumenstingl
2019-08-30 3:01 ` Chuan Hua, Lei
2019-09-01 21:38 ` Martin Blumenstingl
2019-09-02 9:45 ` Chuan Hua, Lei
2019-09-02 22:04 ` Martin Blumenstingl
2019-09-05 2:38 ` Chuan Hua, Lei
2019-09-05 20:53 ` Martin Blumenstingl
2019-09-12 6:38 ` Dilip Kota
2019-09-19 8:05 ` Dilip Kota
2019-09-19 8:36 ` Langer, Thomas
2019-09-19 9:12 ` Dilip Kota
2019-09-19 19:51 ` Martin Blumenstingl
2019-09-20 2:47 ` Dilip Kota
[not found] ` <29965a80-642b-8f11-b3d4-25c09c3d96cc@linux.intel.com>
2019-10-03 6:50 ` Dilip Kota
2019-10-03 14:19 ` Philipp Zabel
2019-10-07 19:53 ` Martin Blumenstingl
2019-10-08 2:47 ` Dilip Kota
2019-10-08 15:56 ` Philipp Zabel
2019-10-14 9:41 ` Dilip Kota
2019-08-23 12:25 ` [PATCH v2 1/2] dt-bindings: reset: Add YAML schemas for the Intel Reset controller Rob Herring
2019-08-26 9:52 ` Dilip Kota
2019-08-26 11:23 ` Rob Herring [this message]
2019-08-27 14:04 ` Dilip Kota
2019-08-28 2:59 ` Dilip Kota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLSU6+5umYeVmh1NYTcpUcpJKMt7d4d+5E+Ni5rqKJvxQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).