From: Rob Herring <robh@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>,
"Ville Tervo" <ville.tervo@iki.fi>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Pavel Machek" <pavel@ucw.cz>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
linux-bluetooth@vger.kernel.org,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 3/7] dt: bindings: Add nokia-bluetooth
Date: Wed, 17 Aug 2016 08:11:03 -0500 [thread overview]
Message-ID: <CAL_JsqLcDzTZ++h+e7D-n0xbt7LgryK6jfGJDNEcAaU=Dn4b0w@mail.gmail.com> (raw)
In-Reply-To: <20160816232855.qgempm64zgp36ufd@earth>
On Tue, Aug 16, 2016 at 6:28 PM, Sebastian Reichel <sre@kernel.org> wrote:
> Hi Rob,
>
> On Tue, Aug 16, 2016 at 08:51:55AM -0500, Rob Herring wrote:
>> On Sat, Aug 13, 2016 at 05:14:34AM +0200, Sebastian Reichel wrote:
>> > ---
>> > .../devicetree/bindings/net/nokia-bluetooth.txt | 43 ++++++++++++++++++++++
>> > 1 file changed, 43 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/net/nokia-bluetooth.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/net/nokia-bluetooth.txt b/Documentation/devicetree/bindings/net/nokia-bluetooth.txt
>> > new file mode 100644
>> > index 000000000000..a0fceabb4cce
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/net/nokia-bluetooth.txt
>> > @@ -0,0 +1,43 @@
>> > +Nokia bluetooth UART devices
>> > +------
>> > +
>> > +Some vendors have custom versions of their chips, that can be found in Nokia
>> > +devices. These chips are controlled differently, than the non-Nokia version,
>> > +so a different binding is required. All chips listed here implement the Nokia
>> > +H4+ protocol.
>> > +
>> > +Required properties:
>> > +
>> > + - compatible: should be one of the following:
>> > + * "nokia,brcm,bcm2048"
>> > + * "nokia,ti,wl1271-bluetooth"
>>
>> Perhaps these should be 2 separate strings. Something like
>> '"nokia,n900-bt", "brcm,bcm2048"'. However, if they are in no way
>> compatible with the default version from the vendors, then just a single
>> string is fine, but it doesn't need to be aligned to the vendor
>> compatible string. So just "nokia,n900-bcm2048" or similar is fine.
>
> The default bcm2048 variant uses different initialization process
> and does not use word alignment as far as I know. I think having
> "brcm,bcm2048" in the compatible string is wrong.
Okay.
> I guess "brcm,bcm2048-nokia" would also be an option, since the
> chip has been built buy broadcom, but it has a custom Nokia
> interface.
That would be okay. Though, in theory Nokia could have different
products with bcm2048 all with different versions.
I was going with defining it as a board level compatible string. Even
if chips are the same, s/w can need to know board level differences so
using the board vendor and name are common.
>> > + - reset-gpios: Should specify the gpio for bluetooth reset
>> > + - host-wakeup-gpios: Should specify the gpio for host wakeup
>>
>> Should be interrupt instead?
>
> Yes this is mostly an interrupt, but I need to read the current
> line state.
When? If the interrupt is level triggered, then you can get the line
state based on whether you get an interrupt or not. If this needs to
be a wakeup source (see the wakeup source binding), then it needs to
be an interrupt.
Reading the line state is a common problem. It would be nice if the
irq API provided a function to read the line state though that is not
always possible.
>
>> > + - bluetooth-wakeup-gpios: Should specify the gpio for bluetooth wakeup
>>
>> State direction and active state for gpios.
>
> ok.
>
>> > + - clock-names: Should be "sysclk"
>> > + - clocks: Should contain a clock phandle for system clock
>> > +
>> > +Example:
>> > +
>> > +/ {
>> > + /* controlled (enabled/disabled) directly by wl1271 */
>> > + vctcxo: vctcxo {
>> > + compatible = "fixed-clock";
>> > + #clock-cells = <0>;
>> > + clock-frequency = <38400000>;
>> > + };
>> > +};
>> > +
>> > +&uart2 {
>>
>> I want to see a common serial device binding doc before accepting any
>> device bindings. It's not going to say much initially other than devices
>> are child nodes of uarts. Perhaps something on baudrate settings.
>
> Neil added a short sentence about this in "[RFC 2/7] tty: add
> support for "tty slave" devices". I just took the unmodified patch
> from Neil (*), so it's not in its own patch.
But that is in the 8250 binding. It needs to be a common binding.
Rob
next prev parent reply other threads:[~2016-08-17 13:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 3:14 [RFC 0/7] Nokia N9xx bluetooth driver Sebastian Reichel
2016-08-13 3:14 ` [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT init Sebastian Reichel
2016-08-14 8:49 ` Pavel Machek
2016-08-16 8:14 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 2/7] tty: add support for "tty slave" devices Sebastian Reichel
2016-08-13 10:03 ` Greg Kroah-Hartman
2016-08-13 20:31 ` Sebastian Reichel
2016-08-14 11:36 ` Greg Kroah-Hartman
2016-08-14 8:48 ` Pavel Machek
2016-08-14 11:35 ` Greg Kroah-Hartman
2016-08-13 3:14 ` [RFC 3/7] dt: bindings: Add nokia-bluetooth Sebastian Reichel
2016-08-16 13:51 ` Rob Herring
2016-08-16 23:28 ` Sebastian Reichel
2016-08-17 13:11 ` Rob Herring [this message]
2016-08-17 15:54 ` Pavel Machek
2016-08-13 3:14 ` [RFC 4/7] Bluetooth: hci_uart: Add support for word alignment Sebastian Reichel
2016-08-14 8:51 ` Pavel Machek
2016-08-16 7:05 ` Marcel Holtmann
2016-08-16 7:51 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel
2016-08-14 23:54 ` Paul Gortmaker
2016-08-15 1:12 ` Sebastian Reichel
2016-08-16 7:02 ` Marcel Holtmann
2016-08-16 7:52 ` Pali Rohár
2016-08-16 9:25 ` Sebastian Reichel
2016-08-16 9:09 ` Sebastian Reichel
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 20:05 ` Pavel Machek
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 8:10 ` Marcel Holtmann
2016-08-16 9:35 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 6/7] ARM: dts: OMAP3-N900: Add bluetooth Sebastian Reichel
2016-08-14 8:53 ` Pavel Machek
2016-08-13 3:14 ` [RFC 7/7] ARM: dts: OMAP3-N950: " Sebastian Reichel
2016-08-14 8:53 ` Pavel Machek
2016-08-16 7:10 ` [RFC 0/7] Nokia N9xx bluetooth driver Marcel Holtmann
2016-08-16 20:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLcDzTZ++h+e7D-n0xbt7LgryK6jfGJDNEcAaU=Dn4b0w@mail.gmail.com' \
--to=robh@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=filip.matijevic.pz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
--cc=ville.tervo@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).