From: Sebastian Reichel <sre@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>,
"Ville Tervo" <ville.tervo@iki.fi>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Pavel Machek" <pavel@ucw.cz>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
linux-serial@vger.kernel.org,
linux-omap <linux-omap@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver
Date: Tue, 16 Aug 2016 11:35:36 +0200 [thread overview]
Message-ID: <20160816093535.ykkvspxqinx2ogwt@earth> (raw)
In-Reply-To: <08EF658B-2BCB-46E2-B3DC-24FD12B4D5D8@holtmann.org>
[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]
Hi Marcel,
On Tue, Aug 16, 2016 at 10:10:07AM +0200, Marcel Holtmann wrote:
> > diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h
> > index a7d67aec3632..314b243df996 100644
> > --- a/drivers/bluetooth/hci_uart.h
> > +++ b/drivers/bluetooth/hci_uart.h
> > @@ -35,7 +35,7 @@
> > #define HCIUARTGETFLAGS _IOR('U', 204, int)
> >
> > /* UART protocols */
> > -#define HCI_UART_MAX_PROTO 10
> > +#define HCI_UART_MAX_PROTO 11
> >
> > #define HCI_UART_H4 0
> > #define HCI_UART_BCSP 1
> > @@ -47,6 +47,7 @@
> > #define HCI_UART_BCM 7
> > #define HCI_UART_QCA 8
> > #define HCI_UART_AG6XX 9
> > +#define HCI_UART_NOKIA 10
>
> since it seems the driver is getting closer to be ready,
> lets merge this extra protocol identifier as a separate patch.
depends on the definition of "the driver". It requires
the gpio information from DT, so it depends on the new
serial bus. I still have to implement that and it has
the potential to trigger a bit of discussion :)
Anyways I will split this out into its own patch later.
> Then we can adapt btattach as well for it.
It's enough to set ldisc=N_HCI and proto=HCI_UART_NOKIA.
Everything else is done by the protocol driver. I still
think it should be done from the kernel and will try to
come up with something in the serial bus.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-16 9:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 3:14 [RFC 0/7] Nokia N9xx bluetooth driver Sebastian Reichel
2016-08-13 3:14 ` [RFC 1/7] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT init Sebastian Reichel
2016-08-14 8:49 ` Pavel Machek
2016-08-16 8:14 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 2/7] tty: add support for "tty slave" devices Sebastian Reichel
2016-08-13 10:03 ` Greg Kroah-Hartman
2016-08-13 20:31 ` Sebastian Reichel
2016-08-14 11:36 ` Greg Kroah-Hartman
2016-08-14 8:48 ` Pavel Machek
2016-08-14 11:35 ` Greg Kroah-Hartman
2016-08-13 3:14 ` [RFC 3/7] dt: bindings: Add nokia-bluetooth Sebastian Reichel
2016-08-16 13:51 ` Rob Herring
2016-08-16 23:28 ` Sebastian Reichel
2016-08-17 13:11 ` Rob Herring
2016-08-17 15:54 ` Pavel Machek
2016-08-13 3:14 ` [RFC 4/7] Bluetooth: hci_uart: Add support for word alignment Sebastian Reichel
2016-08-14 8:51 ` Pavel Machek
2016-08-16 7:05 ` Marcel Holtmann
2016-08-16 7:51 ` Sebastian Reichel
2016-08-13 3:14 ` [RFC 5/7] Bluetooth: hci_nokia: Introduce new driver Sebastian Reichel
2016-08-14 23:54 ` Paul Gortmaker
2016-08-15 1:12 ` Sebastian Reichel
2016-08-16 7:02 ` Marcel Holtmann
2016-08-16 7:52 ` Pali Rohár
2016-08-16 9:25 ` Sebastian Reichel
2016-08-16 9:09 ` Sebastian Reichel
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 20:05 ` Pavel Machek
2016-08-16 10:23 ` Marcel Holtmann
2016-08-16 8:10 ` Marcel Holtmann
2016-08-16 9:35 ` Sebastian Reichel [this message]
2016-08-13 3:14 ` [RFC 6/7] ARM: dts: OMAP3-N900: Add bluetooth Sebastian Reichel
2016-08-14 8:53 ` Pavel Machek
2016-08-13 3:14 ` [RFC 7/7] ARM: dts: OMAP3-N950: " Sebastian Reichel
2016-08-14 8:53 ` Pavel Machek
2016-08-16 7:10 ` [RFC 0/7] Nokia N9xx bluetooth driver Marcel Holtmann
2016-08-16 20:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816093535.ykkvspxqinx2ogwt@earth \
--to=sre@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=filip.matijevic.pz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=ville.tervo@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).