* Bad MAINTAINERS pattern in section 'SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER'
@ 2018-09-28 22:03 Joe Perches
[not found] ` <CGME20181001080750epcas2p21b4c3e14be32859f31bede0656ffa09d@epcas2p2.samsung.com>
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2018-09-28 22:03 UTC (permalink / raw)
To: linux-kernel; +Cc: Łukasz Stelmach, linux-samsung-soc
Please fix this defect appropriately.
linux-next MAINTAINERS section:
12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER
12852 M: Łukasz Stelmach <l.stelmach@samsung.com>
12853 L: linux-samsung-soc@vger.kernel.org
12854 S: Maintained
12855 F: drivers/char/hw_random/exynos-trng.c
--> 12856 F: Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
Commit that introduced this:
commit 6cd225cc5d8a6526b2bea41955882be55d4f109e
Author: Łukasz Stelmach <l.stelmach@samsung.com>
Date: Fri Dec 22 17:48:35 2017 +0100
hwrng: exynos - add Samsung Exynos True RNG driver
Add support for True Random Number Generator found in Samsung Exynos
5250+ SoCs.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
MAINTAINERS | 7 ++
drivers/char/hw_random/Kconfig | 12 ++
drivers/char/hw_random/Makefile | 1 +
drivers/char/hw_random/exynos-trng.c | 237 +++++++++++++++++++++++++++++++++++
4 files changed, 257 insertions(+)
No commit with Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt found
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bad MAINTAINERS pattern in section 'SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER'
[not found] ` <CGME20181001080750epcas2p21b4c3e14be32859f31bede0656ffa09d@epcas2p2.samsung.com>
@ 2018-10-01 8:07 ` Łukasz Stelmach
2018-10-01 12:47 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Łukasz Stelmach @ 2018-10-01 8:07 UTC (permalink / raw)
To: Rob Herring; +Cc: Joe Perches, linux-kernel, linux-samsung-soc
[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]
It was <2018-09-29 sob 00:03>, when Joe Perches wrote:
> Please fix this defect appropriately.
>
> linux-next MAINTAINERS section:
>
> 12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER
> 12852 M: Łukasz Stelmach <l.stelmach@samsung.com>
> 12853 L: linux-samsung-soc@vger.kernel.org
> 12854 S: Maintained
> 12855 F: drivers/char/hw_random/exynos-trng.c
> --> 12856 F: Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
>
> Commit that introduced this:
>
> commit 6cd225cc5d8a6526b2bea41955882be55d4f109e
> Author: Łukasz Stelmach <l.stelmach@samsung.com>
> Date: Fri Dec 22 17:48:35 2017 +0100
>
> hwrng: exynos - add Samsung Exynos True RNG driver
>
> Add support for True Random Number Generator found in Samsung Exynos
> 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> MAINTAINERS | 7 ++
> drivers/char/hw_random/Kconfig | 12 ++
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/exynos-trng.c | 237 +++++++++++++++++++++++++++++++++++
> 4 files changed, 257 insertions(+)
>
> No commit with Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt found
Please merge the version 3[1] of the patch you've acked[2].
[1] https://www.spinics.net/lists/linux-samsung-soc/msg61372.html
[2] https://www.spinics.net/lists/linux-samsung-soc/msg61272.html
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bad MAINTAINERS pattern in section 'SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER'
2018-10-01 8:07 ` Łukasz Stelmach
@ 2018-10-01 12:47 ` Rob Herring
[not found] ` <CGME20181002075700epcas2p1e1650ae02c1d6b1bfb946b146d4ce223@epcas2p1.samsung.com>
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2018-10-01 12:47 UTC (permalink / raw)
To: Łukasz Stelmach; +Cc: Joe Perches, linux-kernel, linux-samsung-soc
On Mon, Oct 1, 2018 at 3:07 AM Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> It was <2018-09-29 sob 00:03>, when Joe Perches wrote:
> > Please fix this defect appropriately.
> >
> > linux-next MAINTAINERS section:
> >
> > 12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER
> > 12852 M: Łukasz Stelmach <l.stelmach@samsung.com>
> > 12853 L: linux-samsung-soc@vger.kernel.org
> > 12854 S: Maintained
> > 12855 F: drivers/char/hw_random/exynos-trng.c
> > --> 12856 F: Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
> >
> > Commit that introduced this:
> >
> > commit 6cd225cc5d8a6526b2bea41955882be55d4f109e
> > Author: Łukasz Stelmach <l.stelmach@samsung.com>
> > Date: Fri Dec 22 17:48:35 2017 +0100
> >
> > hwrng: exynos - add Samsung Exynos True RNG driver
> >
> > Add support for True Random Number Generator found in Samsung Exynos
> > 5250+ SoCs.
> >
> > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> >
> > MAINTAINERS | 7 ++
> > drivers/char/hw_random/Kconfig | 12 ++
> > drivers/char/hw_random/Makefile | 1 +
> > drivers/char/hw_random/exynos-trng.c | 237 +++++++++++++++++++++++++++++++++++
> > 4 files changed, 257 insertions(+)
> >
> > No commit with Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt found
>
> Please merge the version 3[1] of the patch you've acked[2].
Bindings in a series go in with the rest of the series. If you want me
to apply please resend as I don't have year old patches in my inbox.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings
[not found] ` <CGME20181002075700epcas2p1e1650ae02c1d6b1bfb946b146d4ce223@epcas2p1.samsung.com>
@ 2018-10-02 7:56 ` Łukasz Stelmach
2018-10-02 11:14 ` Krzysztof Kozlowski
[not found] ` <CGME20181004074641epcas1p287225c19a28c713327725d089068f960@epcas1p2.samsung.com>
0 siblings, 2 replies; 6+ messages in thread
From: Łukasz Stelmach @ 2018-10-02 7:56 UTC (permalink / raw)
To: Rob Herring
Cc: Joe Perches, linux-kernel, linux-samsung-soc, Łukasz Stelmach
Add binding documentation for the True Random Number Generator
found on Samsung Exynos 5250+ SoCs.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
.../bindings/rng/samsung,exynos5250-trng.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
diff --git a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
new file mode 100644
index 000000000000..5a613a4ec780
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
@@ -0,0 +1,17 @@
+Exynos True Random Number Generator
+
+Required properties:
+
+- compatible : Should be "samsung,exynos5250-trng".
+- reg : Specifies base physical address and size of the registers map.
+- clocks : Phandle to clock-controller plus clock-specifier pair.
+- clock-names : "secss" as a clock name.
+
+Example:
+
+ rng@10830600 {
+ compatible = "samsung,exynos5250-trng";
+ reg = <0x10830600 0x100>;
+ clocks = <&clock CLK_SSS>;
+ clock-names = "secss";
+ };
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings
2018-10-02 7:56 ` [PATCH] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings Łukasz Stelmach
@ 2018-10-02 11:14 ` Krzysztof Kozlowski
[not found] ` <CGME20181004074641epcas1p287225c19a28c713327725d089068f960@epcas1p2.samsung.com>
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2018-10-02 11:14 UTC (permalink / raw)
To: l.stelmach; +Cc: robh+dt, joe, linux-kernel, linux-samsung-soc
On Tue, 2 Oct 2018 at 09:57, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> Add binding documentation for the True Random Number Generator
> found on Samsung Exynos 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> .../bindings/rng/samsung,exynos5250-trng.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
Mine and Rob's tags disappeared already once (v2->v3) and... now
again (from v3 to here). Just amend the commit in your local repo and
add them permanently.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
> diff --git a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
> new file mode 100644
> index 000000000000..5a613a4ec780
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
> @@ -0,0 +1,17 @@
> +Exynos True Random Number Generator
> +
> +Required properties:
> +
> +- compatible : Should be "samsung,exynos5250-trng".
> +- reg : Specifies base physical address and size of the registers map.
> +- clocks : Phandle to clock-controller plus clock-specifier pair.
> +- clock-names : "secss" as a clock name.
> +
> +Example:
> +
> + rng@10830600 {
> + compatible = "samsung,exynos5250-trng";
> + reg = <0x10830600 0x100>;
> + clocks = <&clock CLK_SSS>;
> + clock-names = "secss";
> + };
> --
> 2.19.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v5.1] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings
[not found] ` <CGME20181004074641epcas1p287225c19a28c713327725d089068f960@epcas1p2.samsung.com>
@ 2018-10-04 7:45 ` Łukasz Stelmach
0 siblings, 0 replies; 6+ messages in thread
From: Łukasz Stelmach @ 2018-10-04 7:45 UTC (permalink / raw)
To: Rob Herring
Cc: Joe Perches, linux-kernel, linux-samsung-soc, Łukasz Stelmach
Add binding documentation for the True Random Number Generator
found on Samsung Exynos 5250+ SoCs.
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
This time with proper tags, as requested.
Kind regards,
ŁS
.../bindings/rng/samsung,exynos5250-trng.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
diff --git a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
new file mode 100644
index 000000000000..5a613a4ec780
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
@@ -0,0 +1,17 @@
+Exynos True Random Number Generator
+
+Required properties:
+
+- compatible : Should be "samsung,exynos5250-trng".
+- reg : Specifies base physical address and size of the registers map.
+- clocks : Phandle to clock-controller plus clock-specifier pair.
+- clock-names : "secss" as a clock name.
+
+Example:
+
+ rng@10830600 {
+ compatible = "samsung,exynos5250-trng";
+ reg = <0x10830600 0x100>;
+ clocks = <&clock CLK_SSS>;
+ clock-names = "secss";
+ };
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-04 7:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28 22:03 Bad MAINTAINERS pattern in section 'SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER' Joe Perches
[not found] ` <CGME20181001080750epcas2p21b4c3e14be32859f31bede0656ffa09d@epcas2p2.samsung.com>
2018-10-01 8:07 ` Łukasz Stelmach
2018-10-01 12:47 ` Rob Herring
[not found] ` <CGME20181002075700epcas2p1e1650ae02c1d6b1bfb946b146d4ce223@epcas2p1.samsung.com>
2018-10-02 7:56 ` [PATCH] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings Łukasz Stelmach
2018-10-02 11:14 ` Krzysztof Kozlowski
[not found] ` <CGME20181004074641epcas1p287225c19a28c713327725d089068f960@epcas1p2.samsung.com>
2018-10-04 7:45 ` [PATCH v5.1] " Łukasz Stelmach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).