From: Rob Herring <robh@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
"open list:MEDIA DRIVERS FOR RENESAS - FCP"
<linux-renesas-soc@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: reset: vexpress: fix build issue
Date: Fri, 22 May 2020 16:52:40 -0600 [thread overview]
Message-ID: <CAL_JsqLrK=C01S3XAU2zXyrnzje5kX81sFnb24DSWSaptQN67g@mail.gmail.com> (raw)
In-Reply-To: <20200522220103.908307-1-anders.roxell@linaro.org>
On Fri, May 22, 2020 at 4:01 PM Anders Roxell <anders.roxell@linaro.org> wrote:
>
It's soc@kernel.org that this needs to go to with an explicit request
for them to apply. Please resend so it gets in their Patchwork.
> An allmodconfig kernel makes CONFIG_VEXPRESS_CONFIG a module and
> CONFIG_POWER_RESET_VEXPRESS builtin. That makes us see this build
> error:
>
> aarch64-linux-gnu-ld: drivers/power/reset/vexpress-poweroff.o: in function `vexpress_reset_probe':
> ../drivers/power/reset/vexpress-poweroff.c:119: undefined reference to `devm_regmap_init_vexpress_config'
> ../drivers/power/reset/vexpress-poweroff.c:119:(.text+0x48c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol
> `devm_regmap_init_vexpress_config'
> make[1]: *** [/srv/src/kernel/next/Makefile:1126: vmlinux] Error 1
>
> Rework so that POWER_RESET_VEXPRESS depends on 'VEXPRESS_CONFIG=y'.
>
> Fixes: d06cfe3f123c ("bus: vexpress-config: Merge vexpress-syscfg into vexpress-config")
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/power/reset/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 4dfac618b942..f07b982c8dff 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -191,7 +191,7 @@ config POWER_RESET_VERSATILE
> config POWER_RESET_VEXPRESS
> bool "ARM Versatile Express power-off and reset driver"
> depends on ARM || ARM64
> - depends on VEXPRESS_CONFIG
> + depends on VEXPRESS_CONFIG=y
> help
> Power off and reset support for the ARM Ltd. Versatile
> Express boards.
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-22 22:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 22:01 [PATCH] power: reset: vexpress: fix build issue Anders Roxell
2020-05-22 22:52 ` Rob Herring [this message]
2020-05-24 22:20 ` Nathan Chancellor
2020-05-25 23:37 ` Valdis Klētnieks
2020-05-26 5:38 ` Nathan Chancellor
2020-05-26 15:41 ` Rob Herring
2020-05-27 6:28 ` Anders Roxell
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 14:21 Anders Roxell
2020-05-21 13:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLrK=C01S3XAU2zXyrnzje5kX81sFnb24DSWSaptQN67g@mail.gmail.com' \
--to=robh@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).