From: Vimal Agrawal <avimalin@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Jan Beulich <JBeulich@suse.com>, Jeff Mahoney <jeffm@suse.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kbuild@vger.kernel.org, jeyu@kernel.org,
linux-kernel@vger.kernel.org, nishit.shah@sophos.com,
Vimal Agrawal <vimal.agrawal@sophos.com>,
Dirk VanDerMerwe <Dirk.VanDerMerwe@sophos.com>,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v5] modules: add heuristic when stripping unneeded symbols
Date: Tue, 8 Feb 2022 23:42:02 +0530 [thread overview]
Message-ID: <CALkUMdQBEWANnNM1UYKcKOmAK=d9Abt1TmgvqNKSKyW9Vqd1JQ@mail.gmail.com> (raw)
In-Reply-To: <YgKugFcF1kkWPsNa@bombadil.infradead.org>
> You are saying that sometimes having "best" evaluated to non zero
> yields incorrect results, where the symbol found is actualy not a .text
> symbol for a text address? If so, is this really true for cases where
> no stripping is used? If so this is bigger news and I'd like to address
> this separately in another commit but we need proof, not just
> speculation.
>
I have not seen this issue without stripping so far as in that case it will find
some better match with some .text address but I have seen this consistently
with stripping.
> And you seem to be suggesting that this seems to hold more true when
> "--strip-unneeded" is used given there are fewer symbols left after
> striping?
>
yes. This is seen with stripping only.
> > without stripping, it will definitely
> > resolve to some .text address closely matching in case of no stripping
>
> OK so there is no issue when stripping is used.
>
yes. I assume you meant when stripping is not used.
> > but it can go wrong with stripping. I have seen it a few times post
> > the first patch during testing.
>
> OK then we need to take care your added heuristics do not affect
> non-stripping.
>
yes. so I tested .init , .text and one data address (without being
stripped) to make
sure there is no affect. Attached the result in my previous mail.
> > best could be incorrect even for text address when --strip-unneeded is used.
> > e.g. in my case, it is resolving .init.text address to __this_module
>
> You should be explicit about this in your commit log.
>
Ok
> When you submit a v2 patch and you change something like that you must
> clarify changes which are not clear either in the commit log or below
> the --- lines after the diffstat and before the actual patch. Each new
> patch iteration should have a set of bullets with all the changes you
> have made so that the maintainer can track what you have done
> differently on each iteration.
>
> Right now you are not making any of this easy on me so I ask that you
> stop submitting new patches willy nilly until we have actualy discussed
> each item, and we decide what to do. I also ask that you keep track of
> each change you are making on each new patch iteration on the patch
> after the --- lines and before the patch, so I can easily tell all the
> changes you have made on each new iteration.
>
Sure. Thanks for educating me.
> Luis
next prev parent reply other threads:[~2022-02-08 18:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <LO2P265MB2671DF8D82C0C6A1504D85D6939F9@LO2P265MB2671.GBRP265.PROD.OUTLOOK.COM>
[not found] ` <LO2P265MB267173F563B0A2CA5995FA2C939F9@LO2P265MB2671.GBRP265.PROD.OUTLOOK.COM>
2021-11-22 14:02 ` [PATCH] kernel/module.c: fix for symbol decode in stack trace for stripped modules Vimal Agrawal
2021-12-08 19:33 ` Luis Chamberlain
2021-12-09 5:37 ` Vimal Agrawal
2021-12-09 20:40 ` Luis Chamberlain
2021-12-20 8:57 ` Vimal Agrawal
2021-12-20 19:21 ` Luis Chamberlain
2021-12-21 9:06 ` Vimal Agrawal
2021-12-21 17:16 ` Vimal Agrawal
2021-12-21 22:45 ` Luis Chamberlain
2021-12-21 22:46 ` Luis Chamberlain
2021-12-22 13:23 ` [PATCH v2] kernel/module.c: heuristic enhancement when INSTALL_MOD_STRIP= "--strip-unneeded" is used Vimal Agrawal
2021-12-23 10:36 ` Christoph Hellwig
2021-12-23 11:09 ` Vimal Agrawal
2021-12-24 6:47 ` Christoph Hellwig
2021-12-25 1:08 ` Vimal Agrawal
2022-01-11 15:49 ` Luis Chamberlain
2022-01-12 8:36 ` Vimal Agrawal
2022-01-13 15:23 ` Luis Chamberlain
2022-01-17 6:54 ` [PATCH v3] kernel/module.c: heuristic enhancement in case symbols are missing e.g. " Vimal Agrawal
2022-02-02 20:20 ` Luis Chamberlain
2022-02-03 5:54 ` Vimal Agrawal
2022-02-03 6:06 ` [PATCH v4] modules: add heuristic when stripping unneeded symbols Vimal Agrawal
2022-02-04 8:39 ` [PATCH v5] " Vimal Agrawal
2022-02-04 21:47 ` Luis Chamberlain
2022-02-07 13:21 ` Vimal Agrawal
2022-02-07 22:07 ` Luis Chamberlain
2022-02-08 4:52 ` Vimal Agrawal
2022-02-08 11:02 ` [PATCH v6] " Vimal Agrawal
2022-02-08 11:13 ` Vimal Agrawal
2022-02-08 18:10 ` Luis Chamberlain
2022-02-08 18:25 ` Vimal Agrawal
2022-02-25 7:59 ` Vimal Agrawal
2022-02-25 13:40 ` Vimal Agrawal
2022-02-08 17:55 ` [PATCH v5] " Luis Chamberlain
2022-02-08 18:12 ` Vimal Agrawal [this message]
2022-01-17 7:34 ` [PATCH v2] kernel/module.c: heuristic enhancement when INSTALL_MOD_STRIP= "--strip-unneeded" is used Vimal Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkUMdQBEWANnNM1UYKcKOmAK=d9Abt1TmgvqNKSKyW9Vqd1JQ@mail.gmail.com' \
--to=avimalin@gmail.com \
--cc=Dirk.VanDerMerwe@sophos.com \
--cc=JBeulich@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jeffm@suse.com \
--cc=jeyu@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=nishit.shah@sophos.com \
--cc=sam@ravnborg.org \
--cc=vimal.agrawal@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).