From: Christoph Hellwig <hch@infradead.org>
To: Vimal Agrawal <avimalin@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Vimal Agrawal <vimal.Agrawal@sophos.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Jan Beulich <JBeulich@suse.com>, Jeff Mahoney <jeffm@suse.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kbuild@vger.kernel.org, jeyu@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kernel/module.c: heuristic enhancement when INSTALL_MOD_STRIP= "--strip-unneeded" is used
Date: Thu, 23 Dec 2021 22:47:55 -0800 [thread overview]
Message-ID: <YcVtG26b/sO9k7ox@infradead.org> (raw)
In-Reply-To: <CALkUMdRxTm6STT4CncTuvQ9hM_bez+B91TsuenEj71KPxFgMsg@mail.gmail.com>
On Thu, Dec 23, 2021 at 04:39:15PM +0530, Vimal Agrawal wrote:
> Hi Christoph,
>
> On Thu, Dec 23, 2021 at 4:06 PM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > We never build modules with that ёption, so this is completely pointless.
> >
> we use openwrt for build and packaging and it has been using this
> option for long.
>
> kbuild documentation says the following for INSTALL_MOD_STRIP:
> If this variable is specified, it will cause modules to be stripped
> after they are installed. If INSTALL_MOD_STRIP is ‘1’, then the
> default option –strip-debug will be used. Otherwise, the
> INSTALL_MOD_STRIP value will be used as the option(s) to the strip
> command.
>
> So if kbuild does not support INSTALL_MOD_STRIP=--strip-unneeded
> option then we should call out what it supports and should not even
> allow what is not supported. We don't know what other options others
> may be using but if we allow it then we should support it and it
> should not behave erratic just because someone is using a
> non-recommended option.
I don't think we can support passing arbitrary linker options and
expects things to work. If we want to support --strip-unneeded
it needs a good rationale and be added as a direct config option.
next prev parent reply other threads:[~2021-12-24 6:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <LO2P265MB2671DF8D82C0C6A1504D85D6939F9@LO2P265MB2671.GBRP265.PROD.OUTLOOK.COM>
[not found] ` <LO2P265MB267173F563B0A2CA5995FA2C939F9@LO2P265MB2671.GBRP265.PROD.OUTLOOK.COM>
2021-11-22 14:02 ` [PATCH] kernel/module.c: fix for symbol decode in stack trace for stripped modules Vimal Agrawal
2021-12-08 19:33 ` Luis Chamberlain
2021-12-09 5:37 ` Vimal Agrawal
2021-12-09 20:40 ` Luis Chamberlain
2021-12-20 8:57 ` Vimal Agrawal
2021-12-20 19:21 ` Luis Chamberlain
2021-12-21 9:06 ` Vimal Agrawal
2021-12-21 17:16 ` Vimal Agrawal
2021-12-21 22:45 ` Luis Chamberlain
2021-12-21 22:46 ` Luis Chamberlain
2021-12-22 13:23 ` [PATCH v2] kernel/module.c: heuristic enhancement when INSTALL_MOD_STRIP= "--strip-unneeded" is used Vimal Agrawal
2021-12-23 10:36 ` Christoph Hellwig
2021-12-23 11:09 ` Vimal Agrawal
2021-12-24 6:47 ` Christoph Hellwig [this message]
2021-12-25 1:08 ` Vimal Agrawal
2022-01-11 15:49 ` Luis Chamberlain
2022-01-12 8:36 ` Vimal Agrawal
2022-01-13 15:23 ` Luis Chamberlain
2022-01-17 6:54 ` [PATCH v3] kernel/module.c: heuristic enhancement in case symbols are missing e.g. " Vimal Agrawal
2022-02-02 20:20 ` Luis Chamberlain
2022-02-03 5:54 ` Vimal Agrawal
2022-02-03 6:06 ` [PATCH v4] modules: add heuristic when stripping unneeded symbols Vimal Agrawal
2022-02-04 8:39 ` [PATCH v5] " Vimal Agrawal
2022-02-04 21:47 ` Luis Chamberlain
2022-02-07 13:21 ` Vimal Agrawal
2022-02-07 22:07 ` Luis Chamberlain
2022-02-08 4:52 ` Vimal Agrawal
2022-02-08 11:02 ` [PATCH v6] " Vimal Agrawal
2022-02-08 11:13 ` Vimal Agrawal
2022-02-08 18:10 ` Luis Chamberlain
2022-02-08 18:25 ` Vimal Agrawal
2022-02-25 7:59 ` Vimal Agrawal
2022-02-25 13:40 ` Vimal Agrawal
2022-02-08 17:55 ` [PATCH v5] " Luis Chamberlain
2022-02-08 18:12 ` Vimal Agrawal
2022-01-17 7:34 ` [PATCH v2] kernel/module.c: heuristic enhancement when INSTALL_MOD_STRIP= "--strip-unneeded" is used Vimal Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcVtG26b/sO9k7ox@infradead.org \
--to=hch@infradead.org \
--cc=JBeulich@suse.com \
--cc=avimalin@gmail.com \
--cc=jeffm@suse.com \
--cc=jeyu@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=sam@ravnborg.org \
--cc=vimal.Agrawal@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).