* [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements
@ 2015-02-13 6:49 Tolga Ceylan
2015-02-13 8:27 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Tolga Ceylan @ 2015-02-13 6:49 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel, tolga.ceylan
Code reformatting based on checkpatch.pl with --strict:
1) Lines over 80 characters were fixed
2) Alignment should match open paranthesis cases corrected
3) Comparison to NULL rewritten as !indio_dev
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/iio/meter/ade7854-i2c.c | 39 +++++++++++++++++----------------
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
index 5b33c7f..fcb4714 100644
--- a/drivers/staging/iio/meter/ade7854-i2c.c
+++ b/drivers/staging/iio/meter/ade7854-i2c.c
@@ -16,8 +16,8 @@
#include "ade7854.h"
static int ade7854_i2c_write_reg_8(struct device *dev,
- u16 reg_address,
- u8 value)
+ u16 reg_address,
+ u8 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -35,8 +35,8 @@ static int ade7854_i2c_write_reg_8(struct device *dev,
}
static int ade7854_i2c_write_reg_16(struct device *dev,
- u16 reg_address,
- u16 value)
+ u16 reg_address,
+ u16 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -55,8 +55,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev,
}
static int ade7854_i2c_write_reg_24(struct device *dev,
- u16 reg_address,
- u32 value)
+ u16 reg_address,
+ u32 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -76,8 +76,8 @@ static int ade7854_i2c_write_reg_24(struct device *dev,
}
static int ade7854_i2c_write_reg_32(struct device *dev,
- u16 reg_address,
- u32 value)
+ u16 reg_address,
+ u32 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -98,8 +98,8 @@ static int ade7854_i2c_write_reg_32(struct device *dev,
}
static int ade7854_i2c_read_reg_8(struct device *dev,
- u16 reg_address,
- u8 *val)
+ u16 reg_address,
+ u8 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -124,8 +124,8 @@ out:
}
static int ade7854_i2c_read_reg_16(struct device *dev,
- u16 reg_address,
- u16 *val)
+ u16 reg_address,
+ u16 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -150,8 +150,8 @@ out:
}
static int ade7854_i2c_read_reg_24(struct device *dev,
- u16 reg_address,
- u32 *val)
+ u16 reg_address,
+ u32 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -176,8 +176,8 @@ out:
}
static int ade7854_i2c_read_reg_32(struct device *dev,
- u16 reg_address,
- u32 *val)
+ u16 reg_address,
+ u32 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -195,21 +195,22 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
if (ret)
goto out;
- *val = (st->rx[0] << 24) | (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3];
+ *val = (st->rx[0] << 24) | (st->rx[1] << 16)
+ | (st->rx[2] << 8) | st->rx[3];
out:
mutex_unlock(&st->buf_lock);
return ret;
}
static int ade7854_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+ const struct i2c_device_id *id)
{
int ret;
struct ade7854_state *st;
struct iio_dev *indio_dev;
indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*st));
- if (indio_dev == NULL)
+ if (!indio_dev)
return -ENOMEM;
st = iio_priv(indio_dev);
i2c_set_clientdata(client, indio_dev);
--
2.3.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements
2015-02-13 6:49 [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
@ 2015-02-13 8:27 ` Sudip Mukherjee
2015-02-13 22:05 ` Tolga Ceylan
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-02-13 8:27 UTC (permalink / raw)
To: Tolga Ceylan
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On Thu, Feb 12, 2015 at 10:49:46PM -0800, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> 1) Lines over 80 characters were fixed
> 2) Alignment should match open paranthesis cases corrected
> 3) Comparison to NULL rewritten as !indio_dev
you are doing three different types of changes here. one patch should have only one type of change.
regards
sudip
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 39 +++++++++++++++++----------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements
2015-02-13 8:27 ` Sudip Mukherjee
@ 2015-02-13 22:05 ` Tolga Ceylan
0 siblings, 0 replies; 3+ messages in thread
From: Tolga Ceylan @ 2015-02-13 22:05 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On Fri, Feb 13, 2015 at 12:27 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> you are doing three different types of changes here. one patch should have only one type of change.
>
> regards
> sudip
Thank you, I'll split this up and resubmit.
Regards,
Tolga
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-13 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-13 6:49 [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
2015-02-13 8:27 ` Sudip Mukherjee
2015-02-13 22:05 ` Tolga Ceylan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).