Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

[Pravin Shelar]

On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai <tiwai@suse.de> wrote:
> [I resent this since the previous mail didn't go out properly, as it
>  seems; apologies if you already read it, please disregard]
>
> Hi,
>
> I noticed that NFS access from my workstation slowed down drastically,
> almost stalls, with the fresh 4.3-rc3.  There are no particular kernel
> errors / warnings.
>

I have seen error reports related to IPv6 traffic which I am
debugging. Are you trying access NFS over IPv6?


> Then I performed git section, and it leaded to the commit:
> 6ae459bdaaeebc632b16e54dcbabb490c6931d61
>     skbuff: Fix skb checksum flag on skb pull
>
> Reverting this commit from 4.3-rc3 fixed the issue indeed.
>
> Could you take a look at this?  I added Trond to Cc in case he might
> already know of it.
>
>
> thanks,
>
> Takashi

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

[Pravin Shelar]

On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai <tiwai@suse.de> wrote:
> [I resent this since the previous mail didn't go out properly, as it
>  seems; apologies if you already read it, please disregard]
>
> Hi,
>
> I noticed that NFS access from my workstation slowed down drastically,
> almost stalls, with the fresh 4.3-rc3.  There are no particular kernel
> errors / warnings.
>
> Then I performed git section, and it leaded to the commit:
> 6ae459bdaaeebc632b16e54dcbabb490c6931d61
>     skbuff: Fix skb checksum flag on skb pull
>
> Reverting this commit from 4.3-rc3 fixed the issue indeed.
>
> Could you take a look at this?  I added Trond to Cc in case he might
> already know of it.
>
I send out fix for similar issue. Can you try the posted patch.
https://patchwork.ozlabs.org/patch/523632/

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

[Takashi Iwai]

On Tue, 29 Sep 2015 02:35:04 +0200,
Pravin Shelar wrote:
> 
> On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > [I resent this since the previous mail didn't go out properly, as it
> >  seems; apologies if you already read it, please disregard]
> >
> > Hi,
> >
> > I noticed that NFS access from my workstation slowed down drastically,
> > almost stalls, with the fresh 4.3-rc3.  There are no particular kernel
> > errors / warnings.
> >
> > Then I performed git section, and it leaded to the commit:
> > 6ae459bdaaeebc632b16e54dcbabb490c6931d61
> >     skbuff: Fix skb checksum flag on skb pull
> >
> > Reverting this commit from 4.3-rc3 fixed the issue indeed.
> >
> > Could you take a look at this?  I added Trond to Cc in case he might
> > already know of it.
> >
> I send out fix for similar issue. Can you try the posted patch.
> https://patchwork.ozlabs.org/patch/523632/

Yes, the patch fixes the problem, thanks.  Feel free to take my
tested-by tag:
  Tested-by: Takashi Iwai <tiwai@suse.de>

But I guess the real fix is only the first chunk and the latter is
nothing but a cleanup?  If so, it'd be better to split it.


Takashi

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

[Pravin Shelar]

On Tue, Sep 29, 2015 at 3:33 AM, Takashi Iwai <tiwai@suse.de> wrote:
> On Tue, 29 Sep 2015 02:35:04 +0200,
> Pravin Shelar wrote:
>>
>> On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> > [I resent this since the previous mail didn't go out properly, as it
>> >  seems; apologies if you already read it, please disregard]
>> >
>> > Hi,
>> >
>> > I noticed that NFS access from my workstation slowed down drastically,
>> > almost stalls, with the fresh 4.3-rc3.  There are no particular kernel
>> > errors / warnings.
>> >
>> > Then I performed git section, and it leaded to the commit:
>> > 6ae459bdaaeebc632b16e54dcbabb490c6931d61
>> >     skbuff: Fix skb checksum flag on skb pull
>> >
>> > Reverting this commit from 4.3-rc3 fixed the issue indeed.
>> >
>> > Could you take a look at this?  I added Trond to Cc in case he might
>> > already know of it.
>> >
>> I send out fix for similar issue. Can you try the posted patch.
>> https://patchwork.ozlabs.org/patch/523632/
>
> Yes, the patch fixes the problem, thanks.  Feel free to take my
> tested-by tag:
>   Tested-by: Takashi Iwai <tiwai@suse.de>
>
Thanks for testing the patch.

> But I guess the real fix is only the first chunk and the latter is
> nothing but a cleanup?  If so, it'd be better to split it.
>

Both chunks are required for the fix.