From: Douglas Anderson <dianders@chromium.org>
To: Kees Cook <keescook@chromium.org>, stable@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Guenter Roeck <linux@roeck-us.net>,
Dan Williams <dan.j.williams@intel.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH pstore-next v2 2/4] pstore: Allocate compression during late_initcall()
Date: Fri, 3 May 2019 11:37:51 -0700 [thread overview]
Message-ID: <CAM0oz-91yjPQKnxGDjwFThs19U=+iziuUr=9z13NSibr_uRxZQ@mail.gmail.com> (raw)
In-Reply-To: <20181018185616.14768-3-keescook@chromium.org>
Hi,
On Thu, Oct 18, 2018 at 11:56 AM Kees Cook <keescook@chromium.org> wrote:
>
> From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
>
> ramoops's call of pstore_register() was recently moved to run during
> late_initcall() because the crypto backend may not have been ready during
> postcore_initcall(). This meant early-boot crash dumps were not getting
> caught by pstore any more.
>
> Instead, lets allow calls to pstore_register() earlier, and once crypto
> is ready we can initialize the compression.
>
> Reported-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Fixes: cb3bee0369bc ("pstore: Use crypto compress API")
> [kees: trivial rebase]
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> fs/pstore/platform.c | 10 +++++++++-
> fs/pstore/ram.c | 2 +-
> 2 files changed, 10 insertions(+), 2 deletions(-)
I'd propose that these three patches:
95047b0519c1 pstore: Refactor compression initialization
416031653eb5 pstore: Allocate compression during late_initcall()
cb095afd4476 pstore: Centralize init/exit routines
Get sent to linux-stable. Specifically I'll mention that 4.19 needs
it. IMO the regression of pstore not catching early boot crashes is
pretty serious IMO.
Thanks!
-Doug
next prev parent reply other threads:[~2019-05-03 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 18:56 [PATCH pstore-next v2 0/4] Refactor compression initialization Kees Cook
2018-10-18 18:56 ` [PATCH pstore-next v2 1/4] pstore: Centralize init/exit routines Kees Cook
2018-10-18 18:56 ` [PATCH pstore-next v2 2/4] pstore: Allocate compression during late_initcall() Kees Cook
2019-05-03 18:37 ` Douglas Anderson [this message]
2019-05-05 13:16 ` Greg KH
2019-05-06 15:16 ` Doug Anderson
2019-05-06 15:38 ` Kees Cook
2019-05-06 16:05 ` Kees Cook
2019-05-20 11:07 ` Greg KH
2018-10-18 18:56 ` [PATCH pstore-next v2 3/4] pstore: Refactor compression initialization Kees Cook
2018-10-18 18:56 ` [PATCH pstore-next v2 4/4] pstore/ram: Clarify resource reservation labels Kees Cook
2018-10-18 22:01 ` [PATCH pstore-next v2 0/4] Refactor compression initialization Guenter Roeck
2018-10-18 22:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM0oz-91yjPQKnxGDjwFThs19U=+iziuUr=9z13NSibr_uRxZQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=dan.j.williams@intel.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).